chenyunda218
4a5d02fd70
considerPull 的 author-idle 分支缺少 #47 的交棒檢查，且既有 IsDeliveryReport 訊號為 issue 交付報告設計，PR 端「已就緒，可審閱＋ @審核者」形態無對應訊號——fox#60 作者留言交棒後仍被誤判 author-idle。 新增 IsReviewHandoff（@目前審核者帳號 ∧ 就緒語，mention 邊界感知 避免 @chenyunda218 誤命中 chenyunda），considerPull 在判 author-idle 前檢查，命中改判 reviewer-idle，讓既有 48 小時改派規則自然適用。 gitea.py 側 _consider pull 分支以 _is_review_handoff 同步（另 PR）。
641 lines
26 KiB
Go
641 lines
26 KiB
Go
// workflow 套件的單元測試（teai issue #7 驗收：xref 邊界案例與 stalled 判定）。
|
||
//
|
||
// fakeSource 以假資料實作 Source 介面，邏輯離線可測；
|
||
// 語義對照組是 alterminal/agents scripts/lib/gitea.py。
|
||
package workflow
|
||
|
||
import (
|
||
"bytes"
|
||
"encoding/json"
|
||
"errors"
|
||
"fmt"
|
||
"sort"
|
||
"strings"
|
||
"testing"
|
||
"time"
|
||
)
|
||
|
||
func at(minutes int) time.Time {
|
||
return time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC).Add(time.Duration(minutes) * time.Minute)
|
||
}
|
||
|
||
// fakeSource 是注入假資料的 Source。
|
||
type fakeSource struct {
|
||
orgs []string
|
||
repos map[string][]Repo
|
||
// issues[owner/repo][number]
|
||
issues map[string]map[int64]Issue
|
||
// pulls[owner/repo]
|
||
pulls map[string][]PullRequest
|
||
// comments[owner/repo/number]
|
||
comments map[string][]Comment
|
||
// timelines[owner/repo/number]：issue timeline 事件（nil → 空 timeline）。
|
||
timelines map[string][]TimelineEvent
|
||
}
|
||
|
||
func (f *fakeSource) MyOrganizations() ([]string, error) { return f.orgs, nil }
|
||
|
||
func (f *fakeSource) OrganizationRepositories(org string) ([]Repo, error) {
|
||
return f.repos[org], nil
|
||
}
|
||
|
||
func (f *fakeSource) OpenIssues(owner, repo string) ([]Issue, error) {
|
||
var out []Issue
|
||
for _, i := range f.issues[owner+"/"+repo] {
|
||
if i.State == "closed" {
|
||
continue // 對齊真實 API：OpenIssues 只回 open；closed 條目僅供 TryGetIssue 解引用。
|
||
}
|
||
out = append(out, i)
|
||
}
|
||
// 對齊真實 API：issues 依 id（=number）遞增回傳，消除 map 迭代隨機性。
|
||
sort.Slice(out, func(a, b int) bool { return out[a].Number < out[b].Number })
|
||
return out, nil
|
||
}
|
||
|
||
func (f *fakeSource) OpenPulls(owner, repo string) ([]PullRequest, error) {
|
||
return f.pulls[owner+"/"+repo], nil
|
||
}
|
||
|
||
func (f *fakeSource) IssueComments(owner, repo string, number int64) ([]Comment, error) {
|
||
return f.comments[fmt.Sprintf("%s/%s/%d", owner, repo, number)], nil
|
||
}
|
||
|
||
func (f *fakeSource) IssueTimeline(owner, repo string, number int64) ([]TimelineEvent, error) {
|
||
return f.timelines[fmt.Sprintf("%s/%s/%d", owner, repo, number)], nil
|
||
}
|
||
|
||
func (f *fakeSource) TryGetIssue(owner, repo string, number int64) (Issue, bool, error) {
|
||
i, ok := f.issues[owner+"/"+repo][number]
|
||
if !ok {
|
||
return Issue{}, false, nil
|
||
}
|
||
return i, true, nil
|
||
}
|
||
|
||
func repoWith(name string, hasPR bool) []Repo {
|
||
h := hasPR
|
||
return []Repo{{Name: name, HasPullRequests: &h}}
|
||
}
|
||
|
||
// iso 把相對分鐘轉成 parseMoment 可剖析的 ISO8601 字串（假資料用）。
|
||
func iso(minutes int) string { return FormatMoment(at(minutes)) }
|
||
|
||
func mustResolve(t *testing.T, org, repo string, texts []string, myOrgs map[string]bool, orgRepos func(string) ([]string, error)) []XrefTarget {
|
||
t.Helper()
|
||
targets, err := ResolveXrefTargets(org, repo, texts, myOrgs, orgRepos)
|
||
if err != nil {
|
||
t.Fatalf("ResolveXrefTargets: %v", err)
|
||
}
|
||
return targets
|
||
}
|
||
|
||
// TestIterXrefsEdges 驗證 regex 邊界：lookbehind 等價實作與兩段式斜線限制。
|
||
func TestIterXrefsEdges(t *testing.T) {
|
||
cases := []struct {
|
||
name string
|
||
text string
|
||
want [][2]string
|
||
}{
|
||
{"單段 #N", "父項：#3。", [][2]string{{"3"}, {"", "3"}}[1:]},
|
||
{"單段 repo#N 存在", "見 agents#10", [][2]string{{"agents", "10"}}},
|
||
{"PR#50 寫法不是 repo", "PR#50 與 issue#49", [][2]string{{"PR", "50"}, {"issue", "49"}}},
|
||
{"owner/repo#N", "alterminal/agents#32", [][2]string{{"alterminal/agents", "32"}}},
|
||
{"斜線後不切半段", "alterminal/bear#47 只應匹配整段", [][2]string{{"alterminal/bear", "47"}}},
|
||
{"連字號 repo 名", "bear-cli#9", [][2]string{{"bear-cli", "9"}}},
|
||
{"路徑後的 #N 不匹配", "see https://x/a/#frag not #5", [][2]string{{"", "5"}}},
|
||
// Python \w 是 Unicode：CJK 緊鄰 #N 時整體視為 \w，lookbehind 擋下。
|
||
{"CJK 緊鄰 #N 略過", "修復#12的問題，見 #5", [][2]string{{"", "5"}}},
|
||
{"CJK 緊鄰 repo#N 整段略過", "修復agents#12", nil},
|
||
{"CJK 緊鄰連字號 repo 匹配後半", "修復bear-cli#9 見 #5", [][2]string{{"cli", "9"}, {"", "5"}}},
|
||
{"連續井號", "##5", nil},
|
||
{"全形數字後 #N", "１２#5", nil},
|
||
}
|
||
for _, tc := range cases {
|
||
t.Run(tc.name, func(t *testing.T) {
|
||
got := iterXrefs(tc.text)
|
||
if len(got) != len(tc.want) {
|
||
t.Fatalf("iterXrefs(%q) = %v, want %v", tc.text, got, tc.want)
|
||
}
|
||
for i := range got {
|
||
if got[i] != tc.want[i] {
|
||
t.Fatalf("iterXrefs(%q)[%d] = %v, want %v", tc.text, i, got[i], tc.want[i])
|
||
}
|
||
}
|
||
})
|
||
}
|
||
}
|
||
|
||
// TestResolveXrefTargets 驗證三種形態的解析與單段 repo 的存在性邊界（#7 驗收）。
|
||
func TestResolveXrefTargets(t *testing.T) {
|
||
myOrgs := map[string]bool{"alterminal": true}
|
||
orgRepos := func(string) ([]string, error) { return []string{"agents", "teai", "bear-cli"}, nil }
|
||
texts := []string{"父項：#3，子項 teai#7，跨倉 alterminal/bear#35，不存在 nope#9，PR#50"}
|
||
|
||
got := mustResolve(t, "alterminal", "agents", texts, myOrgs, orgRepos)
|
||
want := []XrefTarget{
|
||
{Owner: "alterminal", Repo: "agents", Number: 3},
|
||
{Owner: "alterminal", Repo: "teai", Number: 7},
|
||
{Owner: "alterminal", Repo: "bear", Number: 35},
|
||
}
|
||
if len(got) != len(want) {
|
||
t.Fatalf("got %v, want %v", got, want)
|
||
}
|
||
for i := range want {
|
||
if got[i] != want[i] {
|
||
t.Fatalf("got[%d] %v, want %v", i, got[i], want[i])
|
||
}
|
||
}
|
||
}
|
||
|
||
// TestResolveXrefTargetsOwnerNotMyOrg owner/repo#N 的 owner 非所屬組織 → 不解析。
|
||
func TestResolveXrefTargetsOwnerNotMyOrg(t *testing.T) {
|
||
myOrgs := map[string]bool{"alterminal": true}
|
||
orgRepos := func(string) ([]string, error) { return nil, nil }
|
||
got := mustResolve(t, "alterminal", "agents", []string{"other/repo#1"}, myOrgs, orgRepos)
|
||
if len(got) != 0 {
|
||
t.Fatalf("owner 非所屬組織應略過，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestResolveXrefTargetsDedup 同一目標重複出現只保留第一個。
|
||
func TestResolveXrefTargetsDedup(t *testing.T) {
|
||
myOrgs := map[string]bool{"alterminal": true}
|
||
orgRepos := func(string) ([]string, error) { return []string{"teai"}, nil }
|
||
got := mustResolve(t, "alterminal", "agents", []string{"#7 又 teai#7"}, myOrgs, orgRepos)
|
||
if len(got) != 2 {
|
||
t.Fatalf("應兩筆（#7 同倉庫、teai#7 跨倉庫），got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledIssueReasons 驗證 issue 的 reason 分類與排序。
|
||
func TestScanStalledIssueReasons(t *testing.T) {
|
||
now := at(0)
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{
|
||
"alterminal": repoWith("agents", true),
|
||
},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/agents": {
|
||
1: {Number: 1, Title: "無分派者", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/agents"}, URL: "u1"},
|
||
2: {Number: 2, Title: "分派者自己最後留言", State: "open", User: &User{UserName: "ceo"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u2"},
|
||
3: {Number: 3, Title: "無留言", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u3"},
|
||
4: {Number: 4, Title: "等外部回應", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u4"},
|
||
5: {Number: 5, Title: "太新不在門檻內", State: "open", CreatedAt: iso(-30), UpdatedAt: iso(-30), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u5"},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
"alterminal/agents/2": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}},
|
||
"alterminal/agents/4": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300)}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
// 1: no-assignee（10h）、2: assignee-idle（5h）、3: no-commenter（5h）、4: waiting-outside（5h）、5: 不列入
|
||
if len(got) != 4 {
|
||
t.Fatalf("應 4 筆，got %d：%v", len(got), got)
|
||
}
|
||
byNumber := map[int64]Item{}
|
||
for _, it := range got {
|
||
byNumber[it.Number] = it
|
||
}
|
||
for n, wantReason := range map[int64]string{1: "no-assignee", 2: "assignee-idle", 3: "no-commenter", 4: "waiting-outside"} {
|
||
if byNumber[n].Reason != wantReason {
|
||
t.Errorf("issue %d reason = %q, want %q", n, byNumber[n].Reason, wantReason)
|
||
}
|
||
}
|
||
if got[0].Number != 1 || got[0].StalledHours != 10 {
|
||
t.Errorf("排序應由長到短，首筆 issue 1（10h），got %v", got[0])
|
||
}
|
||
if byNumber[2].LastCommentBy != "ceo" {
|
||
t.Errorf("issue 2 last_comment_by 應為 ceo，got %q", byNumber[2].LastCommentBy)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledNudgeCooldown 最後留言出自掃描者本人 → 24 小時內冷卻不列入。
|
||
func TestScanStalledNudgeCooldown(t *testing.T) {
|
||
now := at(0)
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("agents", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/agents": {
|
||
1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Assignees: []User{{UserName: "max"}}, Repository: &Repository{FullName: "alterminal/agents"}},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
// admin（掃描者）10 小時前催促過 → 冷卻中，不列入。
|
||
"alterminal/agents/1": {{User: &User{UserName: "admin"}, CreatedAt: iso(-600)}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 0 {
|
||
t.Fatalf("催促冷卻中的項目不應列入，got %v", got)
|
||
}
|
||
// 冷卻過了（25 小時前催促）→ 重新列入。
|
||
src.comments["alterminal/agents/1"] = []Comment{{User: &User{UserName: "admin"}, CreatedAt: iso(-1500)}}
|
||
got, err = ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 1 || got[0].Reason != "waiting-outside" {
|
||
t.Fatalf("冷卻後應重新列入，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledParentWrapup（teai #47，同步 agents #44）：子項全關閉的父追蹤項
|
||
// 不退回通用原因（assignee-idle），一律標 parent-tracking——「父項收尾」情境。
|
||
func TestScanStalledParentWrapup(t *testing.T) {
|
||
now := at(0)
|
||
// 父項 3 最後留言來自 assignee ceo（舊行為會誤標 assignee-idle）；
|
||
// 唯一子項 7 已關閉，父子最後活動皆 5 小時前。
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/teai": {
|
||
3: {Number: 3, Title: "父", State: "open", Body: "子項：#7", CreatedAt: iso(-700), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/teai"}},
|
||
7: {Number: 7, Title: "子", State: "closed", CreatedAt: iso(-650), UpdatedAt: iso(-300), Repository: &Repository{FullName: "alterminal/teai"}},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
"alterminal/teai/3": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
var parent *Item
|
||
for i := range got {
|
||
if got[i].Number == 3 {
|
||
parent = &got[i]
|
||
}
|
||
}
|
||
if parent == nil {
|
||
t.Fatalf("父項 3 應列入（5h 無活動），got %v", got)
|
||
}
|
||
if parent.Reason != "parent-tracking" {
|
||
t.Errorf("子項全關閉的父項 reason = %q, want parent-tracking", parent.Reason)
|
||
}
|
||
if len(parent.ChildActivity) == 0 {
|
||
t.Errorf("父項 3 應附 child_activity，got %v", parent.ChildActivity)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledParentTracking 父追蹤項：子項活動計入 last_activity、reason 標記。
|
||
func TestScanStalledParentTracking(t *testing.T) {
|
||
now := at(0)
|
||
// 父項與子項都 5 小時沒動：父項 last_activity 計入子項活動後同為 5h，
|
||
// 應以 parent-tracking 列入並附子項摘要；子項本身則是 assignee-idle。
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/teai": {
|
||
3: {Number: 3, Title: "父", State: "open", Body: "子項：#7", CreatedAt: iso(-700), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/teai"}},
|
||
7: {Number: 7, Title: "子", State: "open", CreatedAt: iso(-650), UpdatedAt: iso(-300), Assignees: []User{{UserName: "max"}}, Repository: &Repository{FullName: "alterminal/teai"}},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
"alterminal/teai/7": {{User: &User{UserName: "max"}, CreatedAt: iso(-300)}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
var parent3, child7 *Item
|
||
for i := range got {
|
||
switch got[i].Number {
|
||
case 3:
|
||
parent3 = &got[i]
|
||
case 7:
|
||
child7 = &got[i]
|
||
}
|
||
}
|
||
if child7 == nil {
|
||
t.Fatalf("子項 7 應列入（5h 無活動），got %v", got)
|
||
}
|
||
if child7.Reason != "assignee-idle" {
|
||
t.Errorf("子項 7 reason = %q, want assignee-idle", child7.Reason)
|
||
}
|
||
if parent3 == nil {
|
||
t.Fatalf("父項 3 應列入，got %v", got)
|
||
}
|
||
if parent3.Reason != "parent-tracking" {
|
||
t.Errorf("父項 3 reason = %q, want parent-tracking", parent3.Reason)
|
||
}
|
||
if len(parent3.ChildActivity) != 1 || parent3.ChildActivity[0].Number != 7 {
|
||
t.Errorf("父項 3 應附子項摘要，got %v", parent3.ChildActivity)
|
||
}
|
||
if parent3.StalledHours != 5 {
|
||
t.Errorf("父項 3 stalled_hours = %v, want 5", parent3.StalledHours)
|
||
}
|
||
|
||
// 子項 1 小時前恢復活動 → 父項 last_activity 跟著更新，未達門檻不列入；
|
||
// 子項本身也不停滯。整份輸出應為空。
|
||
child := src.issues["alterminal/teai"][7]
|
||
child.UpdatedAt = iso(-60)
|
||
src.issues["alterminal/teai"][7] = child
|
||
src.comments["alterminal/teai/7"] = []Comment{{User: &User{UserName: "max"}, CreatedAt: iso(-60)}}
|
||
got, err = ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 0 {
|
||
t.Fatalf("子項推進中 → 父項不應誤報停滯，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledParentTrackingNotChild 上行引用：引用對象早於父項 → 非子項，不採計。
|
||
func TestScanStalledParentTrackingNotChild(t *testing.T) {
|
||
now := at(0)
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/teai": {
|
||
47: {Number: 47, State: "open", Body: "規劃見 #39（更早）", CreatedAt: iso(-700), UpdatedAt: iso(-600), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/teai"}},
|
||
39: {Number: 39, State: "open", CreatedAt: iso(-2000), UpdatedAt: iso(-60), Repository: &Repository{FullName: "alterminal/teai"}},
|
||
},
|
||
},
|
||
}
|
||
// timeline：#47 的 updated_at 對應直接事件（assignees）、#39 對應 label
|
||
//（agents #34 後 updated_at 需經 timeline 核對才採計；直接事件可對應 → 採用）。
|
||
// 必須在 ScanStalled 之前設定——掃描當下讀不到的事後修改無效。
|
||
src.timelines = map[string][]TimelineEvent{
|
||
"alterminal/teai/47": {{Type: "assignees", CreatedAt: iso(-600)}},
|
||
"alterminal/teai/39": {{Type: "label", CreatedAt: iso(-60)}},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
// #39 是上行引用，不採計 → 父項 47 停滯 10h（assignee-idle：ceo 分派、無留言）→ no-commenter。
|
||
var n47 *Item
|
||
for i := range got {
|
||
if got[i].Number == 47 {
|
||
n47 = &got[i]
|
||
}
|
||
}
|
||
if n47 == nil {
|
||
t.Fatalf("上行引用不採計 → 47 應停滯列入，got %v", got)
|
||
}
|
||
if n47.Reason != "no-commenter" {
|
||
t.Errorf("47 reason = %q, want no-commenter", n47.Reason)
|
||
}
|
||
if len(n47.ChildActivity) != 0 {
|
||
t.Errorf("上行引用不應產生子項摘要，got %v", n47.ChildActivity)
|
||
}
|
||
// #39 本身 updated 1 小時前 → 不列入。
|
||
for _, it := range got {
|
||
if it.Number == 39 {
|
||
t.Errorf("39 未達門檻不應列入：%v", it)
|
||
}
|
||
}
|
||
}
|
||
|
||
// TestScanStalledPullReasons 驗證 PR 的 reason 分類。
|
||
func TestScanStalledPullReasons(t *testing.T) {
|
||
now := at(0)
|
||
h := true
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": {{Name: "teai", HasPullRequests: &h}}},
|
||
pulls: map[string][]PullRequest{
|
||
"alterminal/teai": {
|
||
{Number: 10, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-600)},
|
||
{Number: 11, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
|
||
{Number: 12, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
|
||
{Number: 13, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
|
||
// agents #51：作者最後留言含審核交棒（@審核者＋就緒語）→ reviewer-idle。
|
||
{Number: 14, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "chenyunda218"}}},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
"alterminal/teai/11": {{User: &User{UserName: "max"}, CreatedAt: iso(-300)}}, // author-idle
|
||
"alterminal/teai/12": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}}, // reviewer-idle
|
||
"alterminal/teai/13": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300)}}, // no-commenter（外部留言）
|
||
// fox#60 形態（agents #51）：作者留言 @chenyunda218＋「已就緒，可審閱」→ 審核交棒。
|
||
"alterminal/teai/14": {{User: &User{UserName: "max"}, CreatedAt: iso(-300), Body: "狀態回報：分支無需再變更，CI 已通過。@chenyunda218 PR 已就緒，可審閱。"}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
byNumber := map[int64]Item{}
|
||
for _, it := range got {
|
||
byNumber[it.Number] = it
|
||
}
|
||
for n, wantReason := range map[int64]string{10: "no-reviewer", 11: "author-idle", 12: "reviewer-idle", 13: "no-commenter", 14: "reviewer-idle"} {
|
||
item, ok := byNumber[n]
|
||
if !ok {
|
||
t.Fatalf("PR %d 應列入，got %v", n, got)
|
||
}
|
||
if item.Reason != wantReason {
|
||
t.Errorf("PR %d reason = %q, want %q", n, item.Reason, wantReason)
|
||
}
|
||
}
|
||
if len(got) != 5 {
|
||
t.Fatalf("應 5 筆，got %d", len(got))
|
||
}
|
||
if byNumber[10].Author != "max" {
|
||
t.Errorf("PR 10 author 應為 max，got %q", byNumber[10].Author)
|
||
}
|
||
if byNumber[14].LastCommentBy != "max" {
|
||
t.Errorf("PR 14 last_comment_by 應為 max（作者留言後交棒），got %q", byNumber[14].LastCommentBy)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledNoPullsFlag 停用 PR 的倉庫仍掃 issues，只跳過 PR。
|
||
func TestScanStalledNoPullsFlag(t *testing.T) {
|
||
now := at(0)
|
||
h := false
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": {{Name: "docs", HasPullRequests: &h}}},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/docs": {
|
||
1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/docs"}},
|
||
},
|
||
},
|
||
pulls: map[string][]PullRequest{
|
||
// 即使假資料有 PR，flag 關閉也不應掃。
|
||
"alterminal/docs": {{Number: 2, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-600)}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 1 || got[0].Number != 1 || got[0].Type != "issue" {
|
||
t.Fatalf("應只有 issue 1，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledSkipsPRsInIssues 確認 /issues 混入的 PR 會被過濾。
|
||
func TestScanStalledSkipsPRsInIssues(t *testing.T) {
|
||
now := at(0)
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/teai": {
|
||
1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/teai"}, PullRequest: &pullMarker{}},
|
||
},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 0 {
|
||
t.Fatalf("/issues 混入的 PR 應過濾，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestItemJSON 與 gitea.py 的 JSON 位元組相容（鍵序、HTML 不轉義、48.0、null）。
|
||
func TestItemJSON(t *testing.T) {
|
||
ts := at(-600)
|
||
activity := FormatMoment(ts)
|
||
item := Item{
|
||
Type: "issue", Repo: "alterminal/teai", Number: 7, Title: "R,D <v2> & 規劃", URL: "u",
|
||
Assignees: []string{"ceo"}, LastCommentBy: "max",
|
||
LastActivityAt: ts, StalledHours: 48, Reason: "assignee-idle",
|
||
ChildActivity: []Child{
|
||
{Repo: "alterminal/teai", Number: 3, Title: "父", State: "open", LastActivityAt: &activity},
|
||
{Repo: "alterminal/teai", Number: 4, Title: "無時刻", State: "open"},
|
||
},
|
||
}
|
||
// json.Marshal 會把 <、>、& 重新轉義，必須用停用 HTML 轉義的編碼器。
|
||
var buf bytes.Buffer
|
||
enc := json.NewEncoder(&buf)
|
||
enc.SetEscapeHTML(false)
|
||
if err := enc.Encode(item); err != nil {
|
||
t.Fatalf("Encode: %v", err)
|
||
}
|
||
got := strings.TrimSuffix(buf.String(), "\n")
|
||
want := `{"type":"issue","repo":"alterminal/teai","number":7,"title":"R,D <v2> & 規劃","url":"u","assignees":["ceo"],"last_comment_by":"max","last_activity_at":"2026-09-09T22:00:00+00:00","stalled_hours":48.0,"reason":"assignee-idle","child_activity":[{"repo":"alterminal/teai","number":3,"title":"父","state":"open","last_activity_at":"2026-09-09T22:00:00+00:00"},{"repo":"alterminal/teai","number":4,"title":"無時刻","state":"open","last_activity_at":null}]}`
|
||
if got != want {
|
||
t.Fatalf("JSON 位元組不相容:\n got %s\nwant %s", got, want)
|
||
}
|
||
}
|
||
|
||
// TestPullJSON：pull 的鍵序（author、reviewers）與非整數 stalled_hours。
|
||
func TestPullJSON(t *testing.T) {
|
||
item := Item{
|
||
Type: "pull", Repo: "alterminal/teai", Number: 12, Title: "t", URL: "u",
|
||
Author: "ceo", Reviewers: []string{"queena"},
|
||
LastActivityAt: at(-600), StalledHours: 10.44, Reason: "reviewer-idle",
|
||
}
|
||
b, err := json.Marshal(item)
|
||
if err != nil {
|
||
t.Fatalf("Marshal: %v", err)
|
||
}
|
||
got := string(b)
|
||
want := `{"type":"pull","repo":"alterminal/teai","number":12,"title":"t","url":"u","author":"ceo","reviewers":["queena"],"last_comment_by":"","last_activity_at":"2026-09-09T22:00:00+00:00","stalled_hours":10.4,"reason":"reviewer-idle"}`
|
||
if got != want {
|
||
t.Fatalf("JSON 位元組不相容:\n got %s\nwant %s", got, want)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledEmpty 無停滯項目 → 空輸出（CLI 層輸出 []）。
|
||
func TestScanStalledEmpty(t *testing.T) {
|
||
now := at(0)
|
||
src := &fakeSource{orgs: []string{"alterminal"}, repos: map[string][]Repo{"alterminal": repoWith("teai", true)}}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
if len(got) != 0 {
|
||
t.Fatalf("應空，got %v", got)
|
||
}
|
||
}
|
||
|
||
// TestScanStalledOrgError 組織層錯誤應回傳（不靜默）。
|
||
func TestScanStalledOrgError(t *testing.T) {
|
||
src := &errSource{}
|
||
if _, err := ScanStalled(src, "admin", 4.0, at(0)); err == nil {
|
||
t.Fatal("組織清單失敗應回傳錯誤")
|
||
}
|
||
}
|
||
|
||
type errSource struct{}
|
||
|
||
func (errSource) MyOrganizations() ([]string, error) { return nil, errors.New("boom") }
|
||
func (e errSource) OrganizationRepositories(string) ([]Repo, error) {
|
||
return nil, errors.New("boom")
|
||
}
|
||
func (e errSource) OpenIssues(string, string) ([]Issue, error) { return nil, errors.New("boom") }
|
||
func (e errSource) OpenPulls(string, string) ([]PullRequest, error) { return nil, errors.New("boom") }
|
||
func (e errSource) IssueComments(string, string, int64) ([]Comment, error) {
|
||
return nil, errors.New("boom")
|
||
}
|
||
func (e errSource) TryGetIssue(string, string, int64) (Issue, bool, error) {
|
||
return Issue{}, false, errors.New("boom")
|
||
}
|
||
func (e errSource) IssueTimeline(string, string, int64) ([]TimelineEvent, error) {
|
||
return nil, errors.New("boom")
|
||
}
|
||
|
||
// TestRound1 round1 十進位舍入到一位小數（與 Python round(x,1) 半偶數一致）。
|
||
func TestRound1(t *testing.T) {
|
||
cases := []struct {
|
||
in float64
|
||
want float64
|
||
}{
|
||
{10.44, 10.4}, {10.46, 10.5}, {10.0, 10.0},
|
||
// 半偶數（與 Python round(x,1) 對二進位真值的行為一致）：
|
||
// 10.45、5.25、5.15 的二進位真值都略低於表值 → 舍到偶數位。
|
||
{10.45, 10.4}, {0.05, 0.1}, {5.25, 5.2}, {5.15, 5.2},
|
||
}
|
||
for _, tc := range cases {
|
||
if got := round1(tc.in); got != tc.want {
|
||
t.Errorf("round1(%v) = %v, want %v", tc.in, got, tc.want)
|
||
}
|
||
}
|
||
}
|
||
|
||
// TestScanStalledDeliveryReport（agents #47）：assignee 最後留言為交付報告
|
||
// （結構訊號＋交棒訊號）→ waiting-outside，不是 assignee-idle；
|
||
// 同型認領留言（無交棒）維持 assignee-idle——修正不製造新死角。
|
||
func TestScanStalledDeliveryReport(t *testing.T) {
|
||
now := at(0)
|
||
defBody := "## 完成定義\n- 逐項回報查核結果至此 issue；\n- 全數通過 → 回報 #39 並由 #39 assignee 關閉"
|
||
src := &fakeSource{
|
||
orgs: []string{"alterminal"},
|
||
repos: map[string][]Repo{"alterminal": repoWith("bear", true)},
|
||
issues: map[string]map[int64]Issue{
|
||
"alterminal/bear": {
|
||
5: {Number: 5, Title: "驗收", State: "open", Body: defBody, CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "queena"}}, Repository: &Repository{FullName: "alterminal/bear"}},
|
||
6: {Number: 6, Title: "認領中", State: "open", Body: defBody, CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "dan"}}, Repository: &Repository{FullName: "alterminal/bear"}},
|
||
},
|
||
},
|
||
comments: map[string][]Comment{
|
||
"alterminal/bear/5": {{User: &User{UserName: "queena"}, CreatedAt: iso(-300), Body: "## 查核結果\n結論：四項全數通過。回報 #39：可由 @ceo 關閉。"}},
|
||
"alterminal/bear/6": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300), Body: "認領。完成後逐項回報結果至此。"}},
|
||
},
|
||
}
|
||
got, err := ScanStalled(src, "admin", 4.0, now)
|
||
if err != nil {
|
||
t.Fatalf("ScanStalled: %v", err)
|
||
}
|
||
byNumber := map[int64]Item{}
|
||
for _, it := range got {
|
||
byNumber[it.Number] = it
|
||
}
|
||
if it, ok := byNumber[5]; !ok || it.Reason != "waiting-outside" {
|
||
t.Errorf("issue 5（交付報告）reason 應為 waiting-outside，got %+v", it)
|
||
}
|
||
if it, ok := byNumber[6]; !ok || it.Reason != "assignee-idle" {
|
||
t.Errorf("issue 6（認領留言）reason 應為 assignee-idle，got %+v", it)
|
||
}
|
||
}
|