From 5583a00bb525749ff379790d9a71e08f968940f9 Mon Sep 17 00:00:00 2001 From: chenyunda218 Date: Thu, 10 Sep 2026 08:39:35 +0800 Subject: [PATCH 1/2] =?UTF-8?q?internal/workflow=20+=20cli=EF=BC=9Agitea.p?= =?UTF-8?q?y=20=E5=B7=A5=E4=BD=9C=E6=B5=81=E5=91=BD=E4=BB=A4=20Go=20?= =?UTF-8?q?=E5=8C=96=EF=BC=88#6=EF=BC=89?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - internal/workflow：Client 介面＋判定語義（最後留言、作者/審核者跟進、 assignee 交集、最久未更新優先），含假 client 單元測試 - internal/workflow/giteaapi.go：以 internal/gitea（#5）實作 Client - internal/cli：註冊 whoami/orgs/members/mine/pulls/next；全域選項允許 出現在命令之後；結束碼 0/2/3 - 與 gitea.py 交叉驗證：next/mine/pulls/members(--has-work) 拾取一致 - 依 #5 分支 feature/issue5-gitea-client 為基底 --- README.md | 2 +- internal/cli/cli.go | 15 +- internal/cli/workflow_commands.go | 242 ++++++++++++++++++++ internal/workflow/giteaapi.go | 124 +++++++++++ internal/workflow/judge.go | 137 ++++++++++++ internal/workflow/judge_test.go | 145 ++++++++++++ internal/workflow/next.go | 115 ++++++++++ internal/workflow/scan.go | 351 ++++++++++++++++++++++++++++++ internal/workflow/scan_test.go | 261 ++++++++++++++++++++++ internal/workflow/types.go | 218 +++++++++++++++++++ 10 files changed, 1604 insertions(+), 6 deletions(-) create mode 100644 internal/cli/workflow_commands.go create mode 100644 internal/workflow/giteaapi.go create mode 100644 internal/workflow/judge.go create mode 100644 internal/workflow/judge_test.go create mode 100644 internal/workflow/next.go create mode 100644 internal/workflow/scan.go create mode 100644 internal/workflow/scan_test.go create mode 100644 internal/workflow/types.go diff --git a/README.md b/README.md index 2a9a264..ed1b242 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ teai 是 Gitea 的命令列（CLI）輔助工具，補足官方 `tea` CLI 缺少 - **語言：** Go（與 Gitea 本體一致），僅用標準庫，離線可建置 - **目標站點：** `https://gitea.alterminal.com` -- **狀態：** 專案初始化中，功能尚未開始開發；本文的指令集為設計藍圖 +- **狀態：** 基礎建設（#5：internal/gitea）與工作流命令（#6：whoami/orgs/members/mine/pulls/next）已實作；stalled/xrefs（#7）與日常操作命令（#8）進行中 ## 安裝與建置 diff --git a/internal/cli/cli.go b/internal/cli/cli.go index 7b5040a..a4f756f 100644 --- a/internal/cli/cli.go +++ b/internal/cli/cli.go @@ -12,7 +12,6 @@ package cli import ( "errors" - "flag" "fmt" "io" "sort" @@ -213,14 +212,20 @@ func parseGlobals(g *Globals, args []string) ([]string, error) { } // dispatch 執行已註冊的子命令，把錯誤轉成結束碼並輸出。 +// 旗標剖析交由各命令自行處理（不同命令有不同旗標，如 pulls --mine）； +// 全域選項允許出現在命令之後（README 範例：teai next --output table）， +// 先從 args 剝離併入 Globals 再分派。 func dispatch(env *Env, name string, args []string) int { cmd := commands[name] - fs := flag.NewFlagSet("teai "+name, flag.ContinueOnError) - fs.SetOutput(env.Err) - if err := fs.Parse(args); err != nil { + g := env.Globals + rest, err := parseGlobals(&g, args) + if err != nil { + fmt.Fprintf(env.Err, "teai: %v\n\n", err) + printUsage(env.Err) return int(ExitUsage) } - if err := cmd.run(env, fs.Args()); err != nil { + env.Globals = g + if err := cmd.run(env, rest); err != nil { fmt.Fprintf(env.Err, "teai %s: %v\n", name, err) return int(exitCodeFor(err)) } diff --git a/internal/cli/workflow_commands.go b/internal/cli/workflow_commands.go new file mode 100644 index 0000000..8a69ccb --- /dev/null +++ b/internal/cli/workflow_commands.go @@ -0,0 +1,242 @@ +// workflow_commands.go — gitea.py 工作流命令的 CLI 接線（#6）： +// whoami、orgs、members [--has-work]、mine、pulls [--mine|--reviewer] [--repo]、next。 +// +// 輸出走 internal/gitea 的 Printer（--output json|table）；錯誤經 cli.exitCodeFor +// 映射結束碼（用法 2／API 3）。token 解析選序見 internal/gitea/auth.go。 +package cli + +import ( + "errors" + "flag" + "fmt" + "strings" + + "gitea.alterminal.com/alterminal/teai/internal/gitea" + "gitea.alterminal.com/alterminal/teai/internal/workflow" +) + +func init() { + register := func(c *command) { + commands[c.name] = c + } + register(&command{name: "whoami", usage: "目前帳號", run: runWhoami}) + register(&command{name: "orgs", usage: "我所屬的組織", run: runOrgs}) + register(&command{name: "members", usage: "Agents 團隊成員；--has-work 只列有未完成工作者", run: runMembers}) + register(&command{name: "mine", usage: "分派給我、待跟進的 issues", run: runMine}) + register(&command{name: "pulls", usage: "跨倉庫 PR 跟進清單（--mine／--reviewer／--repo）", run: runPulls}) + register(&command{name: "next", usage: "下一件該做的事", run: runNext}) +} + +// errNoRepoFlag 是 --repo 值格式錯誤。 +var errNoRepoFlag = errors.New("--repo 需為 owner/repo 形式") + +// newWorkflowClient 依全域選項建立 workflow 所需的 API client。 +func newWorkflowClient(env *Env) (*workflow.Scanner, error) { + token, _, err := gitea.ResolveToken(gitea.AuthOptions{ + FlagToken: env.Globals.Token, + SiteURL: env.Globals.URL, + ConfigPath: env.Globals.ConfigPath, + }) + if err != nil { + return nil, err + } + client, err := gitea.New(env.Globals.URL, token, env.Globals.Timeout) + if err != nil { + return nil, err + } + return &workflow.Scanner{Client: &workflow.APIClient{Client: client}}, nil +} + +// printer 依全域選項建立輸出器。 +func printer(env *Env) gitea.Printer { + return gitea.Printer{Format: env.Globals.Output, Out: env.Out} +} + +// runWhoami：teai whoami。 +func runWhoami(env *Env, args []string) error { + if len(args) != 0 { + return &ErrUsage{Msg: "whoami 不接受參數"} + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + name, err := s.Whoami() + if err != nil { + return err + } + return printer(env).PrintOne( + []gitea.Field{{Name: "username"}}, + gitea.Values{name}, + ) +} + +// runOrgs：teai orgs。 +func runOrgs(env *Env, args []string) error { + if len(args) != 0 { + return &ErrUsage{Msg: "orgs 不接受參數"} + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + orgs, err := s.Orgs() + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(orgs)) + for _, o := range orgs { + rows = append(rows, gitea.Values{o}) + } + return printer(env).PrintList( + []gitea.Field{{Name: "username"}}, + rows, + ) +} + +// runMembers：teai members [--has-work]。輸出每行一個帳號（同 gitea.py）。 +func runMembers(env *Env, args []string) error { + fs := flag.NewFlagSet("teai members", flag.ContinueOnError) + fs.SetOutput(env.Err) + hasWork := fs.Bool("has-work", false, "只列出有未完成工作的成員") + if err := fs.Parse(args); err != nil { + return &ErrUsage{Msg: err.Error()} + } + if fs.NArg() != 0 { + return &ErrUsage{Msg: "members 不接受位置參數"} + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + names, err := s.Members(*hasWork) + if err != nil { + return err + } + // gitea.py members 每行輸出一個帳號（非 JSON）；保持一致以便交叉驗證。 + for _, name := range names { + fmt.Fprintln(env.Out, name) + } + return nil +} + +// runMine：teai mine。 +func runMine(env *Env, args []string) error { + if len(args) != 0 { + return &ErrUsage{Msg: "mine 不接受參數"} + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + issues, err := s.Mine() + if err != nil { + return err + } + return printer(env).PrintList( + []gitea.Field{ + {Name: "repo"}, {Name: "number"}, {Name: "title"}, {Name: "url"}, + }, + issueRows(issues), + ) +} + +// runPulls：teai pulls [--mine|--reviewer] [--repo owner/repo]。 +func runPulls(env *Env, args []string) error { + fs := flag.NewFlagSet("teai pulls", flag.ContinueOnError) + fs.SetOutput(env.Err) + mine := fs.Bool("mine", false, "限定作者是目前帳號") + reviewer := fs.Bool("reviewer", false, "限定自己是 requested reviewer") + repo := fs.String("repo", "", "限定單一倉庫（owner/repo）") + if err := fs.Parse(args); err != nil { + return &ErrUsage{Msg: err.Error()} + } + if fs.NArg() != 0 { + return &ErrUsage{Msg: "pulls 不接受位置參數"} + } + if *mine && *reviewer { + return &ErrUsage{Msg: "--mine 與 --reviewer 不能併用"} + } + var owner, name string + if *repo != "" { + parts := strings.SplitN(*repo, "/", 2) + if len(parts) != 2 || parts[0] == "" || parts[1] == "" { + return &ErrUsage{Msg: errNoRepoFlag.Error()} + } + owner, name = parts[0], parts[1] + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + items, err := s.Pulls(*mine, *reviewer) + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(items)) + for _, item := range items { + if *repo != "" && (item.Owner != owner || item.Repo != name) { + continue + } + rows = append(rows, gitea.Values{ + item.Owner + "/" + item.Repo, + item.Pull.Number, + item.Pull.Title, + item.Pull.WebURL(), + }) + } + return printer(env).PrintList( + []gitea.Field{ + {Name: "repo"}, {Name: "number"}, {Name: "title"}, {Name: "url"}, + }, + rows, + ) +} + +// runNext：teai next。無工作輸出 null（exit 0）。 +func runNext(env *Env, args []string) error { + if len(args) != 0 { + return &ErrUsage{Msg: "next 不接受參數"} + } + s, err := newWorkflowClient(env) + if err != nil { + return err + } + work, err := s.Next() + if err != nil { + return err + } + p := printer(env) + if work == nil { + return p.PrintNull() + } + // gitea.py 的 _work_dict：role 僅 pull 帶（issue 不輸出 role 欄位）。 + fields := []gitea.Field{ + {Name: "type"}, {Name: "role"}, {Name: "repo"}, + {Name: "number"}, {Name: "title"}, {Name: "url"}, + } + row := gitea.Values{work.Type, work.Role, work.Repo, work.Number, work.Title, work.URL} + if work.Role == "" { + fields = []gitea.Field{ + {Name: "type"}, {Name: "repo"}, + {Name: "number"}, {Name: "title"}, {Name: "url"}, + } + row = gitea.Values{work.Type, work.Repo, work.Number, work.Title, work.URL} + } + return p.PrintOne(fields, row) +} + +// issueRows 把 issues 轉成輸出列（repo 欄位由掃描脈絡補齊）。 +func issueRows(issues []workflow.Issue) []gitea.Values { + rows := make([]gitea.Values, 0, len(issues)) + for i := range issues { + issue := &issues[i] + rows = append(rows, gitea.Values{ + issue.FullName(), + issue.Num(), + issue.Title, + issue.WebURL(), + }) + } + return rows +} diff --git a/internal/workflow/giteaapi.go b/internal/workflow/giteaapi.go new file mode 100644 index 0000000..b9beab7 --- /dev/null +++ b/internal/workflow/giteaapi.go @@ -0,0 +1,124 @@ +// giteaapi.go — 以 internal/gitea 的 HTTP 用戶端實作 workflow.Client。 +// +// 端點與查詢參數對照 gitea.py：清單一律帶 limit 分頁（ListAll 固定 50）； +// issues 端點帶 type=issues（排除 PR）與 state=open；pulls 帶 state=open。 +package workflow + +import ( + "context" + "errors" + "net/url" + "strconv" + + "gitea.alterminal.com/alterminal/teai/internal/gitea" +) + +// errNoUsername 表示 /user 回應中找不到帳號名（伺服端回應異常）。 +var errNoUsername = errors.New("gitea: GET /user: response has no username") + +// APIClient 是 Client 介面的 HTTP 實作，包裝 internal/gitea.Client。 +type APIClient struct { + Client *gitea.Client +} + +// 確認 APIClient 實作 Client 介面（編譯期檢查）。 +var _ Client = (*APIClient)(nil) + +func (a *APIClient) CurrentUser() (string, error) { + var u User + if err := a.Client.GetJSON(context.Background(), "/user", &u); err != nil { + return "", err + } + name := u.Name() + if name == "" { + return "", errNoUsername + } + return name, nil +} + +func (a *APIClient) ListOrgs() ([]string, error) { + var orgs []Org + if err := a.Client.ListAll(context.Background(), "/user/orgs", gitea.ListOptions{}, &orgs); err != nil { + return nil, err + } + names := make([]string, 0, len(orgs)) + for _, o := range orgs { + if n := o.Account(); n != "" { + names = append(names, n) + } + } + return names, nil +} + +func (a *APIClient) ListTeams(org string) ([]Team, error) { + var teams []Team + path := "/orgs/" + url.PathEscape(org) + "/teams" + if err := a.Client.ListAll(context.Background(), path, gitea.ListOptions{}, &teams); err != nil { + return nil, err + } + return teams, nil +} + +func (a *APIClient) ListTeamMembers(teamID int64) ([]string, error) { + var users []User + path := "/teams/" + strconv.FormatInt(teamID, 10) + "/members" + if err := a.Client.ListAll(context.Background(), path, gitea.ListOptions{}, &users); err != nil { + return nil, err + } + names := make([]string, 0, len(users)) + for i := range users { + if n := users[i].Name(); n != "" { + names = append(names, n) + } + } + return names, nil +} + +func (a *APIClient) ListOrgRepos(org string) ([]Repo, error) { + var repos []Repo + path := "/orgs/" + url.PathEscape(org) + "/repos" + if err := a.Client.ListAll(context.Background(), path, gitea.ListOptions{}, &repos); err != nil { + return nil, err + } + return repos, nil +} + +func (a *APIClient) ListIssues(owner, repo string) ([]Issue, error) { + var issues []Issue + path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/issues" + opts := gitea.ListOptions{Extra: url.Values{ + "type": {"issues"}, + "state": {"open"}, + }} + if err := a.Client.ListAll(context.Background(), path, opts, &issues); err != nil { + return nil, err + } + // /issues 也會回傳 PR（帶 pull_request 欄位）；一律排除。 + out := make([]Issue, 0, len(issues)) + for i := range issues { + if issues[i].PullRequest == nil { + out = append(out, issues[i]) + } + } + return out, nil +} + +func (a *APIClient) ListPulls(owner, repo string) ([]PullRequest, error) { + var pulls []PullRequest + path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/pulls" + opts := gitea.ListOptions{Extra: url.Values{"state": {"open"}}} + if err := a.Client.ListAll(context.Background(), path, opts, &pulls); err != nil { + return nil, err + } + return pulls, nil +} + +func (a *APIClient) ListComments(owner, repo string, number int64) ([]Comment, error) { + var comments []Comment + path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + + "/issues/" + strconv.FormatInt(number, 10) + "/comments" + if err := a.Client.ListAll(context.Background(), path, gitea.ListOptions{}, &comments); err != nil { + return nil, err + } + return comments, nil +} diff --git a/internal/workflow/judge.go b/internal/workflow/judge.go new file mode 100644 index 0000000..4614216 --- /dev/null +++ b/internal/workflow/judge.go @@ -0,0 +1,137 @@ +package workflow + +import "sort" + +// sortComments 依 created_at 字典序穩定排序（ISO8601 字串字典序與時間序一致）， +// 對應 gitea.py 各處的 comments.sort(key=created_at)。 +func sortComments(comments []Comment) []Comment { + out := append([]Comment(nil), comments...) + sort.SliceStable(out, func(a, b int) bool { return out[a].CreatedAt < out[b].CreatedAt }) + return out +} + +// LastComment 回傳依 created_at 排序後的最後一則留言；沒有留言回 nil。 +func LastComment(comments []Comment) *Comment { + ordered := sortComments(comments) + if len(ordered) == 0 { + return nil + } + return &ordered[len(ordered)-1] +} + +// lastCommentAuthor 回傳最後一則留言的作者；無留言或作者未知回空字串。 +func lastCommentAuthor(comments []Comment) string { + if last := LastComment(comments); last != nil { + return last.Author() + } + return "" +} + +func containsString(items []string, target string) bool { + for _, item := range items { + if item == target { + return true + } + } + return false +} + +// NeedsAuthorFollowup 判定 PR 是否需要發起者跟進：有留言、且最後一則留言 +// 不是 PR 作者（gitea.py 的 _pr_needs_author_followup）。 +// 無留言或作者未知 → false（尚無留言的 PR 不列入跟進清單）。 +func NeedsAuthorFollowup(pr *PullRequest, comments []Comment) bool { + author := pr.Author() + if author == "" { + return false + } + last := lastCommentAuthor(comments) + return last != "" && last != author +} + +// NeedsReviewerFollowup 判定使用者是否需要審核此 PR：被指定為審核者、 +// 不是作者、最後一則留言不是自己（含尚無留言） +// （gitea.py 的 _pr_needs_reviewer_followup）。 +func NeedsReviewerFollowup(pr *PullRequest, comments []Comment, username string) bool { + if username == "" { + return false + } + if pr.Author() == username { + return false + } + if !containsString(ReviewerNames(pr), username) { + return false + } + return lastCommentAuthor(comments) != username +} + +// ReviewerNames 回傳 PR 的 requested reviewers（去重、排序）。 +func ReviewerNames(pr *PullRequest) []string { + seen := map[string]bool{} + names := make([]string, 0, len(pr.RequestedReviewers)) + for i := range pr.RequestedReviewers { + name := pr.RequestedReviewers[i].Name() + if name != "" && !seen[name] { + seen[name] = true + names = append(names, name) + } + } + sort.Strings(names) + return names +} + +// AssigneeNames 回傳 issue 的全部 assignees（assignee 欄位＋assignees 陣列， +// 去重、排序），對應 gitea.py 的 _assignee_usernames。 +func AssigneeNames(issue *Issue) []string { + seen := map[string]bool{} + add := func(u *User) { + if u == nil { + return + } + if name := u.Name(); name != "" && !seen[name] { + seen[name] = true + } + } + add(issue.Assignee) + for i := range issue.Assignees { + add(&issue.Assignees[i]) + } + names := make([]string, 0, len(seen)) + for name := range seen { + names = append(names, name) + } + sort.Strings(names) + return names +} + +// AssigneeOverlaps 判定 issue 是否分派給 members 中至少一人 +// （members 為空 → false，同 gitea.py filter_issues_by_assignee 的空成員集行為）。 +func AssigneeOverlaps(issue *Issue, members []string) bool { + if len(members) == 0 { + return false + } + assignees := AssigneeNames(issue) + for _, member := range members { + if member != "" && containsString(assignees, member) { + return true + } + } + return false +} + +// LastCommentNotByAssignee 判定 issue 的最後一則留言是否不是任何 assignee +// 留的（無留言 → true，視為需要處理）。 +// 注意：判定對象是該 issue 的**全部** assignees，不只是 members 中的成員 +// （gitea.py _last_comment_is_from_assignee 的語義）。 +func LastCommentNotByAssignee(issue *Issue, comments []Comment) bool { + last := lastCommentAuthor(comments) + if last == "" { + return true + } + return !containsString(AssigneeNames(issue), last) +} + +// IssueNeedsWork 組合判定：分派給 members 中至少一人，且最後一則留言 +// 不是 assignee（gitea.py filter_issues_by_assignee 保留的項目）。 +func IssueNeedsWork(issue *Issue, comments []Comment, members []string) bool { + return AssigneeOverlaps(issue, members) && LastCommentNotByAssignee(issue, comments) +} diff --git a/internal/workflow/judge_test.go b/internal/workflow/judge_test.go new file mode 100644 index 0000000..dfa82cb --- /dev/null +++ b/internal/workflow/judge_test.go @@ -0,0 +1,145 @@ +// judge_test.go — 驗證工作流判定語義（對照 gitea.py）： +// 最後留言判定、作者／審核者跟進條件、assignee 交集與排序。 +package workflow + +import ( + "reflect" + "testing" +) + +// mkUser 構造 User。 +func mkUser(name string) *User { return &User{UserName: name} } + +func TestUserNameFallback(t *testing.T) { + if got := (&User{UserName: "a", Login: "b"}).Name(); got != "a" { + t.Errorf("username 優先，得到 %q", got) + } + if got := (&User{Login: "b"}).Name(); got != "b" { + t.Errorf("login 回退，得到 %q", got) + } + if got := mkUser("").Name(); got != "" { + t.Errorf("空帳號，得到 %q", got) + } +} + +func TestLastComment(t *testing.T) { + comments := []Comment{ + {CreatedAt: "2026-09-09T01:00:00Z", User: mkUser("alex")}, + {CreatedAt: "2026-09-09T03:00:00Z", User: mkUser("max")}, + {CreatedAt: "2026-09-09T02:00:00Z", User: mkUser("ceo")}, + } + last := LastComment(comments) + if last == nil || last.Author() != "max" { + t.Errorf("應依 created_at 排序取最後（03:00 max），得到 %+v", last) + } + if LastComment(nil) != nil { + t.Errorf("無留言應回 nil") + } +} + +func TestNeedsAuthorFollowup(t *testing.T) { + pr := &PullRequest{User: mkUser("alex")} + cases := []struct { + name string + comments []Comment + want bool + }{ + {"無留言", nil, false}, + {"最後留言是作者", []Comment{{CreatedAt: "a", User: mkUser("alex")}}, false}, + {"最後留言是他人", []Comment{ + {CreatedAt: "a", User: mkUser("alex")}, + {CreatedAt: "b", User: mkUser("ceo")}, + }, true}, + {"留言者未知", []Comment{{CreatedAt: "a"}}, false}, + } + for _, c := range cases { + if got := NeedsAuthorFollowup(pr, c.comments); got != c.want { + t.Errorf("%s：得到 %v，want %v", c.name, got, c.want) + } + } +} + +func TestNeedsReviewerFollowup(t *testing.T) { + pr := &PullRequest{ + User: mkUser("max"), + RequestedReviewers: []User{*mkUser("alex"), *mkUser("queena")}, + } + comments := []Comment{{CreatedAt: "a", User: mkUser("max")}} + if !NeedsReviewerFollowup(pr, comments, "alex") { + t.Errorf("審核者且最後留言非自己 → 應需跟進") + } + if NeedsReviewerFollowup(pr, comments, "max") { + t.Errorf("作者本人 → 不應列入審核清單") + } + if NeedsReviewerFollowup(pr, []Comment{{CreatedAt: "a", User: mkUser("alex")}}, "alex") { + t.Errorf("最後留言是自己 → 不應需跟進") + } + if NeedsReviewerFollowup(pr, comments, "ceo") { + t.Errorf("非審核者 → 不應需跟進") + } + // 尚無留言的 PR：審核者仍應被列入（含尚無留言）。 + if !NeedsReviewerFollowup(pr, nil, "queena") { + t.Errorf("尚無留言 → 審核者應需跟進") + } +} + +func TestAssigneeNames(t *testing.T) { + issue := &Issue{ + Assignee: mkUser("alex"), + Assignees: []User{*mkUser("alex"), *mkUser("max")}, + } + if got := AssigneeNames(issue); !reflect.DeepEqual(got, []string{"alex", "max"}) { + t.Errorf("assignee 應去重排序，得到 %v", got) + } +} + +func TestAssigneeOverlapsEmptyMembers(t *testing.T) { + issue := &Issue{Assignee: mkUser("alex")} + if AssigneeOverlaps(issue, nil) { + t.Errorf("成員集為空 → 不應列入（同 gitea.py filter_issues_by_assignee）") + } +} + +func TestLastCommentNotByAssignee(t *testing.T) { + issue := &Issue{Assignee: mkUser("alex")} + if !LastCommentNotByAssignee(issue, nil) { + t.Errorf("無留言 → 應視為需要處理") + } + if LastCommentNotByAssignee(issue, []Comment{{CreatedAt: "a", User: mkUser("alex")}}) { + t.Errorf("最後留言來自 assignee → 不應列入") + } + if !LastCommentNotByAssignee(issue, []Comment{{CreatedAt: "a", User: mkUser("ceo")}}) { + t.Errorf("最後留言來自他人 → 應列入") + } +} + +func TestUpdatedKeyFallbackChain(t *testing.T) { + i := &Issue{UpdatedAt: "", Updated: "u", CreatedAt: "c"} + if got := i.updatedKey(); got != "u" { + t.Errorf("updated 回退鏈，得到 %q", got) + } + if got := (&Issue{}).updatedKey(); got != "9999" { + t.Errorf("全缺 → 9999，得到 %q", got) + } +} + +func TestFullNameFallbacks(t *testing.T) { + pr := &PullRequest{ + HTMLURL: "https://gitea.alterminal.com/alterminal/teai/pulls/2", + Base: &PRRef{Repo: &Repository{FullName: "alterminal/teai"}}, + } + if got := pr.FullName(); got != "alterminal/teai" { + t.Errorf("base.repo 優先，得到 %q", got) + } + pr2 := &PullRequest{HTMLURL: "https://gitea.alterminal.com/alterminal/teai/pulls/2"} + if got := pr2.FullName(); got != "alterminal/teai" { + t.Errorf("html_url 回退，得到 %q", got) + } + i := &Issue{Repository: &Repository{FullName: "alterminal/agents"}} + if got := i.FullName(); got != "alterminal/agents" { + t.Errorf("repository 欄位，得到 %q", got) + } + if got := (&Issue{}).FullName(); got != "" { + t.Errorf("全缺 → 空，得到 %q", got) + } +} diff --git a/internal/workflow/next.go b/internal/workflow/next.go new file mode 100644 index 0000000..1d80f71 --- /dev/null +++ b/internal/workflow/next.go @@ -0,0 +1,115 @@ +package workflow + +import ( + "errors" + "sort" +) + +// errIncompatibleFlags 對應 gitea.py 的「--mine 與 --reviewer 不能併用」。 +var errIncompatibleFlags = errors.New("--mine 與 --reviewer 不能併用") + +// Work 是 next 命令的輸出物件：Type 為 "pull" 或 "issue"；Role 僅 pull 帶 +// （"author" 或 "reviewer"），對應 gitea.py 的 _work_dict。 +type Work struct { + Type string `json:"type"` + Role string `json:"role,omitempty"` + Repo string `json:"repo"` + Number int64 `json:"number"` + Title string `json:"title"` + URL string `json:"url"` +} + +// issueNumber 回傳 issue 編號：number 缺漏時回退 index（gitea.py 語義）。 +func (i *Issue) issueNumber() int64 { + if i.Number != 0 { + return i.Number + } + return i.Index +} + +// Num 是 issueNumber 的公開介面（CLI 輸出用）。 +func (i *Issue) Num() int64 { return i.issueNumber() } + +// Next 回傳下一件未完成工作：先自己發起的待跟進 PR（role=author），再待審核 +// 的 PR（role=reviewer，含尚無留言），再分派給自己的 open issue。各層皆以 +// 「最久未更新優先」排序後取第一件（gitea.py 的 find_next_work）。 +// 沒有任何工作時回傳 nil。 +func (s *Scanner) Next() (*Work, error) { + username, err := s.Whoami() + if err != nil { + return nil, err + } + _ = username + + // 第一層：自己發起、最後一則留言不是自己的 open PR。 + minePulls, err := s.Pulls(true, false) + if err != nil { + return nil, err + } + if len(minePulls) > 0 { + sorted := sortPullItemsByUpdated(minePulls) + return workFromPull(sorted[0], "author"), nil + } + + // 第二層：自己是審核者、最後一則留言不是自己的 open PR。 + reviewerPulls, err := s.Pulls(false, true) + if err != nil { + return nil, err + } + if len(reviewerPulls) > 0 { + sorted := sortPullItemsByUpdated(reviewerPulls) + return workFromPull(sorted[0], "reviewer"), nil + } + + // 第三層：分派給自己、最後一則留言不是 assignee 的 open issue。 + issues, err := s.Mine() + if err != nil { + return nil, err + } + if len(issues) > 0 { + sorted := sortIssuesByUpdated(issues) + return workFromIssue(&sorted[0]), nil + } + return nil, nil +} + +// sortPullItemsByUpdated 依 updatedKey 升冪（最久未更新在前）穩定排序。 +func sortPullItemsByUpdated(items []PullItem) []PullItem { + out := append([]PullItem(nil), items...) + sort.SliceStable(out, func(a, b int) bool { + return out[a].Pull.updatedKey() < out[b].Pull.updatedKey() + }) + return out +} + +// sortIssuesByUpdated 依 updatedKey 升冪（最久未更新在前）穩定排序。 +func sortIssuesByUpdated(items []Issue) []Issue { + out := append([]Issue(nil), items...) + sort.SliceStable(out, func(a, b int) bool { + return out[a].updatedKey() < out[b].updatedKey() + }) + return out +} + +// workFromPull 由 PR 組出 Work 物件。 +func workFromPull(item PullItem, role string) *Work { + return &Work{ + Type: "pull", + Role: role, + Repo: item.Owner + "/" + item.Repo, + Number: item.Pull.Number, + Title: item.Pull.Title, + URL: item.Pull.WebURL(), + } +} + +// workFromIssue 由 issue 組出 Work 物件。 +func workFromIssue(issue *Issue) *Work { + return &Work{ + Type: "issue", + Repo: issue.FullName(), + Number: issue.issueNumber(), + Title: issue.Title, + URL: issue.WebURL(), + } +} diff --git a/internal/workflow/scan.go b/internal/workflow/scan.go new file mode 100644 index 0000000..5934c0e --- /dev/null +++ b/internal/workflow/scan.go @@ -0,0 +1,351 @@ +// Package workflow 實作 AGENTS.md 工作流判定：跟進、審核、next 拾取與排序。 +// +// 行為基準是 alterminal/agents 的 scripts/lib/gitea.py；判定規則以 AGENTS.md +// 為唯一來源，本套件只實作、不改義。API 存取以 Client 介面抽象，HTTP 實作 +// 由 internal/gitea（#5 基礎建設）提供；測試以假 client 注入。 +package workflow + +import ( + "sort" +) + +// AgentsTeamName 是工作流團隊的名稱（AGENTS.md：調度成員由 Agents 團隊決定）。 +const AgentsTeamName = "Agents" + +// Client 抽象 teai 需要的 Gitea API 讀取操作（僅唯讀）。 +// #5 的 internal/gitea HTTP 用戶端實作此介面；workflow 不依賴 HTTP 細節。 +type Client interface { + // CurrentUser 回傳目前帳號名（GET /user）。 + CurrentUser() (string, error) + // ListOrgs 回傳帳號所屬組織名（GET /user/orgs，分頁）。 + ListOrgs() ([]string, error) + // ListTeams 回傳組織的團隊清單（GET /orgs/{org}/teams，分頁）。 + ListTeams(org string) ([]Team, error) + // ListTeamMembers 回傳團隊成員帳號（GET /teams/{id}/members，分頁）。 + ListTeamMembers(teamID int64) ([]string, error) + // ListOrgRepos 回傳組織的倉庫物件（GET /orgs/{org}/repos，分頁）。 + ListOrgRepos(org string) ([]Repo, error) + // ListIssues 回傳倉庫的 open issues（GET /repos/{owner}/{repo}/issues?state=open&type=issues， + // 分頁；已排除帶 pull_request 標記的 PR）。assignee／留言過濾由 workflow 層負責。 + ListIssues(owner, repo string) ([]Issue, error) + // ListPulls 回傳倉庫的 open PR（GET /repos/{owner}/{repo}/pulls?state=open，分頁）。 + ListPulls(owner, repo string) ([]PullRequest, error) + // ListComments 回傳 issue／PR 的留言（GET /repos/{owner}/{repo}/issues/{n}/comments，分頁）。 + ListComments(owner, repo string, number int64) ([]Comment, error) +} + +// RepoPulls 是單一倉庫的 open PR 清單（掃描的中間產物）。 +type RepoPulls struct { + Owner string + Repo string + Pulls []PullRequest +} + +// PullItem 是跟進清單中的 PR，附掃描時的所屬倉庫（owner/repo）， +// 供輸出時補齊 gitea.py 工作物件的 repo 欄位。 +type PullItem struct { + Owner string + Repo string + Pull PullRequest +} + +// Scanner 在 Client 之上組合出各命令的資料（whoami/orgs/members/mine/pulls/next）。 +type Scanner struct { + Client Client +} + +// Whoami 回傳目前帳號。 +func (s *Scanner) Whoami() (string, error) { + return s.Client.CurrentUser() +} + +// Orgs 回傳目前帳號所屬的組織（去重、排序）。 +func (s *Scanner) Orgs() ([]string, error) { + names, err := s.Client.ListOrgs() + if err != nil { + return nil, err + } + seen := map[string]bool{} + out := []string{} + for _, n := range names { + if n != "" && !seen[n] { + seen[n] = true + out = append(out, n) + } + } + sort.Strings(out) + return out, nil +} + +// agentsTeamID 找出組織內名為 Agents 的團隊 ID；沒有回 (0,false)。 +func (s *Scanner) agentsTeamID(org string) (int64, bool, error) { + teams, err := s.Client.ListTeams(org) + if err != nil { + return 0, false, err + } + for _, team := range teams { + if team.Name == AgentsTeamName { + return team.ID, true, nil + } + } + return 0, false, nil +} + +// Members 回傳跨組織 Agents 團隊成員（去重、排序）。 +// hasWork 為 true 時只保留有未完成工作者（判定同 Next 的拾取規則）。 +func (s *Scanner) Members(hasWork bool) ([]string, error) { + orgs, err := s.Orgs() + if err != nil { + return nil, err + } + seen := map[string]bool{} + names := []string{} + for _, org := range orgs { + teamID, ok, err := s.agentsTeamID(org) + if err != nil { + return nil, err + } + if !ok { + continue + } + members, err := s.Client.ListTeamMembers(teamID) + if err != nil { + return nil, err + } + for _, m := range members { + if m != "" && !seen[m] { + seen[m] = true + names = append(names, m) + } + } + } + sort.Strings(names) + if !hasWork { + return names, nil + } + busy, err := s.usernamesWithUnfinishedWork(names) + if err != nil { + return nil, err + } + out := make([]string, 0, len(names)) + for _, name := range names { + if busy[name] { + out = append(out, name) + } + } + return out, nil +} + +// iterOrgRepos 產出 (org, repoName)；空倉庫跳過（沒有內容可掃）。 +func (s *Scanner) iterOrgRepos() ([][2]string, error) { + orgs, err := s.Orgs() + if err != nil { + return nil, err + } + out := [][2]string{} + for _, org := range orgs { + repos, err := s.Client.ListOrgRepos(org) + if err != nil { + return nil, err + } + for _, repo := range repos { + if repo.Name == "" || repo.Empty { + continue + } + out = append(out, [2]string{org, repo.Name}) + } + } + return out, nil +} + +// iterOpenPulls 跨倉庫收集 open PR（附所屬 owner/repo）。 +// 對應 gitea.py 的 _iter_open_pulls：空倉庫、明確停用 PR 的倉庫跳過。 +func (s *Scanner) iterOpenPulls() ([]RepoPulls, error) { + orgs, err := s.Orgs() + if err != nil { + return nil, err + } + out := []RepoPulls{} + for _, org := range orgs { + repos, err := s.Client.ListOrgRepos(org) + if err != nil { + return nil, err + } + for _, repo := range repos { + if repo.Name == "" || repo.Empty { + continue + } + if repo.HasPullRequests != nil && !*repo.HasPullRequests { + continue + } + pulls, err := s.Client.ListPulls(org, repo.Name) + if err != nil { + return nil, err + } + if len(pulls) == 0 { + continue + } + out = append(out, RepoPulls{Owner: org, Repo: repo.Name, Pulls: pulls}) + } + } + return out, nil +} + +// orgIssue 是掃描到的 issue，附所屬 owner/repo。 +type orgIssue struct { + Owner string + Repo string + Issue Issue +} + +// collectMemberIssues 跨組織收集分派給 members（至少一人）且最後一則留言 +// 不是 assignee 的 open issues（gitea.py 的 for_all_organizations）。 +func (s *Scanner) collectMemberIssues(members []string) ([]orgIssue, error) { + pairs, err := s.iterOrgRepos() + if err != nil { + return nil, err + } + out := []orgIssue{} + for _, pair := range pairs { + owner, repo := pair[0], pair[1] + issues, err := s.Client.ListIssues(owner, repo) + if err != nil { + return nil, err + } + for i := range issues { + issue := &issues[i] + if !AssigneeOverlaps(issue, members) { + continue + } + comments, err := s.Client.ListComments(owner, repo, issue.issueNumber()) + if err != nil { + return nil, err + } + if !LastCommentNotByAssignee(issue, comments) { + continue + } + out = append(out, orgIssue{Owner: owner, Repo: repo, Issue: *issue}) + } + } + return out, nil +} + +// Mine 回傳分派給目前帳號、且最後一則留言不是 assignee 的 open issues +// （跨所屬組織；gitea.py 的 list_my_followup_issues）。 +func (s *Scanner) Mine() ([]Issue, error) { + username, err := s.Whoami() + if err != nil { + return nil, err + } + found, err := s.collectMemberIssues([]string{username}) + if err != nil { + return nil, err + } + out := make([]Issue, 0, len(found)) + for _, item := range found { + out = append(out, item.Issue) + } + return out, nil +} + +// Pulls 回傳跟進清單（跨倉庫；gitea.py 的 list_followup_pulls 系列）： +// - 預設：「有留言且最後一則不是作者」的 open PR。 +// - mine=true：再限定作者是目前帳號（list_my_followup_pulls）。 +// - reviewer=true：改為「自己是 requested reviewer、不是作者、最後一則 +// 留言不是自己（含尚無留言）」（list_my_reviewer_pulls）。 +// +// mine 與 reviewer 不可併用。 +func (s *Scanner) Pulls(mine, reviewer bool) ([]PullItem, error) { + if mine && reviewer { + return nil, errIncompatibleFlags + } + username := "" + if mine || reviewer { + var err error + username, err = s.Whoami() + if err != nil { + return nil, err + } + } + repoPulls, err := s.iterOpenPulls() + if err != nil { + return nil, err + } + found := []PullItem{} + for _, rp := range repoPulls { + for i := range rp.Pulls { + pr := &rp.Pulls[i] + comments, err := s.Client.ListComments(rp.Owner, rp.Repo, pr.Number) + if err != nil { + return nil, err + } + var match bool + switch { + case reviewer: + match = NeedsReviewerFollowup(pr, comments, username) + case mine: + match = NeedsAuthorFollowup(pr, comments) && pr.Author() == username + default: + match = NeedsAuthorFollowup(pr, comments) + } + if match { + found = append(found, PullItem{Owner: rp.Owner, Repo: rp.Repo, Pull: *pr}) + } + } + } + return found, nil +} + +// usernamesWithUnfinishedWork 從待跟進 issue／PR 清單收集有未完成工作的 +// 成員帳號（gitea.py 的 _usernames_with_unfinished_work；判定同 Next）。 +func (s *Scanner) usernamesWithUnfinishedWork(members []string) (map[string]bool, error) { + memberSet := map[string]bool{} + for _, m := range members { + if m != "" { + memberSet[m] = true + } + } + busy := map[string]bool{} + if len(memberSet) == 0 { + return busy, nil + } + + // issues：分派給任一成員、最後留言不是 assignee。 + issues, err := s.collectMemberIssues(members) + if err != nil { + return nil, err + } + for _, item := range issues { + for _, name := range AssigneeNames(&item.Issue) { + if memberSet[name] { + busy[name] = true + } + } + } + + // PR：作者待跟進／審核者待審。 + repoPulls, err := s.iterOpenPulls() + if err != nil { + return nil, err + } + for _, rp := range repoPulls { + for i := range rp.Pulls { + pr := &rp.Pulls[i] + comments, err := s.Client.ListComments(rp.Owner, rp.Repo, pr.Number) + if err != nil { + return nil, err + } + if NeedsAuthorFollowup(pr, comments) { + if author := pr.Author(); memberSet[author] { + busy[author] = true + } + } + for _, reviewer := range ReviewerNames(pr) { + if memberSet[reviewer] && NeedsReviewerFollowup(pr, comments, reviewer) { + busy[reviewer] = true + } + } + } + } + return busy, nil +} diff --git a/internal/workflow/scan_test.go b/internal/workflow/scan_test.go new file mode 100644 index 0000000..bba9e9e --- /dev/null +++ b/internal/workflow/scan_test.go @@ -0,0 +1,261 @@ +// scan_test.go — 以假 client 驗證 Scanner 的命令層語義（對照 gitea.py）： +// next 三層拾取與「最久未更新優先」、mine/pulls 過濾、members --has-work。 +package workflow + +import ( + "errors" + "fmt" + "reflect" + "testing" +) + +// fakeClient 以記憶體資料實作 Client。 +type fakeClient struct { + currentUser string + orgs []Org + teams map[string][]Team // org → teams + teamMembers map[int64][]string // teamID → 帳號 + repos map[string][]Repo // org → repos + issues map[string][]Issue // "owner/repo" → issues（open，不含 PR） + pulls map[string][]PullRequest // "owner/repo" → open PR + comments map[string][]Comment // "owner/repo#number" → 留言 + failOn map[string]error // 端點 → 錯誤（測失敗傳播） +} + +func (f *fakeClient) CurrentUser() (string, error) { + if err := f.failOn["user"]; err != nil { + return "", err + } + return f.currentUser, nil +} + +func (f *fakeClient) ListOrgs() ([]string, error) { + if err := f.failOn["orgs"]; err != nil { + return nil, err + } + out := make([]string, 0, len(f.orgs)) + for _, o := range f.orgs { + out = append(out, o.Account()) + } + return out, nil +} + +func (f *fakeClient) ListTeams(org string) ([]Team, error) { + if err := f.failOn["teams"]; err != nil { + return nil, err + } + return f.teams[org], nil +} + +func (f *fakeClient) ListTeamMembers(teamID int64) ([]string, error) { + if err := f.failOn["members"]; err != nil { + return nil, err + } + return f.teamMembers[teamID], nil +} + +func (f *fakeClient) ListOrgRepos(org string) ([]Repo, error) { + if err := f.failOn["repos"]; err != nil { + return nil, err + } + return f.repos[org], nil +} + +func (f *fakeClient) ListIssues(owner, repo string) ([]Issue, error) { + if err := f.failOn["issues"]; err != nil { + return nil, err + } + return f.issues[owner+"/"+repo], nil +} + +func (f *fakeClient) ListPulls(owner, repo string) ([]PullRequest, error) { + if err := f.failOn["pulls"]; err != nil { + return nil, err + } + return f.pulls[owner+"/"+repo], nil +} + +func (f *fakeClient) ListComments(owner, repo string, number int64) ([]Comment, error) { + if err := f.failOn["comments"]; err != nil { + return nil, err + } + return f.comments[fmt.Sprintf("%s/%s#%d", owner, repo, number)], nil +} + +// newTestScanner 構造測試情境：一個組織、一個 Agents 團隊、兩個倉庫。 +func newTestScanner() (*Scanner, *fakeClient) { + fc := &fakeClient{ + currentUser: "alex", + orgs: []Org{{UserName: "alterminal"}}, + teams: map[string][]Team{"alterminal": {{ID: 1, Name: "Agents"}}}, + teamMembers: map[int64][]string{1: {"alex", "max", "queena"}}, + repos: map[string][]Repo{"alterminal": {{Name: "teai"}, {Name: "agents"}}}, + issues: map[string][]Issue{}, + pulls: map[string][]PullRequest{}, + comments: map[string][]Comment{}, + failOn: map[string]error{}, + } + return &Scanner{Client: fc}, fc +} + +func TestNextLayerPriority(t *testing.T) { + s, fc := newTestScanner() + // 三層各有工作：author PR、reviewer PR、issue。 + fc.pulls["alterminal/teai"] = []PullRequest{ + { + Number: 10, Title: "我的 PR", UpdatedAt: "2026-09-09T00:00:00Z", + User: mkUser("alex"), + }, + { + Number: 11, Title: "待我審核的 PR", UpdatedAt: "2026-09-09T01:00:00Z", + User: mkUser("max"), + RequestedReviewers: []User{*mkUser("alex")}, + }, + } + // author PR #10 有他人留言 → 需跟進。 + fc.comments["alterminal/teai#10"] = []Comment{ + {CreatedAt: "2026-09-09T00:10:00Z", User: mkUser("ceo")}, + } + // reviewer PR #11 尚無留言 → 審核者仍應被列入。 + fc.issues["alterminal/agents"] = []Issue{ + {Number: 30, Title: "分派給 alex", UpdatedAt: "2026-09-08T00:00:00Z", Assignees: []User{*mkUser("alex")}}, + } + work, err := s.Next() + if err != nil { + t.Fatal(err) + } + if work.Type != "pull" || work.Role != "author" || work.Number != 10 { + t.Errorf("第一層應選 author PR #10，得到 %+v", work) + } +} + +func TestNextLayerFallbackToReviewer(t *testing.T) { + s, fc := newTestScanner() + fc.pulls["alterminal/teai"] = []PullRequest{ + { + Number: 11, Title: "待審核", UpdatedAt: "2026-09-09T01:00:00Z", + User: mkUser("max"), + RequestedReviewers: []User{*mkUser("alex")}, + }, + } + fc.issues["alterminal/agents"] = []Issue{ + {Number: 30, Title: "分派給 alex", UpdatedAt: "2026-09-08T00:00:00Z", Assignees: []User{*mkUser("alex")}}, + } + work, err := s.Next() + if err != nil { + t.Fatal(err) + } + if work.Type != "pull" || work.Role != "reviewer" || work.Number != 11 { + t.Errorf("第二層應選 reviewer PR #11，得到 %+v", work) + } +} + +func TestNextLayerFallbackToIssue(t *testing.T) { + s, fc := newTestScanner() + fc.issues["alterminal/agents"] = []Issue{ + {Number: 30, Title: "分派給 alex", UpdatedAt: "2026-09-08T00:00:00Z", Assignees: []User{*mkUser("alex")}}, + } + work, err := s.Next() + if err != nil { + t.Fatal(err) + } + if work.Type != "issue" || work.Number != 30 { + t.Errorf("第三層應選 issue #30，得到 %+v", work) + } +} + +func TestNextNone(t *testing.T) { + s, _ := newTestScanner() + work, err := s.Next() + if err != nil { + t.Fatal(err) + } + if work != nil { + t.Errorf("無工作應回 nil，得到 %+v", work) + } +} + +func TestNextOldestFirst(t *testing.T) { + s, fc := newTestScanner() + fc.issues["alterminal/agents"] = []Issue{ + {Number: 31, Title: "較新", UpdatedAt: "2026-09-09T00:00:00Z", Assignees: []User{*mkUser("alex")}}, + {Number: 30, Title: "較舊", UpdatedAt: "2026-09-08T00:00:00Z", Assignees: []User{*mkUser("alex")}}, + } + work, err := s.Next() + if err != nil { + t.Fatal(err) + } + if work.Number != 30 { + t.Errorf("應選最久未更新的 #30，得到 %+v", work) + } +} + +func TestMineSkipsLastCommentByAssignee(t *testing.T) { + s, fc := newTestScanner() + fc.issues["alterminal/agents"] = []Issue{ + {Number: 30, Title: "已在處理", UpdatedAt: "a", Assignees: []User{*mkUser("alex")}}, + } + fc.comments["alterminal/agents#30"] = []Comment{ + {CreatedAt: "b", User: mkUser("alex")}, + } + issues, err := s.Mine() + if err != nil { + t.Fatal(err) + } + if len(issues) != 0 { + t.Errorf("最後留言來自 assignee → 應略過，得到 %d 件", len(issues)) + } +} + +func TestPullsMineReviewersExclusive(t *testing.T) { + s, _ := newTestScanner() + if _, err := s.Pulls(true, true); !errors.Is(err, errIncompatibleFlags) { + t.Errorf("--mine 與 --reviewer 併用應回 errIncompatibleFlags，得到 %v", err) + } +} + +func TestMembersHasWork(t *testing.T) { + s, fc := newTestScanner() + // alex 有待審核 PR；max 無任何工作；queena 有分派 issue。 + fc.pulls["alterminal/teai"] = []PullRequest{ + { + Number: 11, UpdatedAt: "a", User: mkUser("max"), + RequestedReviewers: []User{*mkUser("alex")}, + }, + } + fc.issues["alterminal/agents"] = []Issue{ + {Number: 30, UpdatedAt: "b", Assignees: []User{*mkUser("queena")}}, + } + got, err := s.Members(true) + if err != nil { + t.Fatal(err) + } + if !reflect.DeepEqual(got, []string{"alex", "queena"}) { + t.Errorf("應只有 alex 與 queena 有工作，得到 %v", got) + } +} + +func TestErrorPropagation(t *testing.T) { + s, fc := newTestScanner() + fc.failOn["orgs"] = errors.New("boom") + if _, err := s.Next(); err == nil { + t.Errorf("API 錯誤應向上傳播，不應吞掉") + } +} + +func TestPullsDefault(t *testing.T) { + s, fc := newTestScanner() + fc.pulls["alterminal/teai"] = []PullRequest{ + {Number: 10, UpdatedAt: "a", User: mkUser("alex")}, + } + fc.comments["alterminal/teai#10"] = []Comment{ + {CreatedAt: "b", User: mkUser("ceo")}, + } + items, err := s.Pulls(false, false) + if err != nil { + t.Fatal(err) + } + if len(items) != 1 || items[0].Repo != "teai" { + t.Errorf("應列出待跟進 PR，得到 %+v", items) + } +} diff --git a/internal/workflow/types.go b/internal/workflow/types.go new file mode 100644 index 0000000..7bb032b --- /dev/null +++ b/internal/workflow/types.go @@ -0,0 +1,218 @@ +package workflow + +import ( + "encoding/json" + "regexp" +) + +// User 是 Gitea API 的使用者物件（僅取工作流判斷會用到的欄位）。 +type User struct { + UserName string `json:"username"` + Login string `json:"login"` +} + +// Name 回傳帳號名：先 username，缺漏時回退 login +// （對應 gitea.py 的「username or login」取值順序）。 +func (u *User) Name() string { + if u == nil { + return "" + } + if u.UserName != "" { + return u.UserName + } + return u.Login +} + +// Org 是帳號所屬的組織物件。 +type Org struct { + UserName string `json:"username"` + Name string `json:"name"` +} + +// Account 回傳組織名：先 username，缺漏時回退 name +// （對應 gitea.py 的取值順序）。 +func (o Org) Account() string { + if o.UserName != "" { + return o.UserName + } + return o.Name +} + +// Team 是組織內的團隊物件。 +type Team struct { + ID int64 `json:"id"` + Name string `json:"name"` +} + +// Repo 是組織倉庫清單中的倉庫物件。Empty 與 HasPullRequests +// 對應 gitea.py _iter_open_pulls 的跳過條件：空倉庫、明確停用 PR +// （has_pull_requests 為 false）者不列入 PR 掃描。 +type Repo struct { + Name string `json:"name"` + Empty bool `json:"empty"` + HasPullRequests *bool `json:"has_pull_requests"` +} + +// Repository 是 issue／PR 物件內嵌的所屬倉庫資訊。 +type Repository struct { + FullName string `json:"full_name"` +} + +// PRRef 是 PR 的 base/head 端點，含所屬倉庫。 +type PRRef struct { + Repo *Repository `json:"repo"` +} + +// Comment 是 issue／PR 的討論留言（PR 的留言也走 issues comments 端點）。 +type Comment struct { + CreatedAt string `json:"created_at"` + User *User `json:"user"` +} + +// Author 回傳留言者帳號；空字串表示未知。 +func (c *Comment) Author() string { return c.User.Name() } + +// pullMarker 標記 /issues 端點回傳的物件其實是 PR +// （Gitea 只會在 PR 上附帶 pull_request 欄位；issue 沒有此欄位）。 +type pullMarker struct{} + +// Issue 是 issue 物件。/issues 端點也會以此形狀回傳 PR（帶非 nil 的 +// PullRequest 標記），判斷時一律排除（同 gitea.py list_issues_for_repository）。 +type Issue struct { + Number int64 `json:"number"` + Index int64 `json:"index"` + Title string `json:"title"` + HTMLURL string `json:"html_url"` + URL string `json:"url"` + UpdatedAt string `json:"updated_at"` + Updated string `json:"updated"` + CreatedAt string `json:"created_at"` + Created string `json:"created"` + User *User `json:"user"` + Assignee *User `json:"assignee"` + Assignees []User `json:"assignees"` + PullRequest *pullMarker `json:"pull_request"` + Repository *Repository `json:"repository"` + + // Raw 是本次回應的完整原始 JSON。清單類命令（mine／pulls）必須原樣輸出 + // （gitea.py 直接傾印 API 原始物件），作為交叉驗證一致的基礎。 + Raw json.RawMessage `json:"-"` +} + +// UnmarshalJSON 解碼各判斷欄位，並保留原始 JSON 供原樣輸出。 +func (i *Issue) UnmarshalJSON(data []byte) error { + type issueAlias Issue + var a issueAlias + if err := json.Unmarshal(data, &a); err != nil { + return err + } + *i = Issue(a) + i.Raw = append(json.RawMessage(nil), data...) + return nil +} + +// updatedKey 對應 gitea.py 的 _updated_at 回退鏈 +// （updated_at → updated → created_at → created → "9999"）， +// 供「最久未更新優先」排序；ISO8601 字串字典序與時間序一致。 +func (i *Issue) updatedKey() string { + for _, v := range []string{i.UpdatedAt, i.Updated, i.CreatedAt, i.Created} { + if v != "" { + return v + } + } + return "9999" +} + +// WebURL 回傳網頁網址：先 html_url，缺漏時回退 API url。 +func (i *Issue) WebURL() string { + if i.HTMLURL != "" { + return i.HTMLURL + } + return i.URL +} + +// PullRequest 是 pull request 物件（僅取判斷所需欄位）。 +type PullRequest struct { + Number int64 `json:"number"` + Title string `json:"title"` + HTMLURL string `json:"html_url"` + URL string `json:"url"` + UpdatedAt string `json:"updated_at"` + Updated string `json:"updated"` + CreatedAt string `json:"created_at"` + Created string `json:"created"` + User *User `json:"user"` + RequestedReviewers []User `json:"requested_reviewers"` + Base *PRRef `json:"base"` + Head *PRRef `json:"head"` + Repository *Repository `json:"repository"` + + // Raw 意義同 Issue.Raw。 + Raw json.RawMessage `json:"-"` +} + +// UnmarshalJSON 解碼各判斷欄位，並保留原始 JSON 供原樣輸出。 +func (p *PullRequest) UnmarshalJSON(data []byte) error { + type pullAlias PullRequest + var a pullAlias + if err := json.Unmarshal(data, &a); err != nil { + return err + } + *p = PullRequest(a) + p.Raw = append(json.RawMessage(nil), data...) + return nil +} + +// updatedKey 意義同 Issue.updatedKey。 +func (p *PullRequest) updatedKey() string { + for _, v := range []string{p.UpdatedAt, p.Updated, p.CreatedAt, p.Created} { + if v != "" { + return v + } + } + return "9999" +} + +// Author 回傳 PR 發起者帳號（user 欄位）。 +func (p *PullRequest) Author() string { return p.User.Name() } + +// WebURL 回傳網頁網址：先 html_url，缺漏時回退 API url。 +func (p *PullRequest) WebURL() string { + if p.HTMLURL != "" { + return p.HTMLURL + } + return p.URL +} + +// htmlURLRepoRe 從網頁網址推回 "owner/repo" +// （gitea.py _full_name_of 的 html_url regex 回退）。 +var htmlURLRepoRe = regexp.MustCompile(`/([^/]+/[^/]+)/(?:issues|pulls)/[0-9]+`) + +func repoFullNameFromURL(webURL string) string { + if m := htmlURLRepoRe.FindStringSubmatch(webURL); m != nil { + return m[1] + } + return "" +} + +// FullName 從 issue 物件推回 "owner/repo"：先 repository 欄位，再以網頁網址回退。 +func (i *Issue) FullName() string { + if i.Repository != nil && i.Repository.FullName != "" { + return i.Repository.FullName + } + return repoFullNameFromURL(i.WebURL()) +} + +// FullName 從 PR 物件推回 "owner/repo"：repository → base.repo → head.repo → +// 網頁網址回退（Gitea 的 /pulls 回應通常沒有 repository 欄位）。 +func (p *PullRequest) FullName() string { + if p.Repository != nil && p.Repository.FullName != "" { + return p.Repository.FullName + } + for _, ref := range []*PRRef{p.Base, p.Head} { + if ref != nil && ref.Repo != nil && ref.Repo.FullName != "" { + return ref.Repo.FullName + } + } + return repoFullNameFromURL(p.WebURL()) +} -- 2.54.0 From 7badd9e46d266aaeba0b46b06a126feec1022f65 Mon Sep 17 00:00:00 2001 From: alex Date: Thu, 10 Sep 2026 09:19:03 +0800 Subject: [PATCH 2/2] =?UTF-8?q?internal/dailyops=20+=20cli=EF=BC=9A?= =?UTF-8?q?=E6=97=A5=E5=B8=B8=E6=93=8D=E4=BD=9C=E5=91=BD=E4=BB=A4=20issues?= =?UTF-8?q?/pulls/labels/milestones/releases/repos/api=EF=BC=88#8=EF=BC=89?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - internal/gitea：用戶端支援寫入動詞（DoJSON/DoRaw，共用 do 核心） - internal/dailyops：七組日常操作的 API 層（issues/pulls/labels/milestones/releases/repos/api） - internal/cli：子命令接線；寫入類一律 --yes 閘門（未確認不發請求、exit 2） - teai pulls 相容 #6 工作流用法（無子命令）；有子命令走日常操作 - 修正 dispatch：命令旗標（如 --has-work、--comments）不再被誤判為未知全域選項 - teai api 支援 path 內含查詢字串 - 單元測試（httptest 假伺服器）＋真實站點交叉驗證（讀取命令輸出對照 Gitea API；寫入回路 create→comment→close 於 alex/.profile 驗證後清理） --- README.md | 35 +- internal/cli/cli.go | 94 ++- internal/cli/dailyops_commands.go | 866 +++++++++++++++++++++++++ internal/cli/dailyops_commands_test.go | 289 +++++++++ internal/cli/workflow_commands.go | 3 +- internal/dailyops/dailyops.go | 384 +++++++++++ internal/gitea/client.go | 65 +- 7 files changed, 1721 insertions(+), 15 deletions(-) create mode 100644 internal/cli/dailyops_commands.go create mode 100644 internal/cli/dailyops_commands_test.go create mode 100644 internal/dailyops/dailyops.go diff --git a/README.md b/README.md index ed1b242..29d5f60 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ teai 是 Gitea 的命令列（CLI）輔助工具，補足官方 `tea` CLI 缺少 - **語言：** Go（與 Gitea 本體一致），僅用標準庫，離線可建置 - **目標站點：** `https://gitea.alterminal.com` -- **狀態：** 基礎建設（#5：internal/gitea）與工作流命令（#6：whoami/orgs/members/mine/pulls/next）已實作；stalled/xrefs（#7）與日常操作命令（#8）進行中 +- **狀態：** 基礎建設（#5：internal/gitea）、工作流命令（#6：whoami/orgs/members/mine/pulls/next）與日常操作命令（#8：issues/pulls/labels/milestones/releases/repos/api）已實作；stalled/xrefs（#7）進行中 ## 安裝與建置 @@ -28,7 +28,38 @@ go build -o teai ./cmd/teai 3. **機器可讀優先**：預設輸出 JSON；`--output table` 僅供人工抽查。 4. **可直接替換原型**：`gitea.py` 的每個子命令在 teai 都有語義相同的對應命令，可交叉驗證、平滑遷移。 5. **認證沿用 tea**：讀 `tea` 的登入組態（`TEA_CONFIG` 或 `~/.config/tea/config.yml`），不另建認證體系。 -6. **安全預設**：本期全部是查詢類（唯讀）；寫入類（留言、指派、審核者）不在本期範圍，未來加入時須明確 `--yes`。 +6. **安全預設**：查詢類唯讀；寫入類命令（#8 起）一律要求明確 `--yes`，未確認時不發出任何請求、不產生任何遠端變更。 + +### 日常操作（tea 對等指令；#8） + +issues／pulls／labels／milestones／releases／repos／api 的日常操作，自行實作、輸出一致 JSON、共用同一套認證與全域選項。介面語義以 `tea`／Gitea API 為相容參考。已實作： + +```sh +# issues +teai issues list --repo / [--state open|closed|all] +teai issues view --repo / [--comments] +teai issues create --repo / --title … [--body …] [--assignees a,b] --yes +teai issues close --repo / --yes +teai issues comment --repo / --body … --yes +# pulls（無子命令仍是工作流清單：--mine／--reviewer／--repo） +teai pulls list --repo / [--state open|closed|all] +teai pulls view --repo / [--comments] +teai pulls create --repo / --head [--base main] --title … [--body …] --yes +teai pulls merge --repo / [--style merge|rebase|rebase-merge|squash] --yes +teai pulls comment --repo / --body … --yes +# labels／milestones／releases／repos +teai labels list --repo / +teai labels create --repo / --name … [--color #RRGGBB] [--description …] --yes +teai milestones list --repo / [--state open|closed|all] +teai milestones create --repo / --title … [--description …] [--due RFC3339] --yes +teai releases list --repo / +teai repos list [--org ] +# 任意 API 呼叫（逃生口） +teai api [--method GET|POST|PATCH|DELETE] [--data ''] [--yes] +``` + +> `--yes` 閘門：所有寫入類命令（create／close／comment／merge／labels create／milestones create／api 非 GET 動詞）未帶 `--yes` 時回 exit 2（用法錯誤），且不發出任何 HTTP 請求。 +> `teai api` 的 path 內含查詢字串（如 `/repos/a/b/issues?state=closed`）時會正確傳遞。 ### 全域介面 diff --git a/internal/cli/cli.go b/internal/cli/cli.go index a4f756f..341a755 100644 --- a/internal/cli/cli.go +++ b/internal/cli/cli.go @@ -12,6 +12,7 @@ package cli import ( "errors" + "flag" "fmt" "io" "sort" @@ -144,6 +145,78 @@ var globalFlags = map[string]bool{ "--timeout": true, } +// extractGlobals 從 args 中「抽取」全域選項（可出現在命令之後、與命令 +// 旗標交錯），其餘引數依原順序保留給子命令剖析。未知的選項一律留給 +// 子命令處理（可能是命令旗標，如 --has-work），不在這裡報錯。 +func extractGlobals(g *Globals, args []string) ([]string, error) { + rest := make([]string, 0, len(args)) + applyGlobal := func(name, value string) error { + switch name { + case "--url": + if strings.TrimSpace(value) == "" { + return &ErrUsage{Msg: "--url must not be empty"} + } + g.URL = value + case "--token": + g.Token = value + case "--config": + if strings.TrimSpace(value) == "" { + return &ErrUsage{Msg: "--config must not be empty"} + } + g.ConfigPath = value + case "--output": + f, err := gitea.ParseFormat(value) + if err != nil { + return &ErrUsage{Msg: err.Error()} + } + g.Output = f + case "--timeout": + d, err := time.ParseDuration(value) + if err != nil || d <= 0 { + return &ErrUsage{Msg: fmt.Sprintf("invalid --timeout %q (want e.g. 30s)", value)} + } + g.Timeout = d + } + return nil + } + i := 0 + for i < len(args) { + arg := args[i] + if arg == "--" { + rest = append(rest, args[i+1:]...) + return rest, nil + } + if !strings.HasPrefix(arg, "--") { + rest = append(rest, arg) + i++ + continue + } + name, inline, hasInline := strings.Cut(arg, "=") + _, ok := globalFlags[name] + if !ok { + // 不是全域選項：留給子命令（可能是 --has-work 這類命令旗標）。 + rest = append(rest, arg) + i++ + continue + } + var value string + if hasInline { + value = inline + } else { + if i+1 >= len(args) { + return nil, &ErrUsage{Msg: fmt.Sprintf("global option %q requires a value", name)} + } + i++ + value = args[i] + } + if err := applyGlobal(name, value); err != nil { + return nil, err + } + i++ + } + return rest, nil +} + // parseGlobals 從 args 前端取走全域選項，回傳剩餘引數（命令與其參數）。 // 遇到第一個非選項引數即停；不認得的選項或缺少值都回 ErrUsage。 func parseGlobals(g *Globals, args []string) ([]string, error) { @@ -214,11 +287,12 @@ func parseGlobals(g *Globals, args []string) ([]string, error) { // dispatch 執行已註冊的子命令，把錯誤轉成結束碼並輸出。 // 旗標剖析交由各命令自行處理（不同命令有不同旗標，如 pulls --mine）； // 全域選項允許出現在命令之後（README 範例：teai next --output table）， -// 先從 args 剝離併入 Globals 再分派。 +// dispatch 先從 args 剝離全域選項併入 Globals，其餘（含命令自己的旗標， +// 如 --has-work）原樣交給命令，不會誤判為未知全域選項。 func dispatch(env *Env, name string, args []string) int { cmd := commands[name] g := env.Globals - rest, err := parseGlobals(&g, args) + rest, err := extractGlobals(&g, args) if err != nil { fmt.Fprintf(env.Err, "teai: %v\n\n", err) printUsage(env.Err) @@ -232,6 +306,22 @@ func dispatch(env *Env, name string, args []string) int { return int(ExitOK) } +// errHelp 表示使用者要求該命令的說明（-h/--help）；FlagSet 已自行印出 +// 用法，靜默成功結束即可。 +var errHelp = errors.New("help requested") + +// parseFlags 剖析命令旗標：-h/--help 回 errHelp（由 exitCodeFor 視為成功）， +// 其他剖析錯誤回 ErrUsage。 +func parseFlags(fs *flag.FlagSet, args []string) error { + if err := fs.Parse(args); err != nil { + if errors.Is(err, flag.ErrHelp) { + return errHelp + } + return &ErrUsage{Msg: err.Error()} + } + return nil +} + // exitCodeFor 把命令錯誤映射到結束碼：用法錯誤 → 2，API 錯誤 → 3， // 其他（內部）→ 1。 func exitCodeFor(err error) ExitCode { diff --git a/internal/cli/dailyops_commands.go b/internal/cli/dailyops_commands.go new file mode 100644 index 0000000..58e6dab --- /dev/null +++ b/internal/cli/dailyops_commands.go @@ -0,0 +1,866 @@ +// dailyops_commands.go — 日常操作命令的 CLI 接線（#8）：issues、pulls、 +// labels、milestones、releases、repos、api（tea 對等指令）。 +// +// 規則： +// - 寫入類命令（create／close／comment／merge…）一律要求 --yes， +// 未帶 --yes 時不產生任何遠端變更（exit 2，用法錯誤）。 +// - `teai pulls` 相容 #6 的工作流用法（無子命令＝工作流清單 --mine/--reviewer）； +// 有子命令（list/create/view/merge/comment）時走日常操作。 +// - 輸出走 internal/gitea 的 Printer（--output json|table）。 +package cli + +import ( + "context" + "encoding/json" + "flag" + "fmt" + "strconv" + "strings" + + "gitea.alterminal.com/alterminal/teai/internal/dailyops" + "gitea.alterminal.com/alterminal/teai/internal/gitea" +) + +func init() { + register := func(c *command) { commands[c.name] = c } + register(&command{name: "issues", usage: "issues 管理（list/view/create/close/comment）", run: runIssues}) + register(&command{name: "pulls", usage: "PR 管理（list/view/create/merge/comment；無子命令＝工作流清單）", run: runPullsDaily}) + register(&command{name: "labels", usage: "標籤管理（list/create）", run: runLabels}) + register(&command{name: "milestones", usage: "里程碑管理（list/create）", run: runMilestones}) + register(&command{name: "releases", usage: "發佈清單（list）", run: runReleases}) + register(&command{name: "repos", usage: "倉庫查詢（list）", run: runRepos}) + register(&command{name: "api", usage: "任意 API 呼叫（--method/--data；寫入動詞需 --yes）", run: runAPIDirect}) +} + +// requireYes 檢查寫入閘門：未帶 --yes 回 ErrUsage（exit 2），不觸發任何請求。 +func requireYes(yes bool, what string) error { + if !yes { + return &ErrUsage{Msg: what + " 是寫入操作，需 --yes 明確確認（未確認，未產生任何遠端變更）"} + } + return nil +} + +// splitRepoFlag 把 --repo owner/repo 拆成兩段；空值回 ("", "", nil)。 +func splitRepoFlag(v string) (string, string, error) { + if v == "" { + return "", "", nil + } + parts := strings.SplitN(v, "/", 2) + if len(parts) != 2 || parts[0] == "" || parts[1] == "" { + return "", "", &ErrUsage{Msg: errNoRepoFlag.Error()} + } + return parts[0], parts[1], nil +} + +// newOpsClient 依全域選項建立 dailyops 用戶端。 +func newOpsClient(env *Env) (*dailyops.Ops, error) { + token, _, err := gitea.ResolveToken(gitea.AuthOptions{ + FlagToken: env.Globals.Token, + SiteURL: env.Globals.URL, + ConfigPath: env.Globals.ConfigPath, + }) + if err != nil { + return nil, err + } + client, err := gitea.New(env.Globals.URL, token, env.Globals.Timeout) + if err != nil { + return nil, err + } + return &dailyops.Ops{Client: client}, nil +} + +// parseNumber 把位置參數解析為 issue／PR 編號。 +func parseNumber(s string) (int64, error) { + n, err := strconv.ParseInt(s, 10, 64) + if err != nil || n <= 0 { + return 0, &ErrUsage{Msg: fmt.Sprintf("無效的編號 %q", s)} + } + return n, nil +} + +// joinOrEmpty 把清單型欄位格式化為逗號分隔（table 用）。 +func joinOrEmpty(v any) string { + switch x := v.(type) { + case string: + return x + case []string: + return strings.Join(x, ",") + default: + return fmt.Sprint(x) + } +} + +// issueRowsFields 是 issues 清單的欄位定義（與值順序對應）。 +func issueListFields() []gitea.Field { + return []gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "state"}, + {Name: "author"}, {Name: "assignees", ValueFmt: joinOrEmpty}, {Name: "updated_at"}, + } +} + +// ---- issues ---- + +// runIssues：teai issues [list|view|create|close|comment] … +func runIssues(env *Env, args []string) error { + if len(args) == 0 { + return &ErrUsage{Msg: "issues 需要子命令：list | view | create | close | comment"} + } + sub, rest := args[0], args[1:] + switch sub { + case "list": + return runIssuesList(env, rest) + case "view": + return runIssuesView(env, rest) + case "create": + return runIssuesCreate(env, rest) + case "close": + return runIssuesClose(env, rest) + case "comment": + return runComment(env, rest, false) + default: + return &ErrUsage{Msg: fmt.Sprintf("issues 未知子命令 %q（可用：list | view | create | close | comment）", sub)} + } +} + +// runIssuesList：teai issues list --repo owner/repo [--state open|closed|all] +func runIssuesList(env *Env, args []string) error { + fs := flag.NewFlagSet("teai issues list", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + state := fs.String("state", "open", "狀態：open|closed|all") + if err := parseFlags(fs, args); err != nil { + return err + } + if fs.NArg() != 0 { + return &ErrUsage{Msg: "issues list 不接受位置參數"} + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "issues list 需要 --repo owner/repo"} + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + issues, err := ops.ListIssues(context.Background(), owner, name, *state) + if err != nil { + return err + } + p := printer(env) + rows := make([]gitea.Values, 0, len(issues)) + for i := range issues { + it := &issues[i] + rows = append(rows, gitea.Values{ + it.Number, it.Title, it.State, it.Author(), + it.AssigneeNames(), it.UpdatedAt, + }) + } + return p.PrintList(issueListFields(), rows) +} + +// runIssuesView：teai issues view --repo owner/repo [--comments] +func runIssuesView(env *Env, args []string) error { + fs := flag.NewFlagSet("teai issues view", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + withComments := fs.Bool("comments", false, "連留言一起輸出") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "issues view 需要 --repo owner/repo"} + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: "issues view 需要恰好一個編號"} + } + num, err := parseNumber(fs.Arg(0)) + if err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + it, err := ops.GetIssue(context.Background(), owner, name, num) + if err != nil { + return err + } + p := printer(env) + fields := []gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "state"}, + {Name: "author"}, {Name: "assignees", ValueFmt: joinOrEmpty}, + {Name: "labels", ValueFmt: joinOrEmpty}, {Name: "body"}, + {Name: "url"}, {Name: "updated_at"}, + } + row := gitea.Values{ + it.Number, it.Title, it.State, it.Author(), + it.AssigneeNames(), it.LabelNames(), it.Body, + it.HTMLURL, it.UpdatedAt, + } + if err := p.PrintOne(fields, row); err != nil { + return err + } + if !*withComments { + return nil + } + return printComments(env, ops, owner, name, num) +} + +// printComments 輸出 issue／PR 的留言清單（view --comments 共用）。 +func printComments(env *Env, ops *dailyops.Ops, owner, repo string, number int64) error { + comments, err := ops.ListComments(context.Background(), owner, repo, number) + if err != nil { + return err + } + p := printer(env) + rows := make([]gitea.Values, 0, len(comments)) + for i := range comments { + c := &comments[i] + rows = append(rows, gitea.Values{c.Author(), c.CreatedAt, c.Body}) + } + return p.PrintList([]gitea.Field{ + {Name: "author"}, {Name: "created_at"}, {Name: "body"}, + }, rows) +} + +// runIssuesCreate：teai issues create --repo owner/repo --title … [--body …] [--assignees a,b] --yes +func runIssuesCreate(env *Env, args []string) error { + fs := flag.NewFlagSet("teai issues create", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + title := fs.String("title", "", "標題（必填）") + body := fs.String("body", "", "內文") + assignees := fs.String("assignees", "", "assignees（逗號分隔，可選）") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "issues create 需要 --repo owner/repo"} + } + if strings.TrimSpace(*title) == "" { + return &ErrUsage{Msg: "issues create 需要 --title"} + } + if err := requireYes(*yes, "issues create"); err != nil { + return err + } + var assigneeList []string + if strings.TrimSpace(*assignees) != "" { + for _, a := range strings.Split(*assignees, ",") { + if a = strings.TrimSpace(a); a != "" { + assigneeList = append(assigneeList, a) + } + } + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + issue, err := ops.CreateIssue(context.Background(), owner, name, *title, *body, assigneeList) + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "url"}, + }, gitea.Values{issue.Number, issue.Title, issue.HTMLURL}) +} + +// runIssuesClose：teai issues close --repo owner/repo --yes +func runIssuesClose(env *Env, args []string) error { + fs := flag.NewFlagSet("teai issues close", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "issues close 需要 --repo owner/repo"} + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: "issues close 需要恰好一個編號"} + } + num, err := parseNumber(fs.Arg(0)) + if err != nil { + return err + } + if err := requireYes(*yes, "issues close"); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + issue, err := ops.SetIssueState(context.Background(), owner, name, num, "closed") + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "state"}, {Name: "url"}, + }, gitea.Values{issue.Number, issue.Title, issue.State, issue.HTMLURL}) +} + +// runComment：teai issues comment / teai pulls comment 共用。 +func runComment(env *Env, args []string, isPR bool) error { + name := "issues comment" + if isPR { + name = "pulls comment" + } + fs := flag.NewFlagSet("teai "+name, flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + body := fs.String("body", "", "留言內容（必填）") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, rname, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: name + " 需要 --repo owner/repo"} + } + if strings.TrimSpace(*body) == "" { + return &ErrUsage{Msg: name + " 需要 --body"} + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: name + " 需要恰好一個編號"} + } + num, err := parseNumber(fs.Arg(0)) + if err != nil { + return err + } + if err := requireYes(*yes, name); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + comment, err := ops.AddComment(context.Background(), owner, rname, num, *body) + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "author"}, {Name: "created_at"}, {Name: "body"}, + }, gitea.Values{comment.Author(), comment.CreatedAt, comment.Body}) +} + +// ---- pulls ---- + +// runPullsDaily：teai pulls [list|view|create|merge|comment] …； +// 無子命令時沿用 #6 的工作流清單（teai pulls [--mine|--reviewer] [--repo]）。 +func runPullsDaily(env *Env, args []string) error { + if len(args) == 0 || strings.HasPrefix(args[0], "-") { + // 相容 #6：teai pulls / teai pulls --mine …（工作流清單）。 + return runPulls(env, args) + } + sub, rest := args[0], args[1:] + switch sub { + case "list": + return runPullsList(env, rest) + case "view": + return runPullsView(env, rest) + case "create": + return runPullsCreate(env, rest) + case "merge": + return runPullsMerge(env, rest) + case "comment": + return runComment(env, rest, true) + default: + return &ErrUsage{Msg: fmt.Sprintf("pulls 未知子命令 %q（可用：list | view | create | merge | comment；或無子命令＝工作流清單）", sub)} + } +} + +// runPullsList：teai pulls list --repo owner/repo [--state open|closed|all] +func runPullsList(env *Env, args []string) error { + fs := flag.NewFlagSet("teai pulls list", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + state := fs.String("state", "open", "狀態：open|closed|all") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "pulls list 需要 --repo owner/repo"} + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + pulls, err := ops.ListPulls(context.Background(), owner, name, *state) + if err != nil { + return err + } + p := printer(env) + rows := make([]gitea.Values, 0, len(pulls)) + for i := range pulls { + pr := &pulls[i] + rows = append(rows, gitea.Values{ + pr.Number, pr.Title, pr.State, pr.Author(), + pr.HeadRef(), pr.BaseRef(), pr.UpdatedAt, + }) + } + return p.PrintList([]gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "state"}, + {Name: "author"}, {Name: "head"}, {Name: "base"}, {Name: "updated_at"}, + }, rows) +} + +// runPullsView：teai pulls view --repo owner/repo [--comments] +func runPullsView(env *Env, args []string) error { + fs := flag.NewFlagSet("teai pulls view", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + withComments := fs.Bool("comments", false, "連留言一起輸出") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "pulls view 需要 --repo owner/repo"} + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: "pulls view 需要恰好一個編號"} + } + num, err := parseNumber(fs.Arg(0)) + if err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + pr, err := ops.GetPull(context.Background(), owner, name, num) + if err != nil { + return err + } + p := printer(env) + fields := []gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "state"}, + {Name: "author"}, {Name: "head"}, {Name: "base"}, {Name: "body"}, + {Name: "url"}, {Name: "updated_at"}, + } + row := gitea.Values{ + pr.Number, pr.Title, pr.State, pr.Author(), + pr.HeadRef(), pr.BaseRef(), pr.Body, pr.HTMLURL, pr.UpdatedAt, + } + if err := p.PrintOne(fields, row); err != nil { + return err + } + if !*withComments { + return nil + } + return printComments(env, ops, owner, name, num) +} + +// runPullsCreate：teai pulls create --repo owner/repo --head --base --title … [--body …] --yes +func runPullsCreate(env *Env, args []string) error { + fs := flag.NewFlagSet("teai pulls create", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + head := fs.String("head", "", "來源分支（必填）") + base := fs.String("base", "main", "目標分支（預設 main）") + title := fs.String("title", "", "標題（必填）") + body := fs.String("body", "", "說明") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "pulls create 需要 --repo owner/repo"} + } + if *head == "" || *title == "" { + return &ErrUsage{Msg: "pulls create 需要 --head 與 --title"} + } + if err := requireYes(*yes, "pulls create"); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + pr, err := ops.CreatePull(context.Background(), owner, name, *title, *body, *head, *base) + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "number"}, {Name: "title"}, {Name: "url"}, + }, gitea.Values{pr.Number, pr.Title, pr.HTMLURL}) +} + +// runPullsMerge：teai pulls merge --repo owner/repo [--style merge|rebase|squash] --yes +func runPullsMerge(env *Env, args []string) error { + fs := flag.NewFlagSet("teai pulls merge", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + style := fs.String("style", "merge", "合併方式：merge|rebase|rebase-merge|squash") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "pulls merge 需要 --repo owner/repo"} + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: "pulls merge 需要恰好一個編號"} + } + num, err := parseNumber(fs.Arg(0)) + if err != nil { + return err + } + switch *style { + case "merge", "rebase", "rebase-merge", "squash": + default: + return &ErrUsage{Msg: "pulls merge 的 --style 需為 merge|rebase|rebase-merge|squash"} + } + if err := requireYes(*yes, "pulls merge"); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + if err := ops.MergePull(context.Background(), owner, name, num, *style); err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "number"}, {Name: "state"}, + }, gitea.Values{num, "merged"}) +} + +// ---- labels ---- + +// runLabels：teai labels list --repo owner/repo｜teai labels create … --yes +func runLabels(env *Env, args []string) error { + if len(args) == 0 { + return &ErrUsage{Msg: "labels 需要子命令：list | create"} + } + sub, rest := args[0], args[1:] + switch sub { + case "list": + return runLabelsList(env, rest) + case "create": + return runLabelsCreate(env, rest) + default: + return &ErrUsage{Msg: fmt.Sprintf("labels 未知子命令 %q（可用：list | create）", sub)} + } +} + +// runLabelsList：teai labels list --repo owner/repo +func runLabelsList(env *Env, args []string) error { + fs := flag.NewFlagSet("teai labels list", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "labels list 需要 --repo owner/repo"} + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + labels, err := ops.ListLabels(context.Background(), owner, name) + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(labels)) + for _, l := range labels { + rows = append(rows, gitea.Values{l.Name, l.Color, l.Description}) + } + return printer(env).PrintList([]gitea.Field{ + {Name: "name"}, {Name: "color"}, {Name: "description"}, + }, rows) +} + +// runLabelsCreate：teai labels create --repo owner/repo --name … [--color …] [--description …] --yes +func runLabelsCreate(env *Env, args []string) error { + fs := flag.NewFlagSet("teai labels create", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + labelName := fs.String("name", "", "標籤名（必填）") + color := fs.String("color", "#ffffff", "顏色（#RRGGBB，預設 #ffffff）") + desc := fs.String("description", "", "說明") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "labels create 需要 --repo owner/repo"} + } + if *labelName == "" { + return &ErrUsage{Msg: "labels create 需要 --name"} + } + if err := requireYes(*yes, "labels create"); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + label, err := ops.CreateLabel(context.Background(), owner, name, *labelName, *color, *desc) + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "name"}, {Name: "color"}, {Name: "description"}, + }, gitea.Values{label.Name, label.Color, label.Description}) +} + +// ---- milestones ---- + +// runMilestones：teai milestones list｜create … +func runMilestones(env *Env, args []string) error { + if len(args) == 0 { + return &ErrUsage{Msg: "milestones 需要子命令：list | create"} + } + sub, rest := args[0], args[1:] + switch sub { + case "list": + return runMilestonesList(env, rest) + case "create": + return runMilestonesCreate(env, rest) + default: + return &ErrUsage{Msg: fmt.Sprintf("milestones 未知子命令 %q（可用：list | create）", sub)} + } +} + +// runMilestonesList：teai milestones list --repo owner/repo [--state open|closed|all] +func runMilestonesList(env *Env, args []string) error { + fs := flag.NewFlagSet("teai milestones list", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + state := fs.String("state", "open", "狀態：open|closed|all") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "milestones list 需要 --repo owner/repo"} + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + ms, err := ops.ListMilestones(context.Background(), owner, name, *state) + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(ms)) + for _, m := range ms { + rows = append(rows, gitea.Values{m.Title, m.State, m.Description, m.DueOn}) + } + return printer(env).PrintList([]gitea.Field{ + {Name: "title"}, {Name: "state"}, {Name: "description"}, {Name: "due_on"}, + }, rows) +} + +// runMilestonesCreate：teai milestones create --repo owner/repo --title … [--description …] [--due …] --yes +func runMilestonesCreate(env *Env, args []string) error { + fs := flag.NewFlagSet("teai milestones create", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + title := fs.String("title", "", "標題（必填）") + desc := fs.String("description", "", "說明") + due := fs.String("due", "", "截止日（RFC3339，可選）") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "milestones create 需要 --repo owner/repo"} + } + if *title == "" { + return &ErrUsage{Msg: "milestones create 需要 --title"} + } + if err := requireYes(*yes, "milestones create"); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + m, err := ops.CreateMilestone(context.Background(), owner, name, *title, *desc, *due) + if err != nil { + return err + } + return printer(env).PrintOne([]gitea.Field{ + {Name: "id"}, {Name: "title"}, {Name: "state"}, {Name: "due_on"}, + }, gitea.Values{m.ID, m.Title, m.State, m.DueOn}) +} + +// ---- releases / repos / api ---- + +// runReleases：teai releases list --repo owner/repo +func runReleases(env *Env, args []string) error { + if len(args) == 0 || args[0] != "list" { + return &ErrUsage{Msg: "releases 目前支援子命令：list"} + } + fs := flag.NewFlagSet("teai releases list", flag.ContinueOnError) + fs.SetOutput(env.Err) + repo := fs.String("repo", "", "倉庫（owner/repo，必填）") + if err := parseFlags(fs, args[1:]); err != nil { + return err + } + owner, name, err := splitRepoFlag(*repo) + if err != nil { + return err + } + if owner == "" { + return &ErrUsage{Msg: "releases list 需要 --repo owner/repo"} + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + releases, err := ops.ListReleases(context.Background(), owner, name) + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(releases)) + for _, r := range releases { + rows = append(rows, gitea.Values{r.TagName, r.Name, r.Draft, r.Prerelease, r.PublishedAt}) + } + return printer(env).PrintList([]gitea.Field{ + {Name: "tag_name"}, {Name: "name"}, {Name: "draft"}, {Name: "prerelease"}, {Name: "published_at"}, + }, rows) +} + +// runRepos：teai repos list [--org ]（未指定 --org 則列自己可存的倉庫） +func runRepos(env *Env, args []string) error { + if len(args) == 0 || args[0] != "list" { + return &ErrUsage{Msg: "repos 目前支援子命令：list"} + } + fs := flag.NewFlagSet("teai repos list", flag.ContinueOnError) + fs.SetOutput(env.Err) + org := fs.String("org", "", "組織（未指定則列自己可存取的倉庫）") + if err := parseFlags(fs, args[1:]); err != nil { + return err + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + var repos []dailyops.Repo + if *org != "" { + repos, err = ops.ListOrgRepos(context.Background(), *org) + } else { + repos, err = ops.ListMyRepos(context.Background()) + } + if err != nil { + return err + } + rows := make([]gitea.Values, 0, len(repos)) + for _, r := range repos { + rows = append(rows, gitea.Values{r.FullName, r.Private, r.Empty, r.UpdatedAt, r.HTMLURL}) + } + return printer(env).PrintList([]gitea.Field{ + {Name: "full_name"}, {Name: "private"}, {Name: "empty"}, {Name: "updated_at"}, {Name: "url"}, + }, rows) +} + +// runAPIDirect：teai api [--method GET|POST|…] [--data ] [--yes] +func runAPIDirect(env *Env, args []string) error { + fs := flag.NewFlagSet("teai api", flag.ContinueOnError) + fs.SetOutput(env.Err) + method := fs.String("method", "GET", "HTTP 動詞（GET 預設；非 GET 需 --yes）") + data := fs.String("data", "", "請求 body（JSON 字串，可選）") + yes := fs.Bool("yes", false, "確認寫入") + if err := parseFlags(fs, args); err != nil { + return err + } + if fs.NArg() != 1 { + return &ErrUsage{Msg: "api 需要恰好一個 path（相對 api/v1，以 / 開頭）"} + } + path := fs.Arg(0) + // path 內含查詢字串（如 /repos/x?state=closed）時剝離到 rawQuery， + // 不可併進 URL path（會 404）。 + rawQuery := "" + if q := strings.IndexByte(path, '?'); q >= 0 { + rawQuery = path[q+1:] + path = path[:q] + } + if path == "" || path[0] != '/' { + return &ErrUsage{Msg: "api path 必須以 / 開頭（相對 api/v1）"} + } + upper := strings.ToUpper(strings.TrimSpace(*method)) + if upper == "" { + upper = "GET" + } + switch upper { + case "GET", "HEAD", "OPTIONS": + default: + if err := requireYes(*yes, "api "+upper); err != nil { + return err + } + } + var payload []byte + if strings.TrimSpace(*data) != "" { + if !json.Valid([]byte(*data)) { + return &ErrUsage{Msg: "--data 必須是合法 JSON"} + } + payload = []byte(*data) + } + ops, err := newOpsClient(env) + if err != nil { + return err + } + resp, err := ops.CallAPIDirect(context.Background(), upper, path, rawQuery, payload) + if err != nil { + return err + } + // 原樣輸出（teai api 是逃生口，不做欄位挑選）。 + _, err = env.Out.Write(resp) + if len(resp) > 0 && resp[len(resp)-1] != '\n' { + fmt.Fprintln(env.Out) + } + return err +} diff --git a/internal/cli/dailyops_commands_test.go b/internal/cli/dailyops_commands_test.go new file mode 100644 index 0000000..b59e175 --- /dev/null +++ b/internal/cli/dailyops_commands_test.go @@ -0,0 +1,289 @@ +// dailyops_commands_test.go — #8 的驗收測試：以 httptest 假伺服器驗證 +// issues/pulls/labels/milestones/releases/repos/api 的讀取行為，與 +// 寫入命令的 --yes 閘門（未帶 --yes 不得發出任何請求）。 +package cli + +import ( + "fmt" + "net/http" + "net/http/httptest" + "strings" + "testing" +) + +// opsTestServer 建立假 Gitea API 伺服器與對應的執行輔助。 +func opsTestServer(t *testing.T, handler http.HandlerFunc) func(args ...string) (string, string, int) { + t.Helper() + srv := httptest.NewServer(handler) + t.Cleanup(srv.Close) + return func(args ...string) (string, string, int) { + full := append([]string{"--url", srv.URL}, args...) + return runCLI(full...) // 套件級輔助（見下） + } +} + +// runCLI 是 cli_test.go `run` 的別名，避免與各測試內的區域變數 run 混淆。 +func runCLI(args ...string) (string, string, int) { + return run(args...) +} + +// TestIssuesListReadsOpenIssuesOnly 驗證 issues list 帶 state=open 與 +// type=issues（排除 PR），輸出 JSON 陣列。 +func TestIssuesListReadsOpenIssuesOnly(t *testing.T) { + var gotQuery string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotQuery = r.URL.RawQuery + fmt.Fprint(w, `[{"number":8,"title":"日常操作","state":"open","user":{"login":"ceo"},"assignees":[{"login":"alex"}],"updated_at":"2026-09-10T08:13:00Z"}]`) + }) + stdout, _, code := run("issues", "list", "--repo", "alterminal/teai") + if code != 0 { + t.Fatalf("issues list 應回 0，得到 %d", code) + } + if !strings.Contains(gotQuery, "state=open") || !strings.Contains(gotQuery, "type=issues") { + t.Errorf("查詢參數應含 state=open 與 type=issues，得到 %q", gotQuery) + } + if !strings.Contains(stdout, `"number":8`) || !strings.Contains(stdout, `"author":"ceo"`) { + t.Errorf("輸出應含 number 與 author 欄位，得到：%s", stdout) + } +} + +// TestIssuesListRequiresRepo 驗證 --repo 必填。 +func TestIssuesListRequiresRepo(t *testing.T) { + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + t.Errorf("不應發出任何請求") + }) + _, stderr, code := run("issues", "list") + if code != int(ExitUsage) { + t.Errorf("缺 --repo 應回 ExitUsage，得到 %d", code) + } + if !strings.Contains(stderr, "--repo") { + t.Errorf("錯誤訊息應提及 --repo，得到：%s", stderr) + } +} + +// TestIssuesViewWithComments 驗證 view --comments 連留言輸出。 +func TestIssuesViewWithComments(t *testing.T) { + var paths []string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + paths = append(paths, r.URL.Path) + switch { + case strings.HasSuffix(r.URL.Path, "/issues/8"): + fmt.Fprint(w, `{"number":8,"title":"日常操作","state":"open","user":{"login":"ceo"},"body":"內文","html_url":"https://x/8","labels":[],"updated_at":"t"}`) + case strings.HasSuffix(r.URL.Path, "/comments"): + fmt.Fprint(w, `[{"body":"開始處理","created_at":"t1","user":{"login":"alex"}}]`) + default: + fmt.Fprint(w, `[]`) + } + }) + stdout, _, code := run("issues", "view", "--repo", "alterminal/teai", "--comments", "8") + if code != 0 { + t.Fatalf("view --comments 應回 0，得到 %d", code) + } + if len(paths) != 2 || !strings.HasSuffix(paths[1], "/issues/8/comments") { + t.Errorf("應依序呼叫 issue 與 comments 端點，得到 %v", paths) + } + if !strings.Contains(stdout, `"body":"開始處理"`) { + t.Errorf("輸出應含留言內容，得到：%s", stdout) + } +} + +// TestWriteCommandsRequireYes 驗證所有寫入命令未帶 --yes 時： +// 回 ExitUsage 且不發出任何 HTTP 請求（issue 驗收條件）。 +func TestWriteCommandsRequireYes(t *testing.T) { + cases := []struct { + name string + args []string + }{ + {"issues create", []string{"issues", "create", "--repo", "a/b", "--title", "t"}}, + {"issues close", []string{"issues", "close", "--repo", "a/b", "1"}}, + {"issues comment", []string{"issues", "comment", "--repo", "a/b", "--body", "x", "1"}}, + {"pulls create", []string{"pulls", "create", "--repo", "a/b", "--head", "h", "--title", "t"}}, + {"pulls merge", []string{"pulls", "merge", "--repo", "a/b", "1"}}, + {"pulls comment", []string{"pulls", "comment", "--repo", "a/b", "--body", "x", "1"}}, + {"labels create", []string{"labels", "create", "--repo", "a/b", "--name", "n"}}, + {"milestones create", []string{"milestones", "create", "--repo", "a/b", "--title", "t"}}, + {"api POST", []string{"api", "--method", "POST", "/repos/a/b/issues"}}, + } + for _, tc := range cases { + t.Run(tc.name, func(t *testing.T) { + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + t.Errorf("%s：未帶 --yes 不得發出請求（%s %s）", tc.name, r.Method, r.URL.Path) + }) + _, stderr, code := run(tc.args...) + if code != int(ExitUsage) { + t.Errorf("%s 未帶 --yes 應回 ExitUsage(2)，得到 %d", tc.name, code) + } + if !strings.Contains(stderr, "--yes") { + t.Errorf("%s 錯誤訊息應提及 --yes，得到：%s", tc.name, stderr) + } + }) + } +} + +// TestIssuesCreateWithYes 驗證帶 --yes 時 POST 正確 payload。 +func TestIssuesCreateWithYes(t *testing.T) { + var gotMethod, gotPath, gotBody string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotMethod, gotPath = r.Method, r.URL.Path + buf := make([]byte, 512) + n, _ := r.Body.Read(buf) + gotBody = string(buf[:n]) + fmt.Fprint(w, `{"number":15,"title":"新 issue","html_url":"https://x/15"}`) + }) + stdout, _, code := run("issues", "create", "--repo", "alterminal/teai", "--title", "新 issue", "--body", "說明", "--assignees", "alex,ceo", "--yes") + if code != 0 { + t.Fatalf("create --yes 應回 0，得到 %d", code) + } + if gotMethod != "POST" || !strings.HasSuffix(gotPath, "/repos/alterminal/teai/issues") { + t.Errorf("應 POST /repos/alterminal/teai/issues，得到 %s %s", gotMethod, gotPath) + } + if !strings.Contains(gotBody, `"assignees":["alex","ceo"]`) { + t.Errorf("body 應含 assignees，得到：%s", gotBody) + } + if !strings.Contains(stdout, `"number":15`) { + t.Errorf("輸出應含新 issue 編號，得到：%s", stdout) + } +} + +// TestPullsListAndSubcommands 驗證 pulls list 與 pulls（無子命令）可並存。 +func TestPullsListAndSubcommands(t *testing.T) { + var gotPath string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotPath = r.URL.Path + fmt.Fprint(w, `[{"number":13,"title":"PR","state":"open","user":{"login":"alex"},"head":{"ref":"feat"},"base":{"ref":"main"},"updated_at":"t"}]`) + }) + stdout, _, code := run("pulls", "list", "--repo", "alterminal/teai") + if code != 0 { + t.Fatalf("pulls list 應回 0，得到 %d", code) + } + if !strings.HasSuffix(gotPath, "/repos/alterminal/teai/pulls") { + t.Errorf("應呼叫 /repos/alterminal/teai/pulls，得到 %s", gotPath) + } + if !strings.Contains(stdout, `"head":"feat"`) || !strings.Contains(stdout, `"base":"main"`) { + t.Errorf("輸出應含 head/base 欄位，得到：%s", stdout) + } +} + +// TestLabelsMilestonesReleasesList 驗證三個清單命令打對端點並輸出。 +func TestLabelsMilestonesReleasesList(t *testing.T) { + cases := []struct { + args []string + path string + resp string + wantOut string + }{ + { + args: []string{"labels", "list", "--repo", "a/b"}, + path: "/api/v1/repos/a/b/labels", + resp: `[{"name":"enhancement","color":"#84b6eb","description":""}]`, + wantOut: `"name":"enhancement"`, + }, + { + args: []string{"milestones", "list", "--repo", "a/b"}, + path: "/api/v1/repos/a/b/milestones", + resp: `[{"title":"v1","state":"open","description":"","due_on":""}]`, + wantOut: `"title":"v1"`, + }, + { + args: []string{"releases", "list", "--repo", "a/b"}, + path: "/api/v1/repos/a/b/releases", + resp: `[{"tag_name":"v1.0.0","name":"首個發佈","draft":false,"prerelease":false,"published_at":"t"}]`, + wantOut: `"tag_name":"v1.0.0"`, + }, + { + args: []string{"repos", "list", "--org", "alterminal"}, + path: "/api/v1/orgs/alterminal/repos", + resp: `[{"full_name":"alterminal/teai","private":false,"empty":false,"updated_at":"t","html_url":"u"}]`, + wantOut: `"full_name":"alterminal/teai"`, + }, + } + for _, tc := range cases { + t.Run(strings.Join(tc.args, " "), func(t *testing.T) { + var gotPath string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotPath = r.URL.Path + fmt.Fprint(w, tc.resp) + }) + stdout, _, code := run(tc.args...) + if code != 0 { + t.Fatalf("%v 應回 0，得到 %d", tc.args, code) + } + if gotPath != tc.path { + t.Errorf("應呼叫 %s，得到 %s", tc.path, gotPath) + } + if !strings.Contains(stdout, tc.wantOut) { + t.Errorf("輸出應含 %s，得到：%s", tc.wantOut, stdout) + } + }) + } +} + +// TestAPIDirectPassthrough 驗證 teai api 原樣輸出、GET 免 --yes、 +// POST 未帶 --yes 被擋。 +func TestAPIDirectPassthrough(t *testing.T) { + var gotMethod string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotMethod = r.Method + fmt.Fprint(w, `{"version":"1.27.0"}`) + }) + stdout, _, code := run("api", "/version") + if code != 0 || gotMethod != "GET" { + t.Fatalf("GET /version 應回 0，得到 %d (%s)", code, gotMethod) + } + if strings.TrimSpace(stdout) != `{"version":"1.27.0"}` { + t.Errorf("api 應原樣輸出，得到：%s", stdout) + } + + _, stderr, code := run("api", "--method", "POST", "/version") + if code != int(ExitUsage) || !strings.Contains(stderr, "--yes") { + t.Errorf("POST 未帶 --yes 應回 2 並提及 --yes，得到 %d：%s", code, stderr) + } +} + +// TestAPIDirectQueryInPath 驗證 path 內含 ?query 時查詢字串正確傳遞。 +func TestAPIDirectQueryInPath(t *testing.T) { + var gotQuery, gotPath string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + gotPath, gotQuery = r.URL.Path, r.URL.RawQuery + fmt.Fprint(w, `[]`) + }) + _, _, code := run("api", "/repos/a/b/issues?state=closed&limit=10") + if code != 0 { + t.Fatalf("api 帶查詢字串應回 0，得到 %d", code) + } + if gotPath != "/api/v1/repos/a/b/issues" || gotQuery != "state=closed&limit=10" { + t.Errorf("應剝離查詢字串，得到 path=%s query=%s", gotPath, gotQuery) + } +} + +// TestIssuesCommentPostsBody 驗證 comment --yes 送出 body。 +func TestIssuesCommentPostsBody(t *testing.T) { + var gotPath, gotBody string + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + buf := make([]byte, 512) + n, _ := r.Body.Read(buf) + gotPath, gotBody = r.URL.Path, string(buf[:n]) + fmt.Fprint(w, `{"body":"留言","created_at":"t","user":{"login":"alex"}}`) + }) + _, _, code := run("issues", "comment", "--repo", "alterminal/teai", "--body", "留言", "--yes", "8") + if code != 0 { + t.Fatalf("comment --yes 應回 0，得到 %d", code) + } + if !strings.HasSuffix(gotPath, "/issues/8/comments") || !strings.Contains(gotBody, `"body":"留言"`) { + t.Errorf("應 POST comments 端點帶 body，得到 %s %s", gotPath, gotBody) + } +} + +// TestExtractGlobalsAllowsCommandFlags 驗證命令旗標與全域選項可交錯。 +func TestExtractGlobalsAllowsCommandFlags(t *testing.T) { + run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) { + fmt.Fprint(w, `{"login":"alex"}`) + }) + stdout, _, code := run("whoami", "--output", "table") + if code != 0 { + t.Fatalf("whoami --output table 應回 0，得到 %d", code) + } + if !strings.Contains(stdout, "alex") { + t.Errorf("table 輸出應含 alex，得到：%s", stdout) + } +} diff --git a/internal/cli/workflow_commands.go b/internal/cli/workflow_commands.go index 8a69ccb..2fcd8cb 100644 --- a/internal/cli/workflow_commands.go +++ b/internal/cli/workflow_commands.go @@ -23,7 +23,8 @@ func init() { register(&command{name: "orgs", usage: "我所屬的組織", run: runOrgs}) register(&command{name: "members", usage: "Agents 團隊成員；--has-work 只列有未完成工作者", run: runMembers}) register(&command{name: "mine", usage: "分派給我、待跟進的 issues", run: runMine}) - register(&command{name: "pulls", usage: "跨倉庫 PR 跟進清單（--mine／--reviewer／--repo）", run: runPulls}) + // pulls 由 dailyops_commands.go 註冊（#8）：無子命令時走本檔的 runPulls + // 工作流清單，有子命令（list/view/create/merge/comment）走日常操作。 register(&command{name: "next", usage: "下一件該做的事", run: runNext}) } diff --git a/internal/dailyops/dailyops.go b/internal/dailyops/dailyops.go new file mode 100644 index 0000000..ece6ceb --- /dev/null +++ b/internal/dailyops/dailyops.go @@ -0,0 +1,384 @@ +// Package dailyops 實作 tea 對等的日常操作（#8）：issues、pulls、labels、 +// milestones、releases、repos 的讀寫，直接以 Gitea API 為準。 +// +// 讀寫行為對照 Gitea 1.27 API（issues 端點帶 type=issues 排除 PR， +// 見 gitea.py 的注意事項）；寫入的「--yes 閘門」在 CLI 層（見 +// dailyops_commands.go），本套件只負責 API 呼叫。 +package dailyops + +import ( + "context" + "fmt" + "net/url" + "strconv" + + "gitea.alterminal.com/alterminal/teai/internal/gitea" +) + +// User 是 API 回應中的使用者精簡欄位。 +type User struct { + UserName string `json:"login"` +} + +// Name 回傳帳號名。 +func (u *User) Name() string { + if u == nil { + return "" + } + return u.UserName +} + +// Issue 是 Gitea issue／PR 共用端點的精簡欄位（PR 亦走 issues 端點）。 +type Issue struct { + Number int64 `json:"number"` + Title string `json:"title"` + State string `json:"state"` + Body string `json:"body"` + HTMLURL string `json:"html_url"` + UpdatedAt string `json:"updated_at"` + User *User `json:"user"` + Assignees []*User `json:"assignees"` + Labels []Label `json:"labels"` + Assignee []string `json:"-"` // 輸出用：帳號清單（由 Assignees 導出） +} + +// Author 回傳建立者帳號。 +func (i *Issue) Author() string { return i.User.Name() } + +// AssigneeNames 回傳 assignees 帳號清單（輸出用）。 +func (i *Issue) AssigneeNames() []string { + names := make([]string, 0, len(i.Assignees)) + for _, a := range i.Assignees { + if n := a.Name(); n != "" { + names = append(names, n) + } + } + return names +} + +// LabelNames 回傳標籤名稱清單（輸出用）。 +func (i *Issue) LabelNames() []string { + names := make([]string, 0, len(i.Labels)) + for _, l := range i.Labels { + names = append(names, l.Name) + } + return names +} + +// Label 是倉庫標籤。 +type Label struct { + ID int64 `json:"id"` + Name string `json:"name"` + Color string `json:"color"` + Description string `json:"description"` +} + +// Milestone 是倉庫里程碑。 +type Milestone struct { + ID int64 `json:"id"` + Title string `json:"title"` + Description string `json:"description"` + State string `json:"state"` + DueOn string `json:"due_on"` +} + +// Release 是倉庫發佈。 +type Release struct { + TagName string `json:"tag_name"` + Name string `json:"name"` + Draft bool `json:"draft"` + Prerelease bool `json:"prerelease"` + CreatedAt string `json:"created_at"` + PublishedAt string `json:"published_at"` + HTMLURL string `json:"html_url"` +} + +// Comment 是 issue／PR 留言。 +type Comment struct { + Body string `json:"body"` + CreatedAt string `json:"created_at"` + User *User `json:"user"` +} + +// Author 回串留言者帳號。 +func (c *Comment) Author() string { return c.User.Name() } + +// Pull 是 pull request 的精簡欄位。 +type Pull struct { + Number int64 `json:"number"` + Title string `json:"title"` + State string `json:"state"` + Body string `json:"body"` + HTMLURL string `json:"html_url"` + UpdatedAt string `json:"updated_at"` + User *User `json:"user"` + Head *pullRef `json:"head"` + Base *pullRef `json:"base"` +} + +// pullRef 是 PR 的 head／base 參照。 +type pullRef struct { + Ref string `json:"ref"` + Repo *struct { + FullName string `json:"full_name"` + } `json:"repo"` +} + +// HeadRef 回傳 head 分支名（輸出用）。 +func (p *Pull) HeadRef() string { + if p.Head == nil { + return "" + } + return p.Head.Ref +} + +// BaseRef 回傳 base 分支名（輸出用）。 +func (p *Pull) BaseRef() string { + if p.Base == nil { + return "" + } + return p.Base.Ref +} + +// Author 回傳 PR 作者帳號。 +func (p *Pull) Author() string { return p.User.Name() } + +// Repo 是倉庫的精簡欄位。 +type Repo struct { + FullName string `json:"full_name"` + Description string `json:"description"` + Private bool `json:"private"` + Empty bool `json:"empty"` + UpdatedAt string `json:"updated_at"` + HTMLURL string `json:"html_url"` +} + +// Ops 聚合日常操作的 API 呼叫。 +type Ops struct { + // Client 是 Gitea API 用戶端（internal/gitea）。 + Client *gitea.Client +} + +// repoPath 組出 /repos/{owner}/{repo} 前綴；owner／repo 皆做路徑跳脫。 +func repoPath(owner, repo string) string { + return "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) +} + +// ListIssues 列出倉庫 issues。state：open｜closed｜all（預設 open）； +// type=issues 排除 PR（Gitea 的 issues 端點會連 PR 一起回）。 +func (o *Ops) ListIssues(ctx context.Context, owner, repo, state string) ([]Issue, error) { + if state == "" { + state = "open" + } + extra := url.Values{} + if state != "all" { + extra.Set("state", state) + } + // type=issues：排除 PR（PR 在此端點帶 pull_request 欄位）。 + extra.Set("type", "issues") + var issues []Issue + if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/issues", gitea.ListOptions{Extra: extra}, &issues); err != nil { + return nil, err + } + return issues, nil +} + +// CreateIssue 建立 issue；assignees 可為空。 +func (o *Ops) CreateIssue(ctx context.Context, owner, repo, title, body string, assignees []string) (*Issue, error) { + payload := map[string]any{ + "title": title, + "body": body, + } + if len(assignees) > 0 { + payload["assignees"] = assignees + } + var issue Issue + if err := o.Client.DoJSON(ctx, "POST", repoPath(owner, repo)+"/issues", "", payload, &issue); err != nil { + return nil, err + } + return &issue, nil +} + +// GetIssue 取得單一 issue（含 PR，但此處供 issues view 用）。 +func (o *Ops) GetIssue(ctx context.Context, owner, repo string, number int64) (*Issue, error) { + var issue Issue + path := repoPath(owner, repo) + "/issues/" + strconv.FormatInt(number, 10) + if err := o.Client.GetJSON(ctx, path, &issue); err != nil { + return nil, err + } + return &issue, nil +} + +// SetIssueState 變更 issue 狀態（open｜closed）。 +func (o *Ops) SetIssueState(ctx context.Context, owner, repo string, number int64, state string) (*Issue, error) { + payload := map[string]any{"state": state} + var issue Issue + path := repoPath(owner, repo) + "/issues/" + strconv.FormatInt(number, 10) + if err := o.Client.DoJSON(ctx, "PATCH", path, "", payload, &issue); err != nil { + return nil, err + } + return &issue, nil +} + +// ListComments 列出 issue／PR 的留言（PR 亦走 issues 端點）。 +func (o *Ops) ListComments(ctx context.Context, owner, repo string, number int64) ([]Comment, error) { + var comments []Comment + path := repoPath(owner, repo) + "/issues/" + strconv.FormatInt(number, 10) + "/comments" + if err := o.Client.ListAll(ctx, path, gitea.ListOptions{}, &comments); err != nil { + return nil, err + } + return comments, nil +} + +// AddComment 對 issue／PR 留言。 +func (o *Ops) AddComment(ctx context.Context, owner, repo string, number int64, body string) (*Comment, error) { + payload := map[string]any{"body": body} + var comment Comment + path := repoPath(owner, repo) + "/issues/" + strconv.FormatInt(number, 10) + "/comments" + if err := o.Client.DoJSON(ctx, "POST", path, "", payload, &comment); err != nil { + return nil, err + } + return &comment, nil +} + +// ListPulls 列出倉庫 PR；state 預設 open。 +func (o *Ops) ListPulls(ctx context.Context, owner, repo, state string) ([]Pull, error) { + if state == "" { + state = "open" + } + extra := url.Values{} + if state != "all" { + extra.Set("state", state) + } + var pulls []Pull + if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/pulls", gitea.ListOptions{Extra: extra}, &pulls); err != nil { + return nil, err + } + return pulls, nil +} + +// GetPull 取得單一 PR。 +func (o *Ops) GetPull(ctx context.Context, owner, repo string, number int64) (*Pull, error) { + var pull Pull + path := repoPath(owner, repo) + "/pulls/" + strconv.FormatInt(number, 10) + if err := o.Client.GetJSON(ctx, path, &pull); err != nil { + return nil, err + } + return &pull, nil +} + +// CreatePull 建立 PR。 +func (o *Ops) CreatePull(ctx context.Context, owner, repo, title, body, head, base string) (*Pull, error) { + payload := map[string]any{ + "title": title, + "body": body, + "head": head, + "base": base, + } + var pull Pull + if err := o.Client.DoJSON(ctx, "POST", repoPath(owner, repo)+"/pulls", "", payload, &pull); err != nil { + return nil, err + } + return &pull, nil +} + +// MergePull 合併 PR。style：merge｜rebase｜rebase-merge｜squash（預設 merge）。 +func (o *Ops) MergePull(ctx context.Context, owner, repo string, number int64, style string) error { + if style == "" { + style = "merge" + } + payload := map[string]any{"Do": style} + path := repoPath(owner, repo) + "/pulls/" + strconv.FormatInt(number, 10) + "/merge" + return o.Client.DoJSON(ctx, "POST", path, "", payload, nil) +} + +// ListLabels 列出倉庫標籤。 +func (o *Ops) ListLabels(ctx context.Context, owner, repo string) ([]Label, error) { + var labels []Label + if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/labels", gitea.ListOptions{}, &labels); err != nil { + return nil, err + } + return labels, nil +} + +// CreateLabel 建立標籤；color 格式如 #ffffff。 +func (o *Ops) CreateLabel(ctx context.Context, owner, repo, name, color, description string) (*Label, error) { + payload := map[string]any{ + "name": name, + "color": color, + "description": description, + } + var label Label + if err := o.Client.DoJSON(ctx, "POST", repoPath(owner, repo)+"/labels", "", payload, &label); err != nil { + return nil, err + } + return &label, nil +} + +// ListMilestones 列出倉庫里程碑；state 預設 open（可用 all）。 +func (o *Ops) ListMilestones(ctx context.Context, owner, repo, state string) ([]Milestone, error) { + if state == "" { + state = "open" + } + extra := url.Values{} + if state != "all" { + extra.Set("state", state) + } + var ms []Milestone + if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/milestones", gitea.ListOptions{Extra: extra}, &ms); err != nil { + return nil, err + } + return ms, nil +} + +// CreateMilestone 建立里程碑；dueOn 可空（RFC3339）。 +func (o *Ops) CreateMilestone(ctx context.Context, owner, repo, title, description, dueOn string) (*Milestone, error) { + payload := map[string]any{ + "title": title, + "description": description, + } + if dueOn != "" { + payload["due_on"] = dueOn + } + var m Milestone + if err := o.Client.DoJSON(ctx, "POST", repoPath(owner, repo)+"/milestones", "", payload, &m); err != nil { + return nil, err + } + return &m, nil +} + +// ListReleases 列出倉庫發佈。 +func (o *Ops) ListReleases(ctx context.Context, owner, repo string) ([]Release, error) { + var releases []Release + if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/releases", gitea.ListOptions{}, &releases); err != nil { + return nil, err + } + return releases, nil +} + +// ListMyRepos 列出自己可存取的倉庫。 +func (o *Ops) ListMyRepos(ctx context.Context) ([]Repo, error) { + var repos []Repo + if err := o.Client.ListAll(ctx, "/user/repos", gitea.ListOptions{}, &repos); err != nil { + return nil, err + } + return repos, nil +} + +// ListOrgRepos 列出組織倉庫。 +func (o *Ops) ListOrgRepos(ctx context.Context, org string) ([]Repo, error) { + var repos []Repo + if err := o.Client.ListAll(ctx, "/orgs/"+url.PathEscape(org)+"/repos", gitea.ListOptions{}, &repos); err != nil { + return nil, err + } + return repos, nil +} + +// CallAPIDirect 是 teai api 的原樣傳遞：以指定動詞呼叫 path（相對 /api/v1）， +// data 為原樣 JSON（可為 nil）。回傳原始回應位元組。 +func (o *Ops) CallAPIDirect(ctx context.Context, method, path, rawQuery string, data []byte) ([]byte, error) { + if path == "" || path[0] != '/' { + return nil, fmt.Errorf("api path 必須以 / 開頭（相對 api/v1）") + } + return o.Client.DoRaw(ctx, method, path, rawQuery, data) +} diff --git a/internal/gitea/client.go b/internal/gitea/client.go index 0f8af58..d5fd402 100644 --- a/internal/gitea/client.go +++ b/internal/gitea/client.go @@ -7,6 +7,7 @@ package gitea import ( + "bytes" "context" "encoding/json" "fmt" @@ -79,36 +80,80 @@ const MaxLimit = 50 // getJSON 對 path（相對 baseURL，以 / 開頭）發 GET，把 JSON 回應解到 out。 // 失敗時回傳 *ErrAPI。rawQuery 為組好的查詢字串（見 ListOptions.query）。 func (c *Client) getJSON(ctx context.Context, path, rawQuery string, out any) error { + _, err := c.do(ctx, http.MethodGet, path, rawQuery, "", nil, out) + return err +} + +// DoJSON 對 path 發 method 請求（POST/PATCH/PUT/DELETE…），body 為可 JSON +// 化的值（nil 表示不帶 body），2xx 時把回應解到 out（out 非 nil 且回應 +// 有內容時）。供寫入類操作（issues create、pulls merge…）使用。 +func (c *Client) DoJSON(ctx context.Context, method, path, rawQuery string, body any, out any) error { + var payload []byte + if body != nil { + b, err := json.Marshal(body) + if err != nil { + return fmt.Errorf("gitea: marshal request body: %w", err) + } + payload = b + } + _, err := c.do(ctx, method, path, rawQuery, "application/json", payload, out) + return err +} + +// DoRaw 以原樣 body 送出請求並回傳原始回應內容（teai api 用）。 +// 非 2xx 回 *ErrAPI。 +func (c *Client) DoRaw(ctx context.Context, method, path, rawQuery string, body []byte) ([]byte, error) { + contentType := "" + if body != nil { + contentType = "application/json" + } + return c.do(ctx, method, path, rawQuery, contentType, body, nil) +} + +// do 是所有請求的共同核心：組 URL、帶認證表頭、送出、檢查狀態碼、 +// 解析回應。2xx 時回傳原始回應位元組；out 非 nil 時另解到 out。 +// 錯誤訊息不含 token 或回應內容。 +func (c *Client) do(ctx context.Context, method, path, rawQuery, contentType string, payload []byte, out any) ([]byte, error) { u := *c.baseURL u.Path += path u.RawQuery = rawQuery - op := "GET " + u.Path + op := method + " " + u.Path - req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil) + var body io.Reader + if payload != nil { + body = bytes.NewReader(payload) + } + req, err := http.NewRequestWithContext(ctx, method, u.String(), body) if err != nil { - return &ErrAPI{Op: op, Err: err} + return nil, &ErrAPI{Op: op, Err: err} } req.Header.Set("Accept", "application/json") + if payload != nil && contentType != "" { + req.Header.Set("Content-Type", contentType) + } if c.token != "" { req.Header.Set("Authorization", "token "+c.token) } resp, err := c.hc.Do(req) if err != nil { - return &ErrAPI{Op: op, Err: err} + return nil, &ErrAPI{Op: op, Err: err} } defer resp.Body.Close() if resp.StatusCode < 200 || resp.StatusCode > 299 { // 把內容讀掉再丟棄，讓連線可重用；錯誤訊息不含回應內容。 _, _ = io.Copy(io.Discard, io.LimitReader(resp.Body, 4096)) - return &ErrAPI{Op: op, StatusCode: resp.StatusCode} + return nil, &ErrAPI{Op: op, StatusCode: resp.StatusCode} } - if out == nil { - return nil + data, err := io.ReadAll(resp.Body) + if err != nil { + return nil, &ErrAPI{Op: op, Err: err} } - if err := json.NewDecoder(resp.Body).Decode(out); err != nil { - return &ErrAPI{Op: op, Err: fmt.Errorf("decode response: %w", err)} + if out != nil && len(data) > 0 { + if err := json.Unmarshal(data, out); err != nil { + return nil, &ErrAPI{Op: op, Err: fmt.Errorf("decode response: %w", err)} + } } - return nil + return data, nil } // GetJSON 是 getJSON 的公開介面，供非清單端點（如 /user）使用。 -- 2.54.0