Compare commits

...
Author SHA1 Message Date
chenyunda218 744e7ad809 milestones:新增跨倉庫里程碑總覽命令(#31)
- teai milestones(不帶 --repo)輸出跨所屬組織各倉庫 open 里程碑概況,
  對應 gitea.py milestones(管理者巡邏,agents AGENTS.md 10.1):
  欄位 repo/id/title/url/open_issues/closed_issues/due_on/due_hours/
  overdue/unassigned/updated_at,排序期限近者在前、無期限最後。
- internal/workflow.MilestoneOverview:判定核心(Source 注入、離線可測);
  MilestoneEntry 自訂 MarshalJSON,鍵集鍵序與 gitea.py 全等
  (null 表示、due_hours 定點一位、unassigned PR 條目帶 author)。
- internal/workflow.APIClient 增 OpenMilestones/MilestoneOpenIssues
  (issues 端點刻意不帶 type=issues,PR 條目保留供覆蓋檢查,同 gitea.py)。
- milestones --repo a/b 維持現行單倉庫 list 語義不變。
- 空清單輸出 [](gitea.py 無輸出;#26 慣例差異,README 已文件化)。
- 交叉驗證:同帳號同時跑 gitea.py milestones 與 teai milestones,
  含逾期/未到期/無期限里程碑與未分派 issue/PR 條目,輸出位元組全等。
2026-09-10 21:20:19 +08:00
chenyunda218 fd3b8cbd6b Merge pull request 'docs:已知輸出差異補 mine/pulls 欄位集差異(#26)' (#27) from docs/issue26-output-fieldset-diff into main
Reviewed-on: #27
2026-09-10 18:51:29 +08:00
queena 3a587f60ad Merge pull request 'internal/cli:允許命令旗標與位置參數交錯(#25)' (#28) from fix/issue25-interleaved-flags into main 2026-09-10 15:38:37 +08:00
alex 3ed20b6aba internal/cli:允許命令旗標與位置參數交錯(#25)
parseFlags 改為先分離旗標與位置參數、再剖析旗標串、最後以第二次
Parse 把位置參數設回 fs.Args;Go 標準 flag 遇位置參數即停止的問題
不再影響「位置參數在前、旗標在後」的用法(teai api --method、
issues/pulls view --comments 等照 README 範例可用了)。

- login.go/workflow_commands.go 直接呼叫 fs.Parse 的六處改走
  parseFlags,行為一致(login default/remove 的名稱也可與旗標交錯)。
- errHelp(命令 -h/--help)在 exitCodeFor 視為成功,與其既有註解
  宣稱一致;命令層 -h 結束碼由 1/2 修正為 0。
- 新增 interleaved_flags_test.go 回歸測試:api/issues view/
  pulls view/stalled/login default/login remove 的交錯組合。
2026-09-10 15:35:16 +08:00
ceo 3d555e38d9 docs:已知輸出差異補 mine/pulls 欄位集差異(#26)
gitea.py 的 mine/pulls 輸出完整 API 物件是 _dump 直接傾倒的副作用,
欄位集隨 Gitea 版本浮動;teai 維持策展摘要欄位(機器可讀優先),
交叉驗證比對項目集合與判定語義,不逐欄位比對。判定 #26。
2026-09-10 15:24:09 +08:00
alex ffae335e62 Merge pull request 'internal/cli:stalled 與 xrefs 命令接線,完成 #7 CLI 層(堆疊於 #23)' (#24) from feat/issue7-cli-stalled-xrefs into main 2026-09-10 12:30:10 +08:00
ceo ab94cdce9f internal/cli:stalled 與 xrefs 命令接線,完成 #7 CLI 層(堆疊於 #23)
- workflow 新增 StalledSource 介面(Source+CurrentUser+GetIssue)與
  高階入口 RunStalled/ResolveIssueXrefs(xrefs 輸出附 source 出處)
- APIClient 補上 StalledSource 面向(GetIssue/TryGetIssue 等)
- CLI 新增 teai stalled [--hours N](JSON 與 gitea.py 位元組相容:
  停用 HTML 轉義、縮排 2)與 teai xrefs <owner>/<repo> <number>
  (404 → exit 3);table 模式 stalled_hours 定點一位小數
- 接線層與 workflow 層單元測試(注入假資料源、固定時刻)
- README 狀態行更新

驗證:go build/vet/test 全綠;對真實 API 並行掃描,stalled 輸出
與 gitea.py 位元組一致(2169 bytes);xrefs 邊界案例(PR#50/
issue#49 略過、CJK 緊鄰、跨倉庫 owner/repo#N)與 Python 版一致。
2026-09-10 12:20:39 +08:00
chenyunda218 32c3b30934 Merge pull request 'internal/workflow:統一型別宣告,修復 main 編譯失敗(#21)' (#23) from fix/issue21-workflow-types into main
Reviewed-on: #23
2026-09-10 11:45:39 +08:00
ceo 5f323a685e 合併 main(47056dd)保持 #23 分支最新 2026-09-10 11:41:49 +08:00
ceo 4582dfaa4e internal/workflow:統一型別宣告,修復 #12 合併後 main 編譯失敗(#21)
#12 的 workflow.go 與 #13 的 types.go 各自宣告 User/Comment/Issue/
PullRequest/Repository,文字合併無衝突但語意衝突,main 自 a8c1f3e 起
go build 失敗。

統一採 #13 的字串模型(types.go 為唯一型別來源):
- Issue/Comment 補 State/Body/ClosedAt 欄位,新增 parseMoment
  (對應 gitea.py _parse_iso8601;保留原時區偏移,輸出與 Python
  isoformat 位元組一致)
- workflow.go 移除重複宣告,stalled/xref 邏輯改用該模型與 judge.go
  既有輔助(AssigneeNames/ReviewerNames/LastComment/containsString)
- Source 介面 number 改 int64(與 types.go 對齊),cmd/xcheck 同步
- workflow_test.go 測試資料改新型別模型(字串時刻、指標欄位)

驗證:
- go build/go vet/go test ./... 全綠(#6 與 #7 案例皆未回歸)
- xcheck 對真實 API 並行掃描,stalled 輸出與 gitea.py 位元組一致(含
  bear-cli#9 父追蹤項子項摘要、+08:00 時區偏移)
- xref 邊界案例(nope#9/PR#50 略過、bear-cli#9 內嵌解析)與 Python 一致
2026-09-10 11:32:40 +08:00
alex 47056dda43 Merge pull request 'docs:README 補上完整安裝指南(#15)' (#22) from docs/issue15-install-guide into main 2026-09-10 11:26:25 +08:00
ceo 9948357f52 docs:README 補上完整安裝指南(#15) 2026-09-10 10:48:12 +08:00
alex 0b0c3cefcb Merge pull request 'internal/cli:命令保留旗標機制,修正 login add 旗標被全域剖析搶走(#18)' (#20) from fix/issue18-reserved-flags into main 2026-09-10 10:37:20 +08:00
max 0ed6f262c8 合併 main(4a34def)並把 exitcode_test.go 四處 extractGlobals 呼叫補上第三參數 nil(#20) 2026-09-10 10:32:53 +08:00
max fb2990dc04 Merge remote-tracking branch 'origin/main' into fix/issue18-reserved-flags 2026-09-10 10:32:19 +08:00
max c4fb641094 internal/cli:命令保留旗標機制,login add 的 --url/--token 不再被全域剖析搶走(#18) 2026-09-10 10:22:39 +08:00
19 changed files with 2213 additions and 248 deletions
+88 -3
View File
@@ -6,17 +6,52 @@ teai 是 Gitea 的命令列(CLI)工具,以更完整、更可靠的方式
- **語言:** Go(與 Gitea 本體一致),僅用標準庫,離線可建置 - **語言:** Go(與 Gitea 本體一致),僅用標準庫,離線可建置
- **目標站點:** `https://gitea.alterminal.com` - **目標站點:** `https://gitea.alterminal.com`
- **狀態:** 基礎建設(#5:internal/gitea)、工作流命令(#6:whoami/orgs/members/mine/pulls/next)與日常操作命令(#8:issues/pulls/labels/milestones/releases/repos/api)已實作;stalled/xrefs(#7)進行中 - **狀態:** 基礎建設(#5:internal/gitea)、工作流命令(#6:whoami/orgs/members/mine/pulls/next)、日常操作命令(#8:issues/pulls/labels/milestones/releases/repos/api)與管理者巡邏命令(#7:stalled/xrefs)已實作
- **範圍(#3):** 不避開 tea 已有的功能;單一工具涵蓋完整操作 - **範圍(#3):** 不避開 tea 已有的功能;單一工具涵蓋完整操作
## 安裝與建置 ## 安裝與建置
需要 Go 1.26 以上。 ### 需求
- **Go 1.26 以上**(`go version` 確認;本倉庫僅用標準庫,離線可建置)
- **git**
- Gitea 帳號的 **API token**(設定階段使用;在 Gitea「設定 → 應用程式」產生)
### 從原始碼建置
```sh ```sh
git clone https://gitea.alterminal.com/alterminal/teai.git
cd teai
go build -o teai ./cmd/teai go build -o teai ./cmd/teai
install -Dm755 teai ~/.local/bin/teai # 或複製到任何 PATH 內目錄
teai version # 驗證:teai version 0.1.0-dev
``` ```
也可以直接裝進 `GOBIN`(預設 `~/go/bin`;該目錄已在 PATH 時最省事):
```sh
go install ./cmd/teai
```
> **注意:** `go install gitea.alterminal.com/alterminal/teai/cmd/teai@latest` 目前**不可用**——
> module 尚未發佈任何 tag,`@latest` 會解析到任意中繼 commit(且 #21 修復前 main 建置失敗)。
> 請在 clone 目錄內以版本控制的方式建置;發佈 tag 後再提供 `teai@<version>` 安裝路徑。
### 登入設定(首次使用)
teai 與 `tea` 共用同一份組態檔;若 `tea whoami` 已可正常輸出,可跳過本節。
```sh
teai login add --url https://gitea.alterminal.com
# 未給 --token 時自 stdin 讀一行:貼上 token 後按 Enter(不會進 shell 歷史)
teai whoami # 驗證:應輸出 {"username":"<你的帳號>"}
```
- token 驗證失敗(HTTP 401)不會寫入組態,結束碼 3。
- 組態檔:`--config`/`TEA_CONFIG` 指定,預設 `~/.config/tea/config.yml`;teai 採行級編輯,
不會改壞 tea 也在使用的欄位,檔案權限 `0600`。
- 多站台以 `--name` 區分、`teai login default <名稱>` 切換預設;詳見下方 [`teai login`](#teai-login--管理登入) 一節。
## 指令設計 ## 指令設計
> 工作流規則的唯一來源是 [`alterminal/agents`](https://gitea.alterminal.com/alterminal/agents) 的 `AGENTS.md`; > 工作流規則的唯一來源是 [`alterminal/agents`](https://gitea.alterminal.com/alterminal/agents) 的 `AGENTS.md`;
@@ -51,6 +86,8 @@ teai pulls comment --repo <owner>/<repo> --body … --yes <number>
# labels/milestones/releases/repos # labels/milestones/releases/repos
teai labels list --repo <owner>/<repo> teai labels list --repo <owner>/<repo>
teai labels create --repo <owner>/<repo> --name … [--color #RRGGBB] [--description …] --yes teai labels create --repo <owner>/<repo> --name … [--color #RRGGBB] [--description …] --yes
teai milestones # 跨倉庫 open 里程碑總覽(gitea.py milestones 對應;期限近者在前)
teai milestones --repo <owner>/<repo> # 同 milestones list(單倉庫,維持既有語義)
teai milestones list --repo <owner>/<repo> [--state open|closed|all] teai milestones list --repo <owner>/<repo> [--state open|closed|all]
teai milestones create --repo <owner>/<repo> --title … [--description …] [--due RFC3339] --yes teai milestones create --repo <owner>/<repo> --title … [--description …] [--due RFC3339] --yes
teai releases list --repo <owner>/<repo> teai releases list --repo <owner>/<repo>
@@ -172,6 +209,47 @@ PR 改帶 `author` 與 `reviewers` 欄位。`reason` 取值:
- issue:`no-assignee`、`assignee-idle`、`no-commenter`、`waiting-outside`、`parent-tracking` - issue:`no-assignee`、`assignee-idle`、`no-commenter`、`waiting-outside`、`parent-tracking`
- PR:`no-reviewer`、`author-idle`、`reviewer-idle`、`no-commenter` - PR:`no-reviewer`、`author-idle`、`reviewer-idle`、`no-commenter`
### `teai milestones` — 跨倉庫里程碑總覽
```sh
teai milestones # 各倉庫 open 里程碑概況(跨所屬組織;期限近者在前)
teai milestones --output table
```
管理者巡邏用(`gitea.py milestones` 對應,agents AGENTS.md 10.1)。帶 `--repo` 時
維持現行單倉庫 `list` 語義(`teai milestones --repo a/b` = `teai milestones list --repo a/b`)。
每筆欄位(鍵集鍵序與 `gitea.py` 全等,實測位元組一致):
```json
{
"repo": "alterminal/test",
"id": 6,
"title": "xcheck31-ms-overdue",
"url": "https://gitea.alterminal.com/alterminal/test/milestone/6",
"open_issues": 2,
"closed_issues": 0,
"due_on": "2026-09-08T08:00:00+08:00",
"due_hours": 61.3,
"overdue": true,
"unassigned": [
{
"type": "issue",
"number": 14,
"title": "…",
"url": "https://gitea.alterminal.com/alterminal/test/issues/14"
}
],
"updated_at": "2026-09-10T21:17:37+08:00"
}
```
- **排序**:`due_on` 近者在前;無期限者最後(`gitea.py` 的 `(due_on is None, due_on)` 鍵)。
- **`overdue`/`due_hours`**:期限已過為 `true`(`due_hours` 正數);無期限 → `null`。
- **`unassigned`**:該里程碑 open 條目(issue 與 PR)中無 assignee 者的摘要;PR 條目另帶 `author`。
- **`updated_at`**:里程碑本身與其 open 條目 `updated_at` 的最大值(判斷活躍度用)。
- 空輸出 → `[]`(`gitea.py` 無輸出;依 #26 慣例差異)。
### `teai members [--has-work]` ### `teai members [--has-work]`
```sh ```sh
@@ -231,6 +309,7 @@ teai whoami # 目前帳號(讀 tea 組態)
| --- | --- | --- | | --- | --- | --- |
| `next` | `teai next` | 相同:author-PR → reviewer-PR → issue,最久未更新優先 | | `next` | `teai next` | 相同:author-PR → reviewer-PR → issue,最久未更新優先 |
| `stalled [--hours N]` | `teai stalled [--hours N]` | 相同,含 xref 父子追蹤與冷卻 | | `stalled [--hours N]` | `teai stalled [--hours N]` | 相同,含 xref 父子追蹤與冷卻 |
| `milestones` | `teai milestones` | 相同:跨倉庫 open 里程碑總覽,期限近者在前(#31) |
| `members [--has-work]` | `teai members [--has-work]` | 相同 | | `members [--has-work]` | `teai members [--has-work]` | 相同 |
| `pulls`/`pulls --mine`/`pulls --reviewer` | `teai pulls [--mine\|--reviewer]` | 相同 | | `pulls`/`pulls --mine`/`pulls --reviewer` | `teai pulls [--mine\|--reviewer]` | 相同 |
| `mine` | `teai mine` | 相同 | | `mine` | `teai mine` | 相同 |
@@ -239,8 +318,14 @@ teai whoami # 目前帳號(讀 tea 組態)
已知輸出差異(刻意保留,機器可讀優先): 已知輸出差異(刻意保留,機器可讀優先):
- **空清單**:`gitea.py` 的 `_dump` 對空清單**不輸出任何內容**;teai 的清單類命令 - **空清單**:`gitea.py` 的 `_dump` 對空清單**不輸出任何內容**;teai 的清單類命令
(`mine`/`pulls`)空清單輸出 `[]`。對 JSON 消費者來說 `[]` 比「無輸出」更明確, (`mine`/`pulls`/`milestones` 總覽)空清單輸出 `[]`。對 JSON 消費者來說 `[]` 比「無輸出」更明確,
交叉驗證時以此差異為準。`next` 兩者語義相同(無工作 → `null`/「沒有未完成的工作」)。 交叉驗證時以此差異為準。`next` 兩者語義相同(無工作 → `null`/「沒有未完成的工作」)。
- **清單欄位集(`mine`/`pulls`)**:`gitea.py` 直接傾倒完整 Gitea API 物件
(`_dump` 的副作用,欄位集隨 Gitea 版本浮動);teai 輸出策展摘要欄位
(`mine`:repo/number/title/url;`pulls`:number/title/state/author/
head/base/updated_at…依命令定義)。交叉驗證比對**項目集合**(列出哪些
issue/PR)與判定語義,不逐欄位比對;`next`/`stalled`/`milestones` 總覽
兩者為策展欄位且鍵集鍵序全等,可逐欄位比對(#31 實測位元組一致)。判定 #26(維持摘要、文件化差異)。
- **全域選項位置**:teai 的全域選項(`--output` 等)可出現在命令之前或之後, - **全域選項位置**:teai 的全域選項(`--output` 等)可出現在命令之前或之後,
且可與命令旗標交錯(`teai members --has-work --output table`); 且可與命令旗標交錯(`teai members --has-work --output table`);
gitea.py 的旗標剖析較寬鬆,兩者命令列介面以此行為對齊。 gitea.py 的旗標剖析較寬鬆,兩者命令列介面以此行為對齊。
+4 -4
View File
@@ -132,8 +132,8 @@ func (s *apiSource) MyOrganizations() ([]string, error) {
return names, nil return names, nil
} }
func (s *apiSource) OrganizationRepositories(org string) ([]workflow.Repository, error) { func (s *apiSource) OrganizationRepositories(org string) ([]workflow.Repo, error) {
var repos []workflow.Repository var repos []workflow.Repo
if err := s.listAll("orgs/"+org+"/repos", nil, &repos); err != nil { if err := s.listAll("orgs/"+org+"/repos", nil, &repos); err != nil {
return nil, err return nil, err
} }
@@ -157,7 +157,7 @@ func (s *apiSource) OpenPulls(owner, repo string) ([]workflow.PullRequest, error
return pulls, nil return pulls, nil
} }
func (s *apiSource) IssueComments(owner, repo string, number int) ([]workflow.Comment, error) { func (s *apiSource) IssueComments(owner, repo string, number int64) ([]workflow.Comment, error) {
var comments []workflow.Comment var comments []workflow.Comment
if err := s.listAll(fmt.Sprintf("repos/%s/%s/issues/%d/comments", owner, repo, number), nil, &comments); err != nil { if err := s.listAll(fmt.Sprintf("repos/%s/%s/issues/%d/comments", owner, repo, number), nil, &comments); err != nil {
return nil, err return nil, err
@@ -165,7 +165,7 @@ func (s *apiSource) IssueComments(owner, repo string, number int) ([]workflow.Co
return comments, nil return comments, nil
} }
func (s *apiSource) TryGetIssue(owner, repo string, number int) (workflow.Issue, bool, error) { func (s *apiSource) TryGetIssue(owner, repo string, number int64) (workflow.Issue, bool, error) {
var issue workflow.Issue var issue workflow.Issue
body, code, err := s.get(fmt.Sprintf("repos/%s/%s/issues/%d", owner, repo, number), nil) body, code, err := s.get(fmt.Sprintf("repos/%s/%s/issues/%d", owner, repo, number), nil)
if err != nil { if err != nil {
+95 -7
View File
@@ -150,10 +150,31 @@ var globalFlags = map[string]bool{
"--timeout": true, "--timeout": true,
} }
// reservedFlags 回傳 dispatch 不得搶走的旗標名稱(含 -- 前綴):這些
// 旗標屬於目前命令(或其子命令),即使與全域選項同名也必須原樣留給
// 命令剖析。目前唯一與全域同名的是 login add 的 --url/--token
// (README「teai login add --url … --token …」)。其餘命令的旗標
// (--repo、--has-work、--mine……)本來就不在 globalFlags 內,不受影響。
func reservedFlags(name string) map[string]bool {
reserved := make(map[string]bool)
for _, f := range commandReservedFlags[name] {
reserved[f] = true
}
return reserved
}
// commandReservedFlags 登記每個命令「與全域選項同名」的自有旗標。
// 命令旗標優先留給命令;新命令有同姓旗標時在這裡登記(#18)。
var commandReservedFlags = map[string][]string{
"login": {"--url", "--token"},
}
// extractGlobals 從 args 中「抽取」全域選項(可出現在命令之後、與命令 // extractGlobals 從 args 中「抽取」全域選項(可出現在命令之後、與命令
// 旗標交錯),其餘引數依原順序保留給子命令剖析。未知的選項一律留給 // 旗標交錯),其餘引數依原順序保留給子命令剖析。未知的選項一律留給
// 子命令處理(可能是命令旗標,如 --has-work),不在這裡報錯。 // 子命令處理(可能是命令旗標,如 --has-work),不在這裡報錯。
func extractGlobals(g *Globals, args []string) ([]string, error) { // reserved 是目前命令保留的旗標名稱(含 -- 前綴,見 reservedFlags):
// 列於其中的選項即使與全域同名也原樣留給命令,命令旗標優先(#18)。
func extractGlobals(g *Globals, args []string, reserved map[string]bool) ([]string, error) {
rest := make([]string, 0, len(args)) rest := make([]string, 0, len(args))
applyGlobal := func(name, value string) error { applyGlobal := func(name, value string) error {
switch name { switch name {
@@ -197,6 +218,17 @@ func extractGlobals(g *Globals, args []string) ([]string, error) {
continue continue
} }
name, inline, hasInline := strings.Cut(arg, "=") name, inline, hasInline := strings.Cut(arg, "=")
if reserved[name] {
// 命令保留旗標:即使與全域選項同名也留給命令剖析(#18)。
rest = append(rest, arg)
if !hasInline && i+1 < len(args) {
// 旗標值跟在下一個引數;一併保留,不當成全域值。
rest = append(rest, args[i+1])
i++
}
i++
continue
}
_, ok := globalFlags[name] _, ok := globalFlags[name]
if !ok { if !ok {
// 不是全域選項:留給子命令(可能是 --has-work 這類命令旗標)。 // 不是全域選項:留給子命令(可能是 --has-work 這類命令旗標)。
@@ -293,11 +325,12 @@ func parseGlobals(g *Globals, args []string) ([]string, error) {
// 旗標剖析交由各命令自行處理(不同命令有不同旗標,如 pulls --mine); // 旗標剖析交由各命令自行處理(不同命令有不同旗標,如 pulls --mine);
// 全域選項允許出現在命令之後(README 範例:teai next --output table), // 全域選項允許出現在命令之後(README 範例:teai next --output table),
// dispatch 先從 args 剝離全域選項併入 Globals,其餘(含命令自己的旗標, // dispatch 先從 args 剝離全域選項併入 Globals,其餘(含命令自己的旗標,
// 如 --has-work)原樣交給命令,不會誤判為未知全域選項。 // 如 --has-work)原樣交給命令,不會誤判為未知全域選項。與全域選項
// 同名的命令旗標(登記於 commandReservedFlags)優先留給命令(#18)。
func dispatch(env *Env, name string, args []string) int { func dispatch(env *Env, name string, args []string) int {
cmd := commands[name] cmd := commands[name]
g := env.Globals g := env.Globals
rest, err := extractGlobals(&g, args) rest, err := extractGlobals(&g, args, reservedFlags(name))
if err != nil { if err != nil {
fmt.Fprintf(env.Err, "teai: %v\n\n", err) fmt.Fprintf(env.Err, "teai: %v\n\n", err)
printUsage(env.Err) printUsage(env.Err)
@@ -315,24 +348,79 @@ func dispatch(env *Env, name string, args []string) int {
// 用法,靜默成功結束即可。 // 用法,靜默成功結束即可。
var errHelp = errors.New("help requested") var errHelp = errors.New("help requested")
// parseFlags 剖析命令旗標:-h/--help 回 errHelp(由 exitCodeFor 視為成功), // parseFlags 剖析命令旗標,允許旗標與位置參數交錯(#25):Go 標準
// 其他剖析錯誤回 ErrUsage。 // flag 在遇到第一個非旗標參數後即停止剖析,其後的旗標會被當成位置
// 參數。做法:先掃描 args 把「旗標(含其值)」與「位置參數」分離成
// 兩串,再以旗標串呼叫 fs.Parse,最後以第二次 Parse 把位置參數設回
// fs.Args(Parse 遇到 "--" 即停止並收下其餘引數,第一次剖析已設好
// 的旗標值不受影響)。
// -h/--help 回 errHelp(由 exitCodeFor 視為成功),其他剖析錯誤回 ErrUsage。
func parseFlags(fs *flag.FlagSet, args []string) error { func parseFlags(fs *flag.FlagSet, args []string) error {
if err := fs.Parse(args); err != nil { var flags, positional []string
for i := 0; i < len(args); i++ {
arg := args[i]
if arg == "--" {
// "--" 之後全部是位置參數(不再剖析旗標;同標準 flag)。
positional = append(positional, args[i+1:]...)
break
}
if len(arg) < 2 || arg[0] != '-' {
positional = append(positional, arg)
continue
}
flags = append(flags, arg)
// 判斷旗標是否需要「下一個引數」當值(布林旗標與 inline
// 形式 --name=value 不需要)。未知或格式錯誤的旗標不消費
// 下一個引數,交給 fs.Parse 產生標準錯誤訊息。
numMinuses := 1
if arg[1] == '-' {
numMinuses = 2
}
name := arg[numMinuses:]
if name == "" || name[0] == '-' || name[0] == '=' {
continue // ---x/--=…:bad flag syntax,由 fs.Parse 報錯
}
flagName, _, hasInline := strings.Cut(name, "=")
if !hasInline {
if fl := fs.Lookup(flagName); fl != nil && !isBoolFlag(fl) && i+1 < len(args) {
i++
flags = append(flags, args[i])
}
}
}
if err := fs.Parse(flags); err != nil {
if errors.Is(err, flag.ErrHelp) { if errors.Is(err, flag.ErrHelp) {
return errHelp return errHelp
} }
return &ErrUsage{Msg: err.Error()} return &ErrUsage{Msg: err.Error()}
} }
if len(positional) > 0 {
if err := fs.Parse(append([]string{"--"}, positional...)); err != nil {
if errors.Is(err, flag.ErrHelp) {
return errHelp
}
return &ErrUsage{Msg: err.Error()}
}
}
return nil return nil
} }
// isBoolFlag 回傳旗標是否為布林型(不需要值;同 flag 包內部判斷)。
func isBoolFlag(fl *flag.Flag) bool {
bf, ok := fl.Value.(interface{ IsBoolFlag() bool })
return ok && bf.IsBoolFlag()
}
// exitCodeFor 把命令錯誤映射到結束碼:用法錯誤 → 2,API 錯誤 → 3, // exitCodeFor 把命令錯誤映射到結束碼:用法錯誤 → 2,API 錯誤 → 3,
// 其他(內部)→ 1。 // 其他(內部)→ 1。errHelp(命令的 -h/--help)視為成功(#25:
// 與 parseFlags 註解宣稱一致,FlagSet 已印出用法說明)。
func exitCodeFor(err error) ExitCode { func exitCodeFor(err error) ExitCode {
if err == nil { if err == nil {
return ExitOK return ExitOK
} }
if err == errHelp {
return ExitOK
}
var usage *ErrUsage var usage *ErrUsage
if errors.As(err, &usage) { if errors.As(err, &usage) {
return ExitUsage return ExitUsage
+31 -4
View File
@@ -26,7 +26,7 @@ func init() {
register(&command{name: "issues", usage: "issues 管理(list/view/create/close/comment)", run: runIssues}) register(&command{name: "issues", usage: "issues 管理(list/view/create/close/comment)", run: runIssues})
register(&command{name: "pulls", usage: "PR 管理(list/view/create/merge/comment;無子命令=工作流清單)", run: runPullsDaily}) register(&command{name: "pulls", usage: "PR 管理(list/view/create/merge/comment;無子命令=工作流清單)", run: runPullsDaily})
register(&command{name: "labels", usage: "標籤管理(list/create)", run: runLabels}) register(&command{name: "labels", usage: "標籤管理(list/create)", run: runLabels})
register(&command{name: "milestones", usage: "里程碑管理(list/create)", run: runMilestones}) register(&command{name: "milestones", usage: "里程碑(跨倉庫總覽;list/create 管理單倉庫)", run: runMilestones})
register(&command{name: "releases", usage: "發佈清單(list)", run: runReleases}) register(&command{name: "releases", usage: "發佈清單(list)", run: runReleases})
register(&command{name: "repos", usage: "倉庫查詢(list)", run: runRepos}) register(&command{name: "repos", usage: "倉庫查詢(list)", run: runRepos})
register(&command{name: "api", usage: "任意 API 呼叫(--method/--data;寫入動詞需 --yes)", run: runAPIDirect}) register(&command{name: "api", usage: "任意 API 呼叫(--method/--data;寫入動詞需 --yes)", run: runAPIDirect})
@@ -650,10 +650,12 @@ func runLabelsCreate(env *Env, args []string) error {
// ---- milestones ---- // ---- milestones ----
// runMilestones:teai milestones list|create … // runMilestones:teai milestones [list|create] …;不帶子命令時輸出
// 跨倉庫里程碑總覽(#31,對應 gitea.py milestones)。帶 --repo 直接
// 跟在 milestones 之後時維持現行單倉庫 list 語義。
func runMilestones(env *Env, args []string) error { func runMilestones(env *Env, args []string) error {
if len(args) == 0 { if len(args) == 0 {
return &ErrUsage{Msg: "milestones 需要子命令:list | create"} return runMilestonesOverview(env)
} }
sub, rest := args[0], args[1:] sub, rest := args[0], args[1:]
switch sub { switch sub {
@@ -662,7 +664,32 @@ func runMilestones(env *Env, args []string) error {
case "create": case "create":
return runMilestonesCreate(env, rest) return runMilestonesCreate(env, rest)
default: default:
return &ErrUsage{Msg: fmt.Sprintf("milestones 未知子命令 %q(可用:list | create)", sub)} if !strings.HasPrefix(sub, "-") {
return &ErrUsage{Msg: fmt.Sprintf("milestones 未知子命令 %q(可用:list | create;或不帶參數輸出跨倉庫總覽)", sub)}
}
// milestones 之後直接跟旗標(非子命令):帶 --repo → 整串轉發,
// 維持現行單倉庫 list 語義(--state 等旗標一併生效);否則為
// 跨倉庫總覽(總覽不接受任何命令旗標,空 FlagSet 讓未知旗標
// 報用法錯誤)。
hasRepo := false
for _, a := range args {
if a == "--repo" || strings.HasPrefix(a, "--repo=") {
hasRepo = true
break
}
}
if hasRepo {
return runMilestonesList(env, args)
}
fs := flag.NewFlagSet("teai milestones", flag.ContinueOnError)
fs.SetOutput(env.Err)
if err := parseFlags(fs, args); err != nil {
return err
}
if fs.NArg() != 0 {
return &ErrUsage{Msg: "milestones 不接受位置參數(子命令:list | create)"}
}
return runMilestonesOverview(env)
} }
} }
+54 -4
View File
@@ -79,7 +79,7 @@ func TestExtractGlobals(t *testing.T) {
"--output", "table", "--output", "table",
"--timeout", "45s", "--timeout", "45s",
"next", "next",
}) }, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
@@ -100,7 +100,7 @@ func TestExtractGlobals(t *testing.T) {
func TestExtractGlobalsAfterCommand(t *testing.T) { func TestExtractGlobalsAfterCommand(t *testing.T) {
// 全域選項出現在命令之後也應抽出(README:teai next --output table)。 // 全域選項出現在命令之後也應抽出(README:teai next --output table)。
g := defaultGlobals() g := defaultGlobals()
rest, err := extractGlobals(&g, []string{"version", "--output", "table"}) rest, err := extractGlobals(&g, []string{"version", "--output", "table"}, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
@@ -124,7 +124,7 @@ func TestExtractGlobalsKeepsCommandFlags(t *testing.T) {
} }
for _, args := range cases { for _, args := range cases {
g := defaultGlobals() g := defaultGlobals()
rest, err := extractGlobals(&g, args) rest, err := extractGlobals(&g, args, nil)
if err != nil { if err != nil {
t.Fatalf("extractGlobals(%v) 不應報錯:%v", args, err) t.Fatalf("extractGlobals(%v) 不應報錯:%v", args, err)
} }
@@ -145,7 +145,7 @@ func TestExtractGlobalsKeepsCommandFlags(t *testing.T) {
func TestExtractGlobalsDoubleDashStops(t *testing.T) { func TestExtractGlobalsDoubleDashStops(t *testing.T) {
g := defaultGlobals() g := defaultGlobals()
rest, err := extractGlobals(&g, []string{"--output", "table", "--", "--url", "x"}) rest, err := extractGlobals(&g, []string{"--output", "table", "--", "--url", "x"}, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
@@ -158,6 +158,56 @@ func TestExtractGlobalsDoubleDashStops(t *testing.T) {
} }
} }
// TestExtractGlobalsReservedFlags 驗證 #18:與全域同名的命令旗標
// (登記於 commandReservedFlags)必須留給命令,其餘全域選項照常抽取。
func TestExtractGlobalsReservedFlags(t *testing.T) {
g := defaultGlobals()
rest, err := extractGlobals(&g, []string{
"add",
"--url", "https://srv.example.com", // login add 自有旗標:保留
"--token=tok", // 同上(inline 形式):保留
"--name", "test-site",
"--output", "table", // 非保留:仍是全域
}, reservedFlags("login"))
if err != nil {
t.Fatal(err)
}
want := []string{"add", "--url", "https://srv.example.com", "--token=tok", "--name", "test-site"}
if len(rest) != len(want) {
t.Fatalf("rest = %v, want %v", rest, want)
}
for i := range want {
if rest[i] != want[i] {
t.Fatalf("rest = %v, want %v", rest, want)
}
}
if g.Output != gitea.FormatTable {
t.Fatalf("output = %v, want table", g.Output)
}
if g.URL != defaultGlobals().URL || g.Token != "" {
t.Fatalf("reserved flags must not leak into globals: %+v", g)
}
}
// TestExtractGlobalsNonReservedCommand 驗證 #13 行為不回歸:未登記保留
// 旗標的命令(如 next/members/pulls),命令後的全域選項照常抽取、
// 命令自己的旗標(--has-work 等)原樣保留。
func TestExtractGlobalsNonReservedCommand(t *testing.T) {
g := defaultGlobals()
rest, err := extractGlobals(&g, []string{
"members", "--has-work", "--output", "table",
}, reservedFlags("members"))
if err != nil {
t.Fatal(err)
}
if len(rest) != 2 || rest[0] != "members" || rest[1] != "--has-work" {
t.Fatalf("rest = %v, want [members --has-work]", rest)
}
if g.Output != gitea.FormatTable {
t.Fatalf("output = %v, want table", g.Output)
}
}
// errString 把字串轉成 error(測試輔助)。 // errString 把字串轉成 error(測試輔助)。
type errStr string type errStr string
+160
View File
@@ -0,0 +1,160 @@
// interleaved_flags_test.go — #25 的回歸測試:命令旗標放在位置參數
// (path/編號/名稱)之後也必須被剖析,不得被當成位置參數。
// 涵蓋 parseFlags 走的命令(issues/pulls view、api、stalled)與
// 原本直接 fs.Parse 的命令(login default/remove、members)。
package cli
import (
"fmt"
"net/http"
"os"
"strings"
"testing"
)
// TestAPIFlagsAfterPath 驗證 #25 重現步驟一:teai api <path> --method POST
// --data '{}' --yes 的旗標在 path 之後仍被剖析(POST 送達伺服器而非 exit 2)。
func TestAPIFlagsAfterPath(t *testing.T) {
var gotMethod string
run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) {
gotMethod = r.Method
fmt.Fprint(w, `{}`)
})
_, _, code := run("api", "/version", "--method", "POST", "--data", `{}`, "--yes")
if code != 0 {
t.Fatalf("api 旗標在 path 之後應回 0(#25),得到 %d", code)
}
if gotMethod != "POST" {
t.Fatalf("應送出 POST,得到 %s", gotMethod)
}
}
// TestIssuesViewCommentsFlagAfterNumber 驗證 #25 重現步驟二:
// teai issues view --repo owner/repo <編號> --comments 的 --comments
// 在編號之後仍生效(有打 /comments 端點)。
func TestIssuesViewCommentsFlagAfterNumber(t *testing.T) {
var commentsHit bool
run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) {
switch {
case strings.HasSuffix(r.URL.Path, "/comments"):
commentsHit = true
fmt.Fprint(w, `[]`)
case strings.HasSuffix(r.URL.Path, "/issues/8"):
fmt.Fprint(w, `{"number":8,"title":"t","state":"open","user":{"login":"ceo"},"body":"","html_url":"u","labels":[],"updated_at":"t"}`)
default:
fmt.Fprint(w, `[]`)
}
})
stdout, _, code := run("issues", "view", "--repo", "alterminal/teai", "8", "--comments")
if code != 0 {
t.Fatalf("issues view 編號在前旗標在後應回 0(#25),得到 %d", code)
}
if !commentsHit {
t.Fatalf("--comments 在編號之後應觸發 /comments 請求;輸出:%s", stdout)
}
}
// TestPullsViewCommentsFlagAfterNumber 同上,驗證 pulls view。
func TestPullsViewCommentsFlagAfterNumber(t *testing.T) {
var commentsHit bool
run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) {
switch {
case strings.HasSuffix(r.URL.Path, "/comments"):
commentsHit = true
fmt.Fprint(w, `[]`)
case strings.HasSuffix(r.URL.Path, "/pulls/13"):
fmt.Fprint(w, `{"number":13,"title":"t","state":"open","user":{"login":"ceo"},"body":"","html_url":"u","labels":[],"updated_at":"t"}`)
default:
fmt.Fprint(w, `[]`)
}
})
_, _, code := run("pulls", "view", "--repo", "alterminal/teai", "13", "--comments")
if code != 0 {
t.Fatalf("pulls view 編號在前旗標在後應回 0(#25),得到 %d", code)
}
if !commentsHit {
t.Fatal("--comments 在編號之後應觸發 /comments 請求")
}
}
// TestStalledHoursFlagAfterPositional 驗證 stalled 即使混入位置參數
// 也不誤剖析:--hours 在位置參數後仍被剖析,而 stalled 本身不接受
// 位置參數 → 應回 2(用法錯誤)而非誤把 --hours 當位置參數。
func TestStalledHoursFlagAfterPositional(t *testing.T) {
run := opsTestServer(t, func(w http.ResponseWriter, r *http.Request) {
fmt.Fprint(w, `[]`)
})
_, stderr, code := run("stalled", "9", "--hours", "3")
if code != 2 {
t.Fatalf("stalled 帶位置參數應回 2,得到 %d", code)
}
if !strings.Contains(stderr, "位置參數") {
t.Fatalf("錯誤訊息應提及位置參數,得到:%s", stderr)
}
// 對照組:--hours 值非法(剖析層錯誤)應回 2,而非把旗標當位置參數。
_, stderr, code = run("stalled", "--hours", "abc")
if code != 2 || !strings.Contains(stderr, "invalid value") {
t.Fatalf("stalled --hours abc 應回 2 且提及 invalid value,得到 %d:%s", code, stderr)
}
// 交錯但無多餘位置參數:--hours 值不會被誤收。
_, stderr, code = run("stalled", "--hours")
if code != 2 || !strings.Contains(stderr, "flag needs an argument") {
t.Fatalf("stalled --hours 缺值應回 2 且提及 flag needs an argument,得到 %d:%s", code, stderr)
}
}
// TestLoginDefaultNameOnly 驗證 login default <名稱>:位置參數在旗標
// 之後(--config 在前)仍正確收取一個名稱。
func TestLoginDefaultNameOnly(t *testing.T) {
cfg := `logins:
- name: a
url: https://a.example.com
token: ta
default: true
- name: b
url: https://b.example.com
token: tb
default: false
`
prefix, _ := loginTestEnv(t, cfg)
stdout, _, code := run(append(prefix, "login", "default", "b")...)
if code != 0 || !strings.Contains(stdout, `"name":"b"`) {
t.Fatalf("login default b 應回 0 並輸出 b:code=%d out=%s", code, stdout)
}
// 多給一個位置參數仍應報用法錯誤(不受交錯支援影響)。
_, stderr, code := run(append(prefix, "login", "default", "b", "c")...)
if code != 2 || !strings.Contains(stderr, "exactly one") {
t.Fatalf("兩個名稱應回 2,得到 %d:%s", code, stderr)
}
}
// TestMemberHelpExitZero 驗證命令的 -h 結束碼為 0(#25 順帶修正:
// errHelp 視為成功)。
func TestMemberHelpExitZero(t *testing.T) {
_, _, code := run("members", "-h")
if code != 0 {
t.Fatalf("members -h 應回 0,得到 %d", code)
}
}
// TestLoginRemoveFlagInterleaved 驗證 login remove <名稱> --yes:
// --yes 在名稱之後仍視為旗標(未帶時走確認流程會讀 stdin)。
func TestLoginRemoveFlagInterleaved(t *testing.T) {
prefix, configPath := loginTestEnv(t, `logins:
- name: a
url: https://a.example.com
token: ta
default: true
`)
old := loginStdin
loginStdin = strings.NewReader("y\n") // 若 --yes 失效會讀到這行
defer func() { loginStdin = old }()
_, _, code := run(append(prefix, "login", "remove", "a", "--yes")...)
if code != 0 {
t.Fatalf("login remove a --yes 應回 0,得到 %d", code)
}
data, _ := os.ReadFile(configPath)
if strings.Contains(string(data), "token: ta") {
t.Fatalf("--yes 在名稱之後應生效(直接刪除):\n%s", data)
}
}
+8 -8
View File
@@ -93,8 +93,8 @@ func printLoginList(env *Env, logins []gitea.LoginEntry) error {
func runLoginList(env *Env, args []string) error { func runLoginList(env *Env, args []string) error {
fs := flag.NewFlagSet("teai login list", flag.ContinueOnError) fs := flag.NewFlagSet("teai login list", flag.ContinueOnError)
fs.SetOutput(env.Err) fs.SetOutput(env.Err)
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() > 0 { if fs.NArg() > 0 {
return &ErrUsage{Msg: fmt.Sprintf("unexpected argument %q", fs.Arg(0))} return &ErrUsage{Msg: fmt.Sprintf("unexpected argument %q", fs.Arg(0))}
@@ -121,8 +121,8 @@ func runLoginAdd(env *Env, args []string) error {
nameFlag := fs.String("name", "", "登入名稱(省略時取 URL 主機)") nameFlag := fs.String("name", "", "登入名稱(省略時取 URL 主機)")
tokenFlag := fs.String("token", "", "API token(省略時自 stdin 讀一行)") tokenFlag := fs.String("token", "", "API token(省略時自 stdin 讀一行)")
defaultFlag := fs.Bool("default", true, "設為預設登入") defaultFlag := fs.Bool("default", true, "設為預設登入")
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() > 0 { if fs.NArg() > 0 {
return &ErrUsage{Msg: fmt.Sprintf("unexpected argument %q", fs.Arg(0))} return &ErrUsage{Msg: fmt.Sprintf("unexpected argument %q", fs.Arg(0))}
@@ -224,8 +224,8 @@ func verifyToken(env *Env, siteURL, token string) (string, error) {
func runLoginDefault(env *Env, args []string) error { func runLoginDefault(env *Env, args []string) error {
fs := flag.NewFlagSet("teai login default", flag.ContinueOnError) fs := flag.NewFlagSet("teai login default", flag.ContinueOnError)
fs.SetOutput(env.Err) fs.SetOutput(env.Err)
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() != 1 { if fs.NArg() != 1 {
return &ErrUsage{Msg: "login default requires exactly one login name"} return &ErrUsage{Msg: "login default requires exactly one login name"}
@@ -255,8 +255,8 @@ func runLoginRemove(env *Env, args []string) error {
fs := flag.NewFlagSet("teai login remove", flag.ContinueOnError) fs := flag.NewFlagSet("teai login remove", flag.ContinueOnError)
fs.SetOutput(env.Err) fs.SetOutput(env.Err)
yesFlag := fs.Bool("yes", false, "跳過確認") yesFlag := fs.Bool("yes", false, "跳過確認")
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() != 1 { if fs.NArg() != 1 {
return &ErrUsage{Msg: "login remove requires exactly one login name"} return &ErrUsage{Msg: "login remove requires exactly one login name"}
+97
View File
@@ -0,0 +1,97 @@
// milestones_commands.go — 跨倉庫里程碑總覽命令的 CLI 接線(#31):
// teai milestones(不帶 --repo)。
//
// 核心邏輯在 internal/workflow(MilestoneOverview),本檔只做旗標
// 剖析、資料源接線與輸出格式化(與 stalled_commands.go 同模式)。
// 輸出與 gitea.py milestones 位元組相容(MilestoneEntry 自訂
// MarshalJSON;縮排 2、停用 HTML 轉義、空清單輸出 [],見 #26 慣例)。
package cli
import (
"fmt"
"time"
"gitea.alterminal.com/alterminal/teai/internal/gitea"
"gitea.alterminal.com/alterminal/teai/internal/workflow"
)
// newMilestoneSourceFunc 建立總覽的資料源;宣告為變數讓接線層測試
// 可注入假資料源(與 newStalledSourceFunc 同模式)。
var newMilestoneSourceFunc = newMilestoneSource
// newMilestoneSource 依全域選項建立 workflow.MilestoneSource(API 實作)。
func newMilestoneSource(env *Env) (workflow.MilestoneSource, error) {
token, _, err := gitea.ResolveToken(gitea.AuthOptions{
FlagToken: env.Globals.Token,
SiteURL: env.Globals.URL,
ConfigPath: env.Globals.ConfigPath,
})
if err != nil {
return nil, err
}
client, err := gitea.New(env.Globals.URL, token, env.Globals.Timeout)
if err != nil {
return nil, err
}
return &workflow.APIClient{Client: client}, nil
}
// milestonesNowFunc 回傳總覽的基準時刻;宣告為變數讓測試可固定時刻。
var milestonesNowFunc = time.Now
// milestoneEntryRow 把 MilestoneEntry 轉成 table 列(unassigned 僅 JSON
// 模式輸出完整摘要;table 給人工抽查用,取計數)。
func milestoneEntryRow(e workflow.MilestoneEntry) gitea.Values {
dueOn := ""
if e.DueOn != nil {
dueOn = *e.DueOn
}
dueHours := ""
if e.DueHours != nil {
dueHours = fmt.Sprintf("%.1f", *e.DueHours)
}
updatedAt := ""
if e.UpdatedAt != nil {
updatedAt = *e.UpdatedAt
}
id := ""
if e.ID != nil {
id = fmt.Sprintf("%d", *e.ID)
}
return gitea.Values{
e.Repo, id, e.Title, e.URL,
e.OpenIssues, e.ClosedIssues, dueOn, dueHours,
e.Overdue, len(e.Unassigned), updatedAt,
}
}
// runMilestonesOverview:teai milestones(跨倉庫總覽)。
// JSON 輸出與 gitea.py milestones 位元組相容;空清單輸出 [](#26 慣例:
// gitea.py 對空清單不輸出,teai 輸出 [] 供 JSON 消費者明確判斷)。
func runMilestonesOverview(env *Env) error {
src, err := newMilestoneSourceFunc(env)
if err != nil {
return err
}
entries, err := workflow.MilestoneOverview(src, env.Globals.URL, milestonesNowFunc())
if err != nil {
return err
}
p := printer(env)
if p.Format == gitea.FormatTable {
rows := make([]gitea.Values, 0, len(entries))
for i := range entries {
rows = append(rows, milestoneEntryRow(entries[i]))
}
return p.PrintList([]gitea.Field{
{Name: "repo"}, {Name: "id"}, {Name: "title"}, {Name: "url"},
{Name: "open_issues"}, {Name: "closed_issues"}, {Name: "due_on"},
{Name: "due_hours"}, {Name: "overdue"}, {Name: "unassigned"}, {Name: "updated_at"},
}, rows)
}
if len(entries) == 0 {
_, err := fmt.Fprintln(env.Out, "[]")
return err
}
return printJSON(env.Out, entries)
}
+188
View File
@@ -0,0 +1,188 @@
// milestones_commands_test.go — 跨倉庫里程碑總覽的 CLI 接線層測試(#31):
// 注入假 MilestoneSource,驗證 Run→dispatch→輸出完整路徑,不走網路
// (與 stalled_commands_test.go 同模式)。
package cli
import (
"encoding/json"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
"gitea.alterminal.com/alterminal/teai/internal/workflow"
)
// stubMilestoneSource 以記憶體資料實作 workflow.MilestoneSource。
type stubMilestoneSource struct {
orgs []string
repos map[string][]workflow.Repo
milestones map[string][]workflow.Milestone
openIssues map[string][]workflow.Issue // key: owner/repo?milestone=<title>
}
func (s *stubMilestoneSource) MyOrganizations() ([]string, error) { return s.orgs, nil }
func (s *stubMilestoneSource) OrganizationRepositories(org string) ([]workflow.Repo, error) {
return s.repos[org], nil
}
func (s *stubMilestoneSource) OpenMilestones(owner, repo string) ([]workflow.Milestone, error) {
return s.milestones[owner+"/"+repo], nil
}
func (s *stubMilestoneSource) MilestoneOpenIssues(owner, repo, title string) ([]workflow.Issue, error) {
return s.openIssues[owner+"/"+repo+"?milestone="+title], nil
}
// newStubMilestoneEnv 注入假資料源並固定時刻。
func newStubMilestoneEnv(t *testing.T, src *stubMilestoneSource, frozen time.Time) {
t.Helper()
origSrc, origNow := newMilestoneSourceFunc, milestonesNowFunc
newMilestoneSourceFunc = func(env *Env) (workflow.MilestoneSource, error) { return src, nil }
milestonesNowFunc = func() time.Time { return frozen }
t.Cleanup(func() {
newMilestoneSourceFunc, milestonesNowFunc = origSrc, origNow
})
}
// stubPullIssue 以 JSON 建構帶 pull_request 標記的條目(pullMarker 未匯出,
// 測試從套件外以 API 回應的形狀建構,走 Issue.UnmarshalJSON 同一路徑)。
func stubPullIssue(t *testing.T) workflow.Issue {
t.Helper()
var issue workflow.Issue
err := json.Unmarshal([]byte(`{
"number": 32, "title": "文件", "state": "open",
"updated_at": "2026-09-08T00:00:00Z",
"html_url": "https://gitea.alterminal.com/alterminal/agents/pulls/32",
"user": {"username": "alex"},
"pull_request": {}
}`), &issue)
if err != nil {
t.Fatalf("建構 stub PR 條目失敗:%v", err)
}
return issue
}
// idPtr/msPtr 是測試用指標 helper(workflow 套件內同名函式未匯出)。
func idPtr(i int64) *int64 { return &i }
func msPtr(s string) *string { return &s }
// newStubMilestoneData 建構總覽情境:兩倉庫各一里程碑、一個未分派 PR。
func newStubMilestoneData(t *testing.T) *stubMilestoneSource {
due := "2026-09-09T00:00:00Z"
return &stubMilestoneSource{
orgs: []string{"alterminal"},
repos: map[string][]workflow.Repo{"alterminal": {
{Name: "agents"}, {Name: "teai"},
}},
milestones: map[string][]workflow.Milestone{
"alterminal/agents": {
{ID: idPtr(7), Title: "MVP", State: "open",
DueOn: &due, UpdatedAt: "2026-09-01T00:00:00Z",
OpenIssues: 1, ClosedIssues: 0},
},
"alterminal/teai": {
{ID: idPtr(3), Title: "CLI", State: "open",
DueOn: msPtr("2026-09-12T00:00:00Z"), UpdatedAt: "2026-09-05T00:00:00Z",
OpenIssues: 1, ClosedIssues: 2},
},
},
openIssues: map[string][]workflow.Issue{
"alterminal/agents?milestone=MVP": {stubPullIssue(t)},
},
}
}
// TestWiringMilestonesOverview 驗證 teai milestones 輸出跨倉庫總覽
// (JSON 縮排 2、鍵序與欄位齊 gitea.py)。
func TestWiringMilestonesOverview(t *testing.T) {
newStubMilestoneEnv(t, newStubMilestoneData(t), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("milestones")
if code != 0 {
t.Fatalf("milestones 應回 0,得到 %d(stdout=%q)", code, stdout)
}
for _, want := range []string{
`"repo": "alterminal/agents"`,
`"title": "MVP"`,
`"overdue": true`,
`"type": "pull"`,
`"author": "alex"`,
} {
if !strings.Contains(stdout, want) {
t.Fatalf("milestones 輸出應含 %q,得到:\n%s", want, stdout)
}
}
// 排序:agents MVP(09-09)在 teai CLI(09-12)前。
if strings.Index(stdout, `"title": "MVP"`) > strings.Index(stdout, `"title": "CLI"`) {
t.Fatalf("期限近者應在前:\n%s", stdout)
}
}
// TestWiringMilestonesEmpty 驗證無里程碑 → [](#26 慣例)。
func TestWiringMilestonesEmpty(t *testing.T) {
newStubMilestoneEnv(t, &stubMilestoneSource{
orgs: []string{"alterminal"},
repos: map[string][]workflow.Repo{"alterminal": {{Name: "agents"}}},
milestones: map[string][]workflow.Milestone{},
openIssues: map[string][]workflow.Issue{},
}, time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("milestones")
if code != 0 {
t.Fatalf("milestones 空清單應回 0,得到 %d", code)
}
if strings.TrimSpace(stdout) != "[]" {
t.Fatalf("無里程碑應輸出 [],得到 %q", stdout)
}
}
// TestWiringMilestonesTable 驗證 table 輸出(人工抽查用)。
func TestWiringMilestonesTable(t *testing.T) {
newStubMilestoneEnv(t, newStubMilestoneData(t), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("milestones", "--output", "table")
if code != 0 {
t.Fatalf("milestones --output table 應回 0,得到 %d", code)
}
for _, want := range []string{"repo", "overdue", "MVP", "alterminal/agents"} {
if !strings.Contains(stdout, want) {
t.Fatalf("table 輸出應含 %q,得到:\n%s", want, stdout)
}
}
}
// TestWiringMilestonesRepoFlagCompat 驗證 teai milestones --repo a/b
// 維持現行單倉庫 list 語義(#31:帶 --repo 時不變)。
func TestWiringMilestonesRepoFlagCompat(t *testing.T) {
var gotPath, gotQuery string
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
gotPath, gotQuery = r.URL.Path, r.URL.RawQuery
w.Write([]byte(`[{"title":"v1","state":"open","description":"","due_on":""}]`))
}))
t.Cleanup(srv.Close)
stdout, _, code := run("--url", srv.URL, "milestones", "--repo", "a/b")
if code != 0 {
t.Fatalf("milestones --repo a/b 應回 0,得到 %d", code)
}
if gotPath != "/api/v1/repos/a/b/milestones" {
t.Fatalf("應呼叫 /repos/a/b/milestones,得到 %s", gotPath)
}
if !strings.Contains(gotQuery, "state=open") {
t.Fatalf("查詢應含 state=open,得到 %q", gotQuery)
}
if !strings.Contains(stdout, `"title":"v1"`) {
t.Fatalf("輸出應含 title v1,得到:%s", stdout)
}
}
// TestWiringMilestonesUsage 驗證未知子命令與位置參數 → exit 2。
func TestWiringMilestonesUsage(t *testing.T) {
newStubMilestoneEnv(t, newStubMilestoneData(t), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
if _, _, code := run("milestones", "bogus"); code != int(ExitUsage) {
t.Fatalf("milestones bogus 應回 ExitUsage,得到 %d", code)
}
if _, _, code := run("milestones", "extra", "arg"); code != int(ExitUsage) {
t.Fatalf("milestones 位置參數應回 ExitUsage,得到 %d", code)
}
// milestones list 仍照舊要求 --repo。
if _, _, code := run("milestones", "list"); code != int(ExitUsage) {
t.Fatalf("milestones list 缺 --repo 應回 ExitUsage,得到 %d", code)
}
}
+170
View File
@@ -0,0 +1,170 @@
// stalled_commands.go — 管理者巡邏命令的 CLI 接線(#7):
// stalled [--hours N] 與 xrefs <owner>/<repo> <number>。
//
// 核心邏輯在 internal/workflow(ScanStalled/ResolveIssueXrefs),
// 本檔只做旗標剖析、資料源接線與輸出格式化。輸出走得體架構的
// Printer(--output json|table);錯誤經 cli.exitCodeFor 映射結束碼
// (用法 2/API 3)。token 解析選序見 internal/gitea/auth.go。
package cli
import (
"encoding/json"
"flag"
"fmt"
"io"
"strconv"
"time"
"gitea.alterminal.com/alterminal/teai/internal/gitea"
"gitea.alterminal.com/alterminal/teai/internal/workflow"
)
func init() {
commands["stalled"] = &command{
name: "stalled",
usage: "停滯的 open issues/PR(管理者巡邏;--hours N 門檻,預設 4)",
run: runStalled,
}
commands["xrefs"] = &command{
name: "xrefs",
usage: "解析 issue/PR 內文與留言中的 #N/repo#N/owner/repo#N 引用",
run: runXrefs,
}
}
// newStalledSourceFunc 建立 stalled/xrefs 的資料源;宣告為變數讓
// 接線層測試可注入假資料源(不走網路),與 newScannerFunc 同模式。
var newStalledSourceFunc = newStalledSource
// newStalledSource 依全域選項建立 workflow.StalledSource(API 實作)。
func newStalledSource(env *Env) (workflow.StalledSource, error) {
token, _, err := gitea.ResolveToken(gitea.AuthOptions{
FlagToken: env.Globals.Token,
SiteURL: env.Globals.URL,
ConfigPath: env.Globals.ConfigPath,
})
if err != nil {
return nil, err
}
client, err := gitea.New(env.Globals.URL, token, env.Globals.Timeout)
if err != nil {
return nil, err
}
return &workflow.APIClient{Client: client}, nil
}
// stalledFields 是 stalled 的 table 欄位(JSON 模式輸出完整 Item,
// 欄位序與 gitea.py 一致,見 workflow.Item.MarshalJSON)。
func stalledFields() []gitea.Field {
return []gitea.Field{
{Name: "type"}, {Name: "repo"}, {Name: "number"}, {Name: "title"},
{Name: "last_comment_by"}, {Name: "last_activity_at"},
{Name: "stalled_hours"}, {Name: "reason"},
}
}
// stalledRow 把 Item 轉成 table 列(assignees/reviewers/child_activity
// 僅 JSON 模式輸出;table 給人工抽查用,取共同欄位)。
// stalled_hours 定點一位小數(fmt.Sprint(9.0) 會印 "9",與 JSON 的 9.0 不一致)。
func stalledRow(item workflow.Item) gitea.Values {
return gitea.Values{
item.Type, item.Repo, item.Number, item.Title,
item.LastCommentBy, workflow.FormatMoment(item.LastActivityAt),
strconv.FormatFloat(item.StalledHours, 'f', 1, 64), item.Reason,
}
}
// runStalled:teai stalled [--hours N]。
// 預設門檻 4 小時;--hours 需為正數(同 gitea.py _parse_hours)。
// JSON 輸出與 gitea.py stalled 位元組相容(workflow.Item 自訂 MarshalJSON;
// 這裡輸出前停用 HTML 轉義並縮排 2,對應 Python json.dumps(indent=2))。
func runStalled(env *Env, args []string) error {
fs := flag.NewFlagSet("teai stalled", flag.ContinueOnError)
fs.SetOutput(env.Err)
hours := fs.Float64("hours", workflow.StalledDefaultHours, "停滯門檻(小時,正數)")
if err := parseFlags(fs, args); err != nil {
return err
}
if fs.NArg() != 0 {
return &ErrUsage{Msg: "stalled 不接受位置參數"}
}
if *hours <= 0 {
return &ErrUsage{Msg: "--hours 需為正數(小時),例如 --hours 4"}
}
src, err := newStalledSourceFunc(env)
if err != nil {
return err
}
items, err := workflow.RunStalled(src, *hours, nowFunc())
if err != nil {
return err
}
p := printer(env)
if p.Format == gitea.FormatTable {
rows := make([]gitea.Values, 0, len(items))
for _, item := range items {
rows = append(rows, stalledRow(item))
}
return p.PrintList(stalledFields(), rows)
}
// JSON:空清單輸出 [](README:無停滯項目 → 空陣列);有項目時
// 縮排 2 且停用 HTML 轉義,與 gitea.py 的 _dump 位元組相容。
if len(items) == 0 {
_, err := fmt.Fprintln(env.Out, "[]")
return err
}
return printJSON(env.Out, items)
}
// runXrefs:teai xrefs <owner>/<repo> <number>。
// 編號不存在 → API 錯誤(結束碼 3);無引用 → []。
func runXrefs(env *Env, args []string) error {
fs := flag.NewFlagSet("teai xrefs", flag.ContinueOnError)
fs.SetOutput(env.Err)
if err := parseFlags(fs, args); err != nil {
return err
}
if fs.NArg() != 2 {
return &ErrUsage{Msg: "xrefs 需要 <owner>/<repo> <number> 兩個參數"}
}
owner, name, err := splitRepoFlag(args[0])
if err != nil {
return err
}
number, err := strconv.ParseInt(args[1], 10, 64)
if err != nil || number <= 0 {
return &ErrUsage{Msg: fmt.Sprintf("編號需為正整數,得到 %q", args[1])}
}
src, err := newStalledSourceFunc(env)
if err != nil {
return err
}
hits, err := workflow.ResolveIssueXrefs(src, owner, name, number)
if err != nil {
return err
}
p := printer(env)
rows := make([]gitea.Values, 0, len(hits))
for _, h := range hits {
rows = append(rows, gitea.Values{h.Owner, h.Repo, h.Number, h.Source})
}
return p.PrintList(
[]gitea.Field{
{Name: "owner"}, {Name: "repo"}, {Name: "number"}, {Name: "source"},
},
rows,
)
}
// nowFunc 回傳目前時刻;宣告為變數讓測試可固定時刻(stalled 判定用)。
var nowFunc = time.Now
// printJSON 以縮排 2、停用 HTML 轉義輸出 JSON(與 gitea.py 的
// json.dumps(ensure_ascii=False, indent=2) 位元組相容;HTML 轉義會把
// <、>、& 變 \u003c 等,破壞相容性)。
func printJSON(w io.Writer, v any) error {
enc := json.NewEncoder(w)
enc.SetEscapeHTML(false)
enc.SetIndent("", " ")
return enc.Encode(v)
}
+227
View File
@@ -0,0 +1,227 @@
// stalled_commands_test.go — stalled/xrefs CLI 接線層測試(#7):
// 注入假 StalledSource,驗證 Run→dispatch→flagset 完整路徑,
// 不走網路(與 workflow_commands_test.go 同模式)。
package cli
import (
"strings"
"testing"
"time"
"gitea.alterminal.com/alterminal/teai/internal/gitea"
"gitea.alterminal.com/alterminal/teai/internal/workflow"
)
// stubStalledSource 以記憶體資料實作 workflow.StalledSource。
type stubStalledSource struct {
username string
orgs []string
repos map[string][]workflow.Repo
issues map[string]map[int64]workflow.Issue
comments map[string][]workflow.Comment
getErr error
}
func (s *stubStalledSource) CurrentUser() (string, error) { return s.username, nil }
func (s *stubStalledSource) MyOrganizations() ([]string, error) {
return s.orgs, nil
}
func (s *stubStalledSource) OrganizationRepositories(org string) ([]workflow.Repo, error) {
return s.repos[org], nil
}
func (s *stubStalledSource) OpenIssues(owner, repo string) ([]workflow.Issue, error) {
var out []workflow.Issue
for _, i := range s.issues[owner+"/"+repo] {
out = append(out, i)
}
return out, nil
}
func (s *stubStalledSource) OpenPulls(owner, repo string) ([]workflow.PullRequest, error) {
return nil, nil
}
func (s *stubStalledSource) IssueComments(owner, repo string, number int64) ([]workflow.Comment, error) {
return s.comments[owner+"/"+repo+"/"+itoa(number)], nil
}
func (s *stubStalledSource) TryGetIssue(owner, repo string, number int64) (workflow.Issue, bool, error) {
i, ok := s.issues[owner+"/"+repo][number]
return i, ok, nil
}
func (s *stubStalledSource) GetIssue(owner, repo string, number int64) (workflow.Issue, error) {
if s.getErr != nil {
return workflow.Issue{}, s.getErr
}
i, ok := s.issues[owner+"/"+repo][number]
if !ok {
return workflow.Issue{}, &gitea.ErrAPI{Op: "GET /repos/" + owner + "/" + repo + "/issues/" + itoa(number), StatusCode: 404}
}
return i, nil
}
func itoa(n int64) string {
if n == 0 {
return "0"
}
var b []byte
for n > 0 {
b = append([]byte{byte('0' + n%10)}, b...)
n /= 10
}
return string(b)
}
// newStubStalledEnv 注入假資料源並固定時刻。
func newStubStalledEnv(t *testing.T, src *stubStalledSource, frozen time.Time) {
t.Helper()
origSrc, origNow := newStalledSourceFunc, nowFunc
newStalledSourceFunc = func(env *Env) (workflow.StalledSource, error) { return src, nil }
nowFunc = func() time.Time { return frozen }
t.Cleanup(func() { newStalledSourceFunc, nowFunc = origSrc, origNow })
}
// isoAt 把相對分鐘轉成 ISO8601 字串(假資料用;錨點同 workflow 測試)。
func isoAt(minutes int) string {
return workflow.FormatMoment(time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC).Add(time.Duration(minutes) * time.Minute))
}
// newStubStalledData 建構 stalled 情境:agents#1 停滯 10 小時(no-assignee)。
func newStubStalledData() *stubStalledSource {
return &stubStalledSource{
username: "ceo",
orgs: []string{"alterminal"},
repos: map[string][]workflow.Repo{"alterminal": {{Name: "agents"}}},
issues: map[string]map[int64]workflow.Issue{
"alterminal/agents": {
1: {Number: 1, Title: "停滯項", State: "open",
CreatedAt: isoAt(-600), UpdatedAt: isoAt(-600),
Repository: &workflow.Repository{FullName: "alterminal/agents"}},
},
},
comments: map[string][]workflow.Comment{},
}
}
// TestWiringStalled 驗證 stalled 基本路徑:JSON 輸出含停滯欄位。
func TestWiringStalled(t *testing.T) {
newStubStalledEnv(t, newStubStalledData(), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("stalled")
if code != 0 {
t.Fatalf("stalled 應回 0,得到 %d(stdout=%q)", code, stdout)
}
for _, want := range []string{`"type": "issue"`, `"reason": "no-assignee"`, `"stalled_hours": 10.0`} {
if !strings.Contains(stdout, want) {
t.Fatalf("stalled 輸出應含 %q,得到:\n%s", want, stdout)
}
}
}
// TestWiringStalledHoursFlag 驗證 --hours 覆寫門檻與非正數被攔。
func TestWiringStalledHoursFlag(t *testing.T) {
freeze := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
newStubStalledEnv(t, newStubStalledData(), freeze)
// 門檻 20h → 10h 停滯未過門檻 → 空陣列。
stdout, _, code := run("stalled", "--hours", "20")
if code != 0 {
t.Fatalf("stalled --hours 20 應回 0,得到 %d", code)
}
if strings.TrimSpace(stdout) != "[]" {
t.Fatalf("無停滯項應輸出 [],得到 %q", stdout)
}
// 非正數 → exit 2。
_, stderr, code := run("stalled", "--hours", "-1")
if code != int(ExitUsage) {
t.Fatalf("stalled --hours -1 應回 ExitUsage(%d),得到 %d(stderr=%q)", int(ExitUsage), code, stderr)
}
// 位置參數 → exit 2。
_, _, code = run("stalled", "extra")
if code != int(ExitUsage) {
t.Fatalf("stalled extra 應回 ExitUsage(%d),得到 %d", int(ExitUsage), code)
}
}
// TestWiringStalledTable 驗證 table 輸出(README 範例)。
func TestWiringStalledTable(t *testing.T) {
newStubStalledEnv(t, newStubStalledData(), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("stalled", "--output", "table")
if code != 0 {
t.Fatalf("stalled --output table 應回 0,得到 %d", code)
}
for _, want := range []string{"reason", "no-assignee", "停滯項"} {
if !strings.Contains(stdout, want) {
t.Fatalf("table 輸出應含 %q,得到:\n%s", want, stdout)
}
}
}
// TestWiringXrefs 驗證 xrefs 解析輸出(含 body/comment 出處)。
func TestWiringXrefs(t *testing.T) {
src := newStubStalledData()
src.issues["alterminal/agents"][1] = workflow.Issue{
Number: 1, Title: "父項", State: "open",
Body: "子項:agents#2",
Repository: &workflow.Repository{FullName: "alterminal/agents"},
}
src.issues["alterminal/agents"][2] = workflow.Issue{
Number: 2, Title: "子項", State: "open",
Repository: &workflow.Repository{FullName: "alterminal/agents"},
}
src.comments["alterminal/agents/1"] = []workflow.Comment{
{Body: "看 agents#2", User: &workflow.User{UserName: "alex"}},
}
newStubStalledEnv(t, src, time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("xrefs", "alterminal/agents", "1")
if code != 0 {
t.Fatalf("xrefs 應回 0,得到 %d(stdout=%q)", code, stdout)
}
// Printer JSON 為單行緊湊格式(無縮排);命令清單類輸出一律如此。
for _, want := range []string{`"repo":"agents"`, `"number":2`, `"source":"body"`} {
if !strings.Contains(stdout, want) {
t.Fatalf("xrefs 輸出應含 %q,得到:\n%s", want, stdout)
}
}
}
// TestWiringXrefsEmpty 驗證無引用 → []。
func TestWiringXrefsEmpty(t *testing.T) {
src := newStubStalledData()
src.issues["alterminal/agents"][1] = workflow.Issue{
Number: 1, Title: "無引用", State: "open",
Body: "沒有任何引用",
Repository: &workflow.Repository{FullName: "alterminal/agents"},
}
newStubStalledEnv(t, src, time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
stdout, _, code := run("xrefs", "alterminal/agents", "1")
if code != 0 {
t.Fatalf("xrefs 應回 0,得到 %d", code)
}
if strings.TrimSpace(stdout) != "[]" {
t.Fatalf("無引用應輸出 [],得到 %q", stdout)
}
}
// TestWiringXrefsUsage 驗證參數不足/格式錯誤 → exit 2。
func TestWiringXrefsUsage(t *testing.T) {
newStubStalledEnv(t, newStubStalledData(), time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
if _, _, code := run("xrefs"); code != int(ExitUsage) {
t.Fatalf("xrefs 無參數應回 ExitUsage,得到 %d", code)
}
if _, _, code := run("xrefs", "alterminal/agents"); code != int(ExitUsage) {
t.Fatalf("xrefs 缺編號應回 ExitUsage,得到 %d", code)
}
if _, _, code := run("xrefs", "not-a-repo", "1"); code != int(ExitUsage) {
t.Fatalf("xrefs repo 格式錯誤應回 ExitUsage,得到 %d", code)
}
if _, _, code := run("xrefs", "alterminal/agents", "abc"); code != int(ExitUsage) {
t.Fatalf("xrefs 編號非數字應回 ExitUsage,得到 %d", code)
}
}
// TestWiringXrefsNotFound 驗證 404 → exit 3(API 錯誤)。
func TestWiringXrefsNotFound(t *testing.T) {
src := newStubStalledData()
src.getErr = &gitea.ErrAPI{Op: "GET /repos/alterminal/agents/issues/99", StatusCode: 404}
newStubStalledEnv(t, src, time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC))
_, stderr, code := run("xrefs", "alterminal/agents", "99")
if code != int(ExitAPI) {
t.Fatalf("xrefs 404 應回 ExitAPI(%d),得到 %d(stderr=%q)", int(ExitAPI), code, stderr)
}
}
+4 -4
View File
@@ -105,8 +105,8 @@ func runMembers(env *Env, args []string) error {
fs := flag.NewFlagSet("teai members", flag.ContinueOnError) fs := flag.NewFlagSet("teai members", flag.ContinueOnError)
fs.SetOutput(env.Err) fs.SetOutput(env.Err)
hasWork := fs.Bool("has-work", false, "只列出有未完成工作的成員") hasWork := fs.Bool("has-work", false, "只列出有未完成工作的成員")
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() != 0 { if fs.NArg() != 0 {
return &ErrUsage{Msg: "members 不接受位置參數"} return &ErrUsage{Msg: "members 不接受位置參數"}
@@ -154,8 +154,8 @@ func runPulls(env *Env, args []string) error {
mine := fs.Bool("mine", false, "限定作者是目前帳號") mine := fs.Bool("mine", false, "限定作者是目前帳號")
reviewer := fs.Bool("reviewer", false, "限定自己是 requested reviewer") reviewer := fs.Bool("reviewer", false, "限定自己是 requested reviewer")
repo := fs.String("repo", "", "限定單一倉庫(owner/repo)") repo := fs.String("repo", "", "限定單一倉庫(owner/repo)")
if err := fs.Parse(args); err != nil { if err := parseFlags(fs, args); err != nil {
return &ErrUsage{Msg: err.Error()} return err
} }
if fs.NArg() != 0 { if fs.NArg() != 0 {
return &ErrUsage{Msg: "pulls 不接受位置參數"} return &ErrUsage{Msg: "pulls 不接受位置參數"}
+87
View File
@@ -122,3 +122,90 @@ func (a *APIClient) ListComments(owner, repo string, number int64) ([]Comment, e
} }
return comments, nil return comments, nil
} }
// ── StalledSource 面向(#7 CLI 接線)────────────────────────────────────
// APIClient 在 Client 之外同時實作 StalledSource(Source + CurrentUser +
// GetIssue),讓 stalled/xrefs 命令與既有命令共用同一個 HTTP 用戶端。
// 清單類方法直接委派 Client 同名操作,語義一致(type=issues、state=open)。
// GetIssue 單一 issue 查詢(PR 亦經此端點,帶 pull_request 標記);
// 失敗(含 404)回 *gitea.ErrAPI,由 CLI 映射結束碼 3。
func (a *APIClient) GetIssue(owner, repo string, number int64) (Issue, error) {
var issue Issue
path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) +
"/issues/" + strconv.FormatInt(number, 10)
if err := a.Client.GetJSON(context.Background(), path, &issue); err != nil {
return Issue{}, err
}
return issue, nil
}
// TryGetIssue 寬容版單一 issue 查詢:失敗(含 404)回 (零值, false, nil),
// 供 stalled 父追蹤項掃描靜默略過不存在的子項(Source 介面契約)。
func (a *APIClient) TryGetIssue(owner, repo string, number int64) (Issue, bool, error) {
issue, err := a.GetIssue(owner, repo, number)
if err != nil {
return Issue{}, false, nil
}
return issue, true, nil
}
// MyOrganizations 委派 ListOrgs(Source 面向)。
func (a *APIClient) MyOrganizations() ([]string, error) { return a.ListOrgs() }
// OrganizationRepositories 委派 ListOrgRepos(Source 面向)。
func (a *APIClient) OrganizationRepositories(org string) ([]Repo, error) {
return a.ListOrgRepos(org)
}
// OpenIssues 委派 ListIssues(Source 面向;已排除 PR)。
func (a *APIClient) OpenIssues(owner, repo string) ([]Issue, error) {
return a.ListIssues(owner, repo)
}
// OpenPulls 委派 ListPulls(Source 面向)。
func (a *APIClient) OpenPulls(owner, repo string) ([]PullRequest, error) {
return a.ListPulls(owner, repo)
}
// IssueComments 委派 ListComments(Source 面向)。
func (a *APIClient) IssueComments(owner, repo string, number int64) ([]Comment, error) {
return a.ListComments(owner, repo, number)
}
// ── MilestoneSource 面向(#31 跨倉庫里程碑總覽)────────────────────────
// APIClient 在 StalledSource 之外另實作 MilestoneSource,讓 milestones
// 總覽命令與既有命令共用同一個 HTTP 用戶端;查詢參數對照 gitea.py 的
// list_open_milestones_for_repository/_milestone_open_issues。
// OpenMilestones 回傳倉庫的 open 里程碑(GET /repos/{o}/{r}/milestones?state=open)。
func (a *APIClient) OpenMilestones(owner, repo string) ([]Milestone, error) {
var ms []Milestone
path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/milestones"
opts := gitea.ListOptions{Extra: url.Values{"state": {"open"}}}
if err := a.Client.ListAll(context.Background(), path, opts, &ms); err != nil {
return nil, err
}
return ms, nil
}
// MilestoneOpenIssues 回傳掛在指定里程碑(依名稱過濾,Gitea 以
// milestones=<title> 查詢)的 open 條目。刻意**不**帶 type=issues——
// PR 亦屬里程碑條目,保留兩者供覆蓋檢查(同 gitea.py
// _milestone_open_issues;PR 帶 pull_request 標記由 workflow 判別)。
func (a *APIClient) MilestoneOpenIssues(owner, repo, milestoneTitle string) ([]Issue, error) {
var issues []Issue
path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/issues"
opts := gitea.ListOptions{Extra: url.Values{
"state": {"open"},
"milestones": {milestoneTitle},
}}
if err := a.Client.ListAll(context.Background(), path, opts, &issues); err != nil {
return nil, err
}
return issues, nil
}
// 編譯期確認 APIClient 同時實作 Client、StalledSource 與 MilestoneSource。
var _ StalledSource = (*APIClient)(nil)
var _ MilestoneSource = (*APIClient)(nil)
+256
View File
@@ -0,0 +1,256 @@
// milestones.go — 跨倉庫里程碑總覽(teai #31;gitea.py milestones 的對應實作)。
//
// 各倉庫 open milestone 概況(管理者巡邏用,agents AGENTS.md 10.1):期限近者
// 在前的排序、逾期判定、未分派條目摘要與活躍度(updated_at 取里程碑本身與
// 其 open 條位的最大值)。判定與輸出規則以 AGENTS.md 為單一來源,行為基準是
// gitea.py 的 list_milestone_overview,本檔只實作、不改義。
package workflow
import (
"fmt"
"sort"
"strconv"
"strings"
"time"
)
// Milestone 是里程碑物件(僅取總覽會用到的欄位)。
// ID 與 DueOn 用指標:Gitea 回 null/缺漏時輸出 null
// (對應 gitea.py milestone.get("id")/get("due_on") 的 None 語義)。
type Milestone struct {
ID *int64 `json:"id"`
Title string `json:"title"`
State string `json:"state"`
DueOn *string `json:"due_on"`
UpdatedAt string `json:"updated_at"`
OpenIssues int64 `json:"open_issues"`
ClosedIssues int64 `json:"closed_issues"`
}
// MilestoneSource 是跨倉庫里程碑總覽需要的資料源(CLI 層以 API 實作;
// 測試注入假資料,與 Source/StalledSource 同模式)。
type MilestoneSource interface {
// MyOrganizations 回傳目前帳號所屬組織清單。
MyOrganizations() ([]string, error)
// OrganizationRepositories 回傳組織的倉庫清單。
OrganizationRepositories(org string) ([]Repo, error)
// OpenMilestones 回傳倉庫的 open 里程碑。
OpenMilestones(owner, repo string) ([]Milestone, error)
// MilestoneOpenIssues 回傳掛在指定里程碑(依名稱過濾)的 open
// issue 與 PR。刻意不設 type 過濾——兩者都保留供覆蓋檢查
//(同 gitea.py _milestone_open_issues 的查詢參數;PR 帶
// pull_request 標記,由本套件判別)。
MilestoneOpenIssues(owner, repo, milestoneTitle string) ([]Issue, error)
}
// UnassignedEntry 是里程碑 open 條目中未分派者的摘要。
type UnassignedEntry struct {
Type string
Number int64
Title string
URL string
// Author 僅 pull 條目輸出(且作者已知時;對應 gitea.py 只在
// _pr_author_username 非空時放 author 鍵)。
Author string
}
// MarshalJSON 輸出鍵集與鍵序與 gitea.py 一致的物件。
func (u UnassignedEntry) MarshalJSON() ([]byte, error) {
var b strings.Builder
b.WriteString(`{"type":`)
writeJSON(&b, u.Type)
b.WriteString(`,"number":`)
fmt.Fprintf(&b, "%d", u.Number)
b.WriteString(`,"title":`)
writeJSON(&b, u.Title)
b.WriteString(`,"url":`)
writeJSON(&b, u.URL)
if u.Author != "" {
b.WriteString(`,"author":`)
writeJSON(&b, u.Author)
}
b.WriteString(`}`)
return []byte(b.String()), nil
}
// MilestoneEntry 是總覽的單筆輸出(欄位對應 gitea.py list_milestone_overview
// 的 dict 鍵序:repo、id、title、url、open_issues、closed_issues、due_on、
// due_hours、overdue、unassigned、updated_at)。
type MilestoneEntry struct {
Repo string
ID *int64
Title string
URL string
OpenIssues int64
ClosedIssues int64
DueOn *string
DueHours *float64
Overdue bool
Unassigned []UnassignedEntry
UpdatedAt *string
}
// MarshalJSON 輸出鍵集與鍵序與 gitea.py 完全一致的物件
// (與 Item/stalled 的做法相同:手寫鍵序,null/浮點格式對齊 Python)。
func (e MilestoneEntry) MarshalJSON() ([]byte, error) {
var b strings.Builder
b.WriteString(`{"repo":`)
writeJSON(&b, e.Repo)
b.WriteString(`,"id":`)
if e.ID != nil {
fmt.Fprintf(&b, "%d", *e.ID)
} else {
b.WriteString("null")
}
b.WriteString(`,"title":`)
writeJSON(&b, e.Title)
b.WriteString(`,"url":`)
writeJSON(&b, e.URL)
b.WriteString(`,"open_issues":`)
fmt.Fprintf(&b, "%d", e.OpenIssues)
b.WriteString(`,"closed_issues":`)
fmt.Fprintf(&b, "%d", e.ClosedIssues)
b.WriteString(`,"due_on":`)
writeJSON(&b, e.DueOn)
b.WriteString(`,"due_hours":`)
if e.DueHours != nil {
// Python round(x, 1) 的 json 輸出是 48.0/10.4(定點一位小數)。
b.WriteString(strconv.FormatFloat(round1(*e.DueHours), 'f', 1, 64))
} else {
b.WriteString("null")
}
b.WriteString(`,"overdue":`)
b.WriteString(strconv.FormatBool(e.Overdue))
b.WriteString(`,"unassigned":`)
writeJSON(&b, e.Unassigned)
b.WriteString(`,"updated_at":`)
writeJSON(&b, e.UpdatedAt)
b.WriteString(`}`)
return []byte(b.String()), nil
}
// MilestoneOverview 收集跨組織各倉庫的 open 里程碑概況,依(due_on,
// 無則視為最遠)由近到遠排序(穩定排序:同 due_on 者保持掃描順序,
// 對應 Python list.sort 的穩定性)。webBase 是站點網址前綴
// (scheme://host),空字串時 url 欄位輸出 ""(同 gitea.py 在
// GITEA_WEB_DOMAIN 缺漏時的行為)。
func MilestoneOverview(src MilestoneSource, webBase string, now time.Time) ([]MilestoneEntry, error) {
orgs, err := src.MyOrganizations()
if err != nil {
return nil, err
}
out := []MilestoneEntry{}
for _, org := range orgs {
repos, err := src.OrganizationRepositories(org)
if err != nil {
return nil, err
}
for _, repo := range repos {
if repo.Name == "" || repo.Empty {
continue
}
ms, err := src.OpenMilestones(org, repo.Name)
if err != nil {
return nil, err
}
for i := range ms {
entry, err := milestoneEntry(src, org, repo.Name, &ms[i], webBase, now)
if err != nil {
return nil, err
}
out = append(out, entry)
}
}
}
// gitea.py 的排序鍵:(due_on is None, due_on or "")——有期限者在前、
// 期限近者在前;無期限者在後。
sort.SliceStable(out, func(a, bb int) bool {
x, y := out[a].DueOn, out[bb].DueOn
if (x == nil) != (y == nil) {
return y == nil
}
if x != nil {
return *x < *y
}
return false
})
return out, nil
}
// milestoneEntry 計算單一里程碑的總覽欄位(對應 gitea.py 迴圈體)。
func milestoneEntry(src MilestoneSource, org, repo string, m *Milestone, webBase string, now time.Time) (MilestoneEntry, error) {
// due_hours/overdue:due_on 缺漏或無法解析 → null/false。
// Python 以未捨入值判定 overdue(round 只作用於輸出),
// 邊界(如 0.04 小時 → overdue=true、due_hours=0.0)保持一致。
var dueHours *float64
overdue := false
if m.DueOn != nil {
if due, ok := parseMoment(*m.DueOn); ok {
raw := now.Sub(due).Hours()
dueHours = &raw
overdue = raw > 0
}
}
openEntries, err := src.MilestoneOpenIssues(org, repo, m.Title)
if err != nil {
return MilestoneEntry{}, err
}
// 未分派條目摘要(assignees 為空者);updated_at 取里程碑本身與
// 各 open 條目 updated_at 的最大值(供巡邏判斷活躍度)。
unassigned := []UnassignedEntry{}
moments := []time.Time{}
if updated, ok := parseMoment(m.UpdatedAt); ok {
moments = append(moments, updated)
}
for i := range openEntries {
entry := &openEntries[i]
if updated, ok := parseMoment(entry.UpdatedAt); ok {
moments = append(moments, updated)
}
if len(AssigneeNames(entry)) > 0 {
continue
}
summary := UnassignedEntry{
Type: "issue",
Number: entry.issueNumber(),
Title: entry.Title,
URL: entry.WebURL(),
}
if entry.PullRequest != nil {
summary.Type = "pull"
if author := entry.User.Name(); author != "" {
summary.Author = author
}
}
unassigned = append(unassigned, summary)
}
var updatedAt *string
if len(moments) > 0 {
s := FormatMoment(maxTime(moments))
updatedAt = &s
}
return MilestoneEntry{
Repo: org + "/" + repo,
ID: m.ID,
Title: m.Title,
URL: milestoneURL(webBase, org, repo, m.ID),
OpenIssues: m.OpenIssues,
ClosedIssues: m.ClosedIssues,
DueOn: m.DueOn,
DueHours: dueHours,
Overdue: overdue,
Unassigned: unassigned,
UpdatedAt: updatedAt,
}, nil
}
// milestoneURL 組里程碑網頁網址;webBase 空或 id 缺漏回 ""
// (對應 gitea.py _milestone_url 的兩個空值條件。Python 原版不做
// URL 跳脫——一般組織/倉庫名皆為安全字元,這裡保持一致以求位元組相容)。
func milestoneURL(webBase, org, repo string, id *int64) string {
if webBase == "" || id == nil {
return ""
}
return strings.TrimRight(webBase, "/") + "/" + org + "/" + repo +
"/milestone/" + strconv.FormatInt(*id, 10)
}
+262
View File
@@ -0,0 +1,262 @@
// milestones_test.go — MilestoneOverview 的單元測試(#31)。
//
// 資料源注入假實作(離線可測);鍵序、null 表示、排序與 overdue
// 判定對照 gitea.py list_milestone_overview 的 Python 語義。
package workflow
import (
"encoding/json"
"strings"
"testing"
"time"
)
// fakeMilestoneSource 以記憶體資料實作 MilestoneSource。
type fakeMilestoneSource struct {
orgs []string
repos map[string][]Repo
milestones map[string][]Milestone
openIssues map[string][]Issue // key: owner/repo?milestone=<title>
}
func (f *fakeMilestoneSource) MyOrganizations() ([]string, error) { return f.orgs, nil }
func (f *fakeMilestoneSource) OrganizationRepositories(org string) ([]Repo, error) {
return f.repos[org], nil
}
func (f *fakeMilestoneSource) OpenMilestones(owner, repo string) ([]Milestone, error) {
return f.milestones[owner+"/"+repo], nil
}
func (f *fakeMilestoneSource) MilestoneOpenIssues(owner, repo, title string) ([]Issue, error) {
return f.openIssues[owner+"/"+repo+"?milestone="+title], nil
}
func msPtr(s string) *string { return &s }
func idPtr(i int64) *int64 { return &i }
// newMilestoneFixture 建構情境:alterminal 兩倉庫、三里程碑
// (teai 有期限將至、agents 有逾期與無期限)。
func newMilestoneFixture() *fakeMilestoneSource {
return &fakeMilestoneSource{
orgs: []string{"alterminal"},
repos: map[string][]Repo{"alterminal": {
{Name: "agents", HasPullRequests: boolPtr(true)},
{Name: "teai", HasPullRequests: boolPtr(true)},
{Name: "empty-repo", Empty: true}, // 空倉庫應跳過
}},
milestones: map[string][]Milestone{
"alterminal/agents": {
{ID: idPtr(7), Title: "MVP", State: "open",
DueOn: msPtr("2026-09-09T00:00:00Z"), UpdatedAt: "2026-09-01T00:00:00Z",
OpenIssues: 3, ClosedIssues: 1},
{ID: idPtr(8), Title: "v1", State: "open",
DueOn: nil, UpdatedAt: "2026-09-02T00:00:00Z",
OpenIssues: 1, ClosedIssues: 0},
},
"alterminal/teai": {
{ID: idPtr(3), Title: "CLI", State: "open",
DueOn: msPtr("2026-09-12T00:00:00Z"), UpdatedAt: "2026-09-05T00:00:00Z",
OpenIssues: 2, ClosedIssues: 5},
},
},
openIssues: map[string][]Issue{
// agents MVP:一個未分派 issue、一個未分派 PR、一個已分派 issue。
"alterminal/agents?milestone=MVP": {
{Number: 31, Title: "總覽命令", State: "open",
UpdatedAt: "2026-09-10T01:00:00Z",
Repository: &Repository{FullName: "alterminal/agents"},
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/31"},
{Number: 32, Title: "文件", State: "open",
UpdatedAt: "2026-09-08T00:00:00Z",
Repository: &Repository{FullName: "alterminal/agents"},
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/pulls/32",
PullRequest: &pullMarker{}, User: &User{UserName: "alex"}},
{Number: 33, Title: "已分派", State: "open",
UpdatedAt: "2026-09-07T00:00:00Z",
Repository: &Repository{FullName: "alterminal/agents"},
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/33",
Assignee: &User{UserName: "queena"}},
},
// agents v1(無期限):條目比里程碑本身新 → updated_at 取條目。
"alterminal/agents?milestone=v1": {
{Number: 40, Title: "無人理", State: "open",
UpdatedAt: "2026-09-09T23:30:00Z",
Repository: &Repository{FullName: "alterminal/agents"},
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/40"},
},
},
}
}
// TestMilestoneOverviewSortAndOverdue 驗證排序(期限近者在前、無期限在後)
// 與 overdue/due_hours 計算。
func TestMilestoneOverviewSortAndOverdue(t *testing.T) {
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
entries, err := MilestoneOverview(newMilestoneFixture(), "https://gitea.alterminal.com", now)
if err != nil {
t.Fatalf("MilestoneOverview: %v", err)
}
if len(entries) != 3 {
t.Fatalf("應有 3 筆(空倉庫跳過),得到 %d", len(entries))
}
// 排序:MVP(2026-09-09,已過期)→ CLI(2026-09-12)→ v1(無期限)。
wantOrder := []string{"alterminal/agents#MVP", "alterminal/teai#CLI", "alterminal/agents#v1"}
for i, want := range wantOrder {
got := entries[i].Repo + "#" + entries[i].Title
if got != want {
t.Errorf("第 %d 筆應為 %s,得到 %s", i, want, got)
}
}
// MVP:due 2026-09-09T00:00Z、now 09-10T08:00Z → 32 小時、逾期。
if !entries[0].Overdue {
t.Errorf("MVP 應逾期")
}
if entries[0].DueHours == nil || *entries[0].DueHours != 32.0 {
t.Errorf("MVP due_hours 應 32.0,得到 %v", entries[0].DueHours)
}
// CLI:未到期。
if entries[1].Overdue {
t.Errorf("CLI 不應逾期")
}
// v1:無期限 → null。
if entries[2].DueOn != nil || entries[2].DueHours != nil || entries[2].Overdue {
t.Errorf("v1 無期限應為 null/false,得到 %+v", entries[2])
}
}
// TestMilestoneOverviewUnassigned 驗證未分派條目摘要(issue 無 author、
// pull 帶 author)與 updated_at 取最大值。
func TestMilestoneOverviewUnassigned(t *testing.T) {
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
entries, err := MilestoneOverview(newMilestoneFixture(), "https://gitea.alterminal.com", now)
if err != nil {
t.Fatalf("MilestoneOverview: %v", err)
}
var mvp *MilestoneEntry
for i := range entries {
if entries[i].Title == "MVP" {
mvp = &entries[i]
}
}
if mvp == nil {
t.Fatalf("找不到 MVP")
}
// 未分派:#31(issue)、#32(PR, author=alex);#33 已分派不列。
if len(mvp.Unassigned) != 2 {
t.Fatalf("MVP 應有 2 筆未分派,得到 %d:%+v", len(mvp.Unassigned), mvp.Unassigned)
}
if mvp.Unassigned[0].Type != "issue" || mvp.Unassigned[0].Number != 31 {
t.Errorf("第一筆未分派應為 issue #31,得到 %+v", mvp.Unassigned[0])
}
if mvp.Unassigned[1].Type != "pull" || mvp.Unassigned[1].Number != 32 || mvp.Unassigned[1].Author != "alex" {
t.Errorf("第二筆未分派應為 pull #32(author=alex),得到 %+v", mvp.Unassigned[1])
}
// updated_at:max(里程碑 09-01, #31 09-10T01:00Z) → 後者。
if mvp.UpdatedAt == nil || *mvp.UpdatedAt != "2026-09-10T01:00:00+00:00" {
t.Errorf("MVP updated_at 應取條目最大值 2026-09-10T01:00:00+00:00,得到 %v", mvp.UpdatedAt)
}
// url 組法。
if mvp.URL != "https://gitea.alterminal.com/alterminal/agents/milestone/7" {
t.Errorf("MVP url 應為 milestone/7,得到 %s", mvp.URL)
}
}
// TestMilestoneOverviewJSONKeys 驗證 JSON 鍵集與鍵序與 gitea.py 一致,
// 以及 null/陣列空表示(unassigned 空 → [])。
func TestMilestoneOverviewJSONKeys(t *testing.T) {
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
entries, err := MilestoneOverview(newMilestoneFixture(), "", now)
if err != nil {
t.Fatalf("MilestoneOverview: %v", err)
}
// v1:無期限、無未分派條目 → due_on/due_hours/updated_at 的 null 表示、
// unassigned=[]、webBase 空 → url=""。
var v1 *MilestoneEntry
for i := range entries {
if entries[i].Title == "v1" {
v1 = &entries[i]
}
}
if v1 == nil {
t.Fatalf("找不到 v1")
}
// 手寫期望 JSON(縮排 2、鍵序照 gitea.py dict 實字序)。
b, err := json.Marshal(v1)
if err != nil {
t.Fatalf("Marshal: %v", err)
}
// 以逐鍵比對為準(MarshalIndent 因自訂 MarshalJSON 不縮排內層)。
var obj map[string]json.RawMessage
if err := json.Unmarshal(b, &obj); err != nil {
t.Fatalf("Unmarshal: %v", err)
}
wantKeys := []string{"repo", "id", "title", "url", "open_issues", "closed_issues",
"due_on", "due_hours", "overdue", "unassigned", "updated_at"}
// 鍵序:json.Unmarshal 到 map 會失序;改檢查原始字串的鍵出現順序。
pos := -1
for _, k := range wantKeys {
i := strings.Index(string(b), `"`+k+`":`)
if i < 0 {
t.Fatalf("輸出缺少鍵 %q:%s", k, b)
}
if i < pos {
t.Fatalf("鍵 %q 順序錯誤:%s", k, b)
}
pos = i
}
for _, kv := range []struct {
key string
want string
}{
{"repo", `"alterminal/agents"`},
{"due_on", `null`},
{"due_hours", `null`},
{"overdue", `false`},
{"url", `""`},
} {
if got := string(obj[kv.key]); got != kv.want {
t.Errorf("%s 應為 %s,得到 %s", kv.key, kv.want, got)
}
}
if !strings.Contains(string(b), `"number":40`) {
t.Errorf("未分派條目應含 number 40:%s", b)
}
// pull 條目的 author 鍵:有作者才輸出(無則不該出現 "author")。
if strings.Contains(string(obj["unassigned"]), `"author"`) {
t.Errorf("issue 條目不應有 author 鍵:%s", obj["unassigned"])
}
}
// TestMilestoneOverviewDueHoursRounding 驗證 due_hours 捨入到一位小數,
// 且 overdue 以未捨入值判定(0.04h → 0.0 但 overdue=true)。
func TestMilestoneOverviewDueHoursRounding(t *testing.T) {
src := &fakeMilestoneSource{
orgs: []string{"alterminal"},
repos: map[string][]Repo{"alterminal": {{Name: "r"}}},
milestones: map[string][]Milestone{
"alterminal/r": {
{ID: idPtr(1), Title: "edge", State: "open",
DueOn: msPtr("2026-09-10T07:57:36Z"), UpdatedAt: "2026-09-10T07:00:00Z"},
},
},
openIssues: map[string][]Issue{},
}
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
entries, err := MilestoneOverview(src, "", now)
if err != nil {
t.Fatalf("MilestoneOverview: %v", err)
}
if len(entries) != 1 {
t.Fatalf("應有 1 筆,得到 %d", len(entries))
}
// 144 秒 = 0.04 小時 → round1 → 0.0;未捨入 > 0 → overdue=true。
b, err := json.Marshal(entries[0])
if err != nil {
t.Fatalf("Marshal: %v", err)
}
if !strings.Contains(string(b), `"due_hours":0.0`) {
t.Errorf("due_hours 應捨入為 0.0:%s", b)
}
if !strings.Contains(string(b), `"overdue":true`) {
t.Errorf("overdue 應以未捨入值判定為 true:%s", b)
}
}
+231
View File
@@ -0,0 +1,231 @@
// stalled_entry_test.go — RunStalled/ResolveIssueXrefs 高階入口的單元測試
//(#7 CLI 接線;資料源注入假實作,離線可測)。
package workflow
import (
"strings"
"testing"
"time"
)
// fakeStalledSource 包 fakeSource 補上 StalledSource 面向。
type fakeStalledSource struct {
*fakeSource
username string
// getIssueErr 模擬 GetIssue 失敗(xrefs 的 404 路徑)。
getIssueErr error
}
func (f *fakeStalledSource) CurrentUser() (string, error) { return f.username, nil }
func (f *fakeStalledSource) GetIssue(owner, repo string, number int64) (Issue, error) {
if f.getIssueErr != nil {
return Issue{}, f.getIssueErr
}
i, ok := f.issues[owner+"/"+repo][number]
if !ok {
return Issue{}, &notFoundError{}
}
return i, nil
}
type notFoundError struct{}
func (e *notFoundError) Error() string { return "404" }
// newStalledFixture 建構掃描情境:alterminal 組織兩個倉庫,
// agents#1 是父追蹤項(引用 teai#2),teai#2 有較新留言。
func newStalledFixture() *fakeStalledSource {
return &fakeStalledSource{
fakeSource: &fakeSource{
orgs: []string{"alterminal"},
repos: map[string][]Repo{"alterminal": {
{Name: "agents", HasPullRequests: boolPtr(true)},
{Name: "teai", HasPullRequests: boolPtr(true)},
}},
issues: map[string]map[int64]Issue{
"alterminal/agents": {
1: {Number: 1, Title: "父追蹤項", State: "open",
Body: "子項:teai#2", CreatedAt: iso(-600), UpdatedAt: iso(-600),
Repository: &Repository{FullName: "alterminal/agents"}},
},
"alterminal/teai": {
2: {Number: 2, Title: "子項", State: "open",
CreatedAt: iso(-500), UpdatedAt: iso(-90),
Repository: &Repository{FullName: "alterminal/teai"}},
},
},
pulls: map[string][]PullRequest{},
comments: map[string][]Comment{
"alterminal/teai/2": {
{CreatedAt: iso(-90), User: &User{UserName: "alex"}, Body: "推進中"},
},
},
},
username: "ceo",
}
}
// TestRunStalledParentTracking 驗證 RunStalled:父追蹤項把子項活動
// 計入 last_activity(reason=parent-tracking),且門檻預設與覆寫皆可。
func TestRunStalledParentTracking(t *testing.T) {
src := newStalledFixture()
// 預設 4 小時門檻:子項 90 分鐘前有活動 → 父項 last_activity 同步,
// 未過門檻,清單為空。
items, err := RunStalled(src, 0, at(0))
if err != nil {
t.Fatalf("RunStalled: %v", err)
}
if len(items) != 0 {
t.Fatalf("預設門檻下不應有停滯項,得到 %d 筆", len(items))
}
// 門檻降到 1 小時:父追蹤項 last_activity 取子項活動(-90m)→
// 停滯 1.5h 列入(reason=parent-tracking、附 child_activity);
// 子項 teai#2 本身也停滯 1.5h(no-assignee)。
items, err = RunStalled(src, 1, at(0))
if err != nil {
t.Fatalf("RunStalled: %v", err)
}
if len(items) != 2 {
t.Fatalf("應有兩筆(父追蹤項+子項),得到 %d:%+v", len(items), items)
}
var parent *Item
for i := range items {
if items[i].Number == 1 {
parent = &items[i]
}
}
if parent == nil {
t.Fatalf("找不到 agents#1:%+v", items)
}
if parent.Reason != "parent-tracking" || parent.Repo != "alterminal/agents" {
t.Fatalf("agents#1 應為 parent-tracking,得到 %s(%s)", parent.Reason, parent.Repo)
}
if len(parent.ChildActivity) == 0 {
t.Fatalf("parent-tracking 應附 child_activity")
}
if parent.StalledHours != 1.5 {
t.Fatalf("last_activity 應取子項活動(-90m → 1.5h),得到 %.1f", parent.StalledHours)
}
}
// TestRunStalledNudgeCooldown 驗證催促冷卻:最後留言出自目前帳號
// 且在 24 小時內 → 不列入;冷卻過後再出現。
func TestRunStalledNudgeCooldown(t *testing.T) {
src := newStalledFixture()
setIssueBody(src, "alterminal", "agents", 1, "") // 移除子項引用
src.comments["alterminal/agents/1"] = []Comment{
{CreatedAt: iso(-2), User: &User{UserName: "ceo"}},
}
findOne := func(items []Item) bool {
for _, it := range items {
if it.Repo == "alterminal/agents" && it.Number == 1 {
return true
}
}
return false
}
items, err := RunStalled(src, 1, at(0))
if err != nil {
t.Fatalf("RunStalled: %v", err)
}
if findOne(items) {
t.Fatalf("催促冷卻期內(2 小時前留言)agents#1 不應列入,得到 %+v", items)
}
src.comments["alterminal/agents/1"] = []Comment{
{CreatedAt: iso(-30 * 60), User: &User{UserName: "ceo"}},
}
items, err = RunStalled(src, 1, at(0))
if err != nil {
t.Fatalf("RunStalled: %v", err)
}
if !findOne(items) {
t.Fatalf("冷卻(24h)過後 agents#1 應再出現,得到 %+v", items)
}
}
// TestResolveIssueXrefs 驗證 xrefs 入口:內文與留言的引用解析、
// 去重、出處標記與單段 repo 的存在性邊界。
func TestResolveIssueXrefs(t *testing.T) {
src := newStalledFixture()
setIssueBody(src, "alterminal", "agents", 1, "看 teai#2 與 #7,另見 alterminal/teai#2")
src.comments["alterminal/agents/1"] = []Comment{
{Body: "teai#2 已處理", User: &User{UserName: "alex"}, CreatedAt: iso(-10)},
{Body: "nope#9 不存在", User: &User{UserName: "max"}, CreatedAt: iso(-5)},
}
// fixture 的組織倉庫只有 agents → teai#2 單段不解析(repo 不在
// alterminal 組織清單);補上 teai 倉庫讓單段解析成立。
src.repos["alterminal"] = []Repo{
{Name: "agents", HasPullRequests: boolPtr(true)},
{Name: "teai", HasPullRequests: boolPtr(true)},
}
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
if err != nil {
t.Fatalf("ResolveIssueXrefs: %v", err)
}
want := []XrefHit{
{Owner: "alterminal", Repo: "teai", Number: 2, Source: "body"},
{Owner: "alterminal", Repo: "agents", Number: 7, Source: "body"},
}
if len(hits) != len(want) {
t.Fatalf("應解析出 %d 筆(留言重複的 teai#2 去重、nope#9 略過),得到 %d:%+v",
len(want), len(hits), hits)
}
for i := range want {
if hits[i] != want[i] {
t.Fatalf("hits[%d] = %+v, want %+v", i, hits[i], want[i])
}
}
}
// TestResolveIssueXrefsCommentSource 驗證出處:僅出現在留言的引用
// 標記為 comment。
func TestResolveIssueXrefsCommentSource(t *testing.T) {
src := newStalledFixture()
setIssueBody(src, "alterminal", "agents", 1, "內文無引用")
src.comments["alterminal/agents/1"] = []Comment{
{Body: "追蹤 #9", User: &User{UserName: "alex"}, CreatedAt: iso(-10)},
}
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
if err != nil {
t.Fatalf("ResolveIssueXrefs: %v", err)
}
if len(hits) != 1 || hits[0].Source != "comment" || hits[0].Number != 9 {
t.Fatalf("應輸出一筆 source=comment 的 #9,得到 %+v", hits)
}
}
// TestResolveIssueXrefsGetError 驗證 GetIssue 失敗(如 404)層層回傳,
// 由 CLI 映射結束碼。
func TestResolveIssueXrefsGetError(t *testing.T) {
src := newStalledFixture()
src.getIssueErr = &notFoundError{}
if _, err := ResolveIssueXrefs(src, "alterminal", "agents", 1); err == nil {
t.Fatalf("GetIssue 失敗應回傳錯誤")
}
}
func boolPtr(b bool) *bool { return &b }
// setIssueBody 修改 map 內 issue 的內文(map 元素不可定址,需整體重塞)。
func setIssueBody(src *fakeStalledSource, owner, repo string, number int64, body string) {
key := owner + "/" + repo
issue := src.issues[key][number]
issue.Body = body
src.issues[key][number] = issue
}
// TestResolveIssueXrefsEmptyBody 驗證無引用時輸出空(CLI 印 [])。
func TestResolveIssueXrefsEmptyBody(t *testing.T) {
src := newStalledFixture()
setIssueBody(src, "alterminal", "agents", 1, strings.Repeat("無引用內文", 3))
delete(src.comments, "alterminal/agents/1")
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
if err != nil {
t.Fatalf("ResolveIssueXrefs: %v", err)
}
if len(hits) != 0 {
t.Fatalf("無引用應輸出空清單,得到 %+v", hits)
}
_ = time.Now // time 僅供 iso/at 使用;保留 import。
}
+24
View File
@@ -3,6 +3,8 @@ package workflow
import ( import (
"encoding/json" "encoding/json"
"regexp" "regexp"
"strings"
"time"
) )
// User 是 Gitea API 的使用者物件(僅取工作流判斷會用到的欄位)。 // User 是 Gitea API 的使用者物件(僅取工作流判斷會用到的欄位)。
@@ -65,6 +67,7 @@ type PRRef struct {
// Comment 是 issue/PR 的討論留言(PR 的留言也走 issues comments 端點)。 // Comment 是 issue/PR 的討論留言(PR 的留言也走 issues comments 端點)。
type Comment struct { type Comment struct {
Body string `json:"body"`
CreatedAt string `json:"created_at"` CreatedAt string `json:"created_at"`
User *User `json:"user"` User *User `json:"user"`
} }
@@ -82,6 +85,9 @@ type Issue struct {
Number int64 `json:"number"` Number int64 `json:"number"`
Index int64 `json:"index"` Index int64 `json:"index"`
Title string `json:"title"` Title string `json:"title"`
State string `json:"state"`
Body string `json:"body"`
ClosedAt string `json:"closed_at"`
HTMLURL string `json:"html_url"` HTMLURL string `json:"html_url"`
URL string `json:"url"` URL string `json:"url"`
UpdatedAt string `json:"updated_at"` UpdatedAt string `json:"updated_at"`
@@ -216,3 +222,21 @@ func (p *PullRequest) FullName() string {
} }
return repoFullNameFromURL(p.WebURL()) return repoFullNameFromURL(p.WebURL())
} }
// parseMoment 對應 gitea.py 的 _parse_iso8601:剖析 ISO8601 字串(Z 後綴、
// 小數秒、時區偏移皆可;無時區視為 UTC),失敗回 (零值, false)。
// 保留原時區偏移、不轉 UTC——Python datetime.isoformat() 會原樣輸出
// 「+08:00」這類偏移,轉了 UTC 輸出就變 +00:00,與基準位元組不相容。
// stalled 掃描的時刻判斷(last_activity、催促冷卻)都以這裡的語義為準。
func parseMoment(value string) (time.Time, bool) {
text := strings.TrimSpace(value)
if text == "" {
return time.Time{}, false
}
for _, layout := range []string{time.RFC3339Nano, time.RFC3339, "2006-01-02T15:04:05", "2006-01-02"} {
if t, err := time.Parse(layout, text); err == nil {
return t, true
}
}
return time.Time{}, false
}
+169 -159
View File
@@ -37,85 +37,11 @@ const (
// Go 的 regexp 不支援 lookbehind,改在掃描時檢查前一字元。 // Go 的 regexp 不支援 lookbehind,改在掃描時檢查前一字元。
var xrefPattern = regexp.MustCompile(`([A-Za-z0-9_.-]+(?:/[A-Za-z0-9_.-]+)?)?#(\d+)`) var xrefPattern = regexp.MustCompile(`([A-Za-z0-9_.-]+(?:/[A-Za-z0-9_.-]+)?)?#(\d+)`)
// User 是 Gitea user 物件的精簡投影。
type User struct {
Username string `json:"username"`
}
// Comment 是 issue/PR 留言的精簡投影。
type Comment struct {
User User `json:"user"`
Body string `json:"body"`
CreatedAt time.Time `json:"created_at"`
}
// Author 回傳留言作者帳號;空字串表示無法判定。
func (c Comment) Author() string { return c.User.Username }
// Issue 是 issue 的精簡投影(Gitea /repos/{owner}/{repo}/issues,不含 PR)。
type Issue struct {
Number int `json:"number"`
Title string `json:"title"`
State string `json:"state"`
Body string `json:"body"`
Author User `json:"user"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
ClosedAt *time.Time `json:"closed_at,omitempty"`
// URL 對應 API 的 html_url。
URL string `json:"html_url"`
Assignees []User `json:"assignees"`
Repository Reference `json:"repository"`
// PullRequest 非 nil 表示這其實是 PR(Gitea 的 /issues API 兩者都回)。
PullRequest any `json:"pull_request,omitempty"`
}
// Reference 是 repository 物件的精簡投影(issue 物件帶 full_name)。
type Reference struct {
FullName string `json:"full_name"`
}
// Ref 是 PR base/head 的精簡投影(PR 物件沒有 repository 欄位,改讀 base/head.repo)。
type Ref struct {
Repo Reference `json:"repo"`
}
// PullRequest 是 /repos/{owner}/{repo}/pulls 物件的精簡投影。
type PullRequest struct {
Number int `json:"number"`
Title string `json:"title"`
State string `json:"state"`
Author User `json:"user"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
ClosedAt *time.Time `json:"closed_at,omitempty"`
// URL 對應 API 的 html_url。
URL string `json:"html_url"`
Base Ref `json:"base"`
Head Ref `json:"head"`
RequestedReviewers []User `json:"requested_reviewers"`
}
// FullName 回傳 "owner/repo";PR 沒有 repository 欄位,改讀 base(再退 head)。
func (p PullRequest) FullName() string {
if p.Base.Repo.FullName != "" {
return p.Base.Repo.FullName
}
return p.Head.Repo.FullName
}
// Repository 是 /orgs/{org}/repos 物件的精簡投影。
type Repository struct {
Name string `json:"name"`
Empty bool `json:"empty"`
HasPullRequests *bool `json:"has_pull_requests"`
}
// Item 是 stalled 掃描的單筆輸出(欄位對應 gitea.py 的 find_stalled_work)。 // Item 是 stalled 掃描的單筆輸出(欄位對應 gitea.py 的 find_stalled_work)。
type Item struct { type Item struct {
Type string Type string
Repo string Repo string
Number int Number int64
Title string Title string
URL string URL string
Assignees []string Assignees []string
@@ -195,7 +121,7 @@ func writeJSON(b *strings.Builder, v any) {
// Child 是父追蹤項的子項活動摘要。 // Child 是父追蹤項的子項活動摘要。
type Child struct { type Child struct {
Repo string `json:"repo"` Repo string `json:"repo"`
Number int `json:"number"` Number int64 `json:"number"`
Title string `json:"title"` Title string `json:"title"`
State string `json:"state"` State string `json:"state"`
// LastActivityAt 用指標:子項無可解析時刻時 Python 輸出 null(不是 "")。 // LastActivityAt 用指標:子項無可解析時刻時 Python 輸出 null(不是 "")。
@@ -206,7 +132,7 @@ type Child struct {
type XrefTarget struct { type XrefTarget struct {
Owner string Owner string
Repo string Repo string
Number int Number int64
} }
// Source 是 stalled 掃描需要的資料源(CLI 層以 API 實作;測試注入假資料)。 // Source 是 stalled 掃描需要的資料源(CLI 層以 API 實作;測試注入假資料)。
@@ -214,15 +140,15 @@ type Source interface {
// MyOrganizations 回傳目前帳號所屬組織清單。 // MyOrganizations 回傳目前帳號所屬組織清單。
MyOrganizations() ([]string, error) MyOrganizations() ([]string, error)
// OrganizationRepositories 回傳組織的倉庫清單。 // OrganizationRepositories 回傳組織的倉庫清單。
OrganizationRepositories(org string) ([]Repository, error) OrganizationRepositories(org string) ([]Repo, error)
// OpenIssues 回傳倉庫的 open issues(Gitea 會混入 PR,由掃描端過濾)。 // OpenIssues 回傳倉庫的 open issues(Gitea 會混入 PR,由掃描端過濾)。
OpenIssues(owner, repo string) ([]Issue, error) OpenIssues(owner, repo string) ([]Issue, error)
// OpenPulls 回傳倉庫的 open pull requests。 // OpenPulls 回傳倉庫的 open pull requests。
OpenPulls(owner, repo string) ([]PullRequest, error) OpenPulls(owner, repo string) ([]PullRequest, error)
// IssueComments 回傳 issue/PR 的留言。 // IssueComments 回傳 issue/PR 的留言。
IssueComments(owner, repo string, number int) ([]Comment, error) IssueComments(owner, repo string, number int64) ([]Comment, error)
// TryGetIssue 寬容版單一 issue 查詢:失敗(含 404)回 (零值, false, nil)。 // TryGetIssue 寬容版單一 issue 查詢:失敗(含 404)回 (零值, false, nil)。
TryGetIssue(owner, repo string, number int) (Issue, bool, error) TryGetIssue(owner, repo string, number int64) (Issue, bool, error)
} }
// iterXrefs 產出文字中的 (prefix, number) 配對(對應 _iter_issue_xrefs)。 // iterXrefs 產出文字中的 (prefix, number) 配對(對應 _iter_issue_xrefs)。
@@ -278,7 +204,7 @@ func ResolveXrefTargets(org, repo string, texts []string, myOrgs map[string]bool
for _, text := range texts { for _, text := range texts {
for _, pair := range iterXrefs(text) { for _, pair := range iterXrefs(text) {
prefix, numberStr := pair[0], pair[1] prefix, numberStr := pair[0], pair[1]
var number int var number int64
if _, err := fmt.Sscanf(numberStr, "%d", &number); err != nil || number <= 0 { if _, err := fmt.Sscanf(numberStr, "%d", &number); err != nil || number <= 0 {
continue continue
} }
@@ -334,23 +260,25 @@ func childActivity(src Source, org, repo string, parent Issue, comments []Commen
if gerr != nil || !ok { if gerr != nil || !ok {
continue continue
} }
if t.Owner == org && t.Repo == repo && child.Number == parent.Number { if t.Owner == org && t.Repo == repo && child.issueNumber() == parent.issueNumber() {
continue // 自我引用 continue // 自我引用
} }
if !parent.CreatedAt.IsZero() && !child.CreatedAt.IsZero() && !child.CreatedAt.After(parent.CreatedAt) { parentCreated, pcOK := parseMoment(parent.CreatedAt)
childCreated, ccOK := parseMoment(child.CreatedAt)
if pcOK && ccOK && !childCreated.After(parentCreated) {
continue // 上行引用(父項回指更早或同時的 issue);時間未知則不排除 continue // 上行引用(父項回指更早或同時的 issue);時間未知則不排除
} }
var ms []time.Time var ms []time.Time
if !child.UpdatedAt.IsZero() { if m, ok := parseMoment(child.UpdatedAt); ok {
ms = append(ms, child.UpdatedAt) ms = append(ms, m)
} }
if child.ClosedAt != nil && !child.ClosedAt.IsZero() { if m, ok := parseMoment(child.ClosedAt); ok {
ms = append(ms, *child.ClosedAt) ms = append(ms, m)
} }
if cs, cerr := src.IssueComments(t.Owner, t.Repo, t.Number); cerr == nil { if cs, cerr := src.IssueComments(t.Owner, t.Repo, t.Number); cerr == nil {
for _, c := range cs { for _, c := range cs {
if !c.CreatedAt.IsZero() { if m, ok := parseMoment(c.CreatedAt); ok {
ms = append(ms, c.CreatedAt) ms = append(ms, m)
} }
} }
} }
@@ -384,20 +312,6 @@ func maxTime(ts []time.Time) time.Time {
return best return best
} }
func usernames(users []User) []string {
var out []string
seen := map[string]bool{}
for _, u := range users {
if u.Username == "" || seen[u.Username] {
continue
}
seen[u.Username] = true
out = append(out, u.Username)
}
sort.Strings(out)
return out
}
// ScanStalled 掃描跨組織的停滯 open issues/PR(對應 find_stalled_work)。 // ScanStalled 掃描跨組織的停滯 open issues/PR(對應 find_stalled_work)。
// //
// 判定:最後活動(留言時間與本身 updated_at 取較晚者,父追蹤項再加計 // 判定:最後活動(留言時間與本身 updated_at 取較晚者,父追蹤項再加計
@@ -483,15 +397,20 @@ func ScanStalled(src Source, username string, threshold float64, now time.Time)
// considerIssue 對單一 issue 套用停滯判定(對應 _consider 的 issue 分支)。 // considerIssue 對單一 issue 套用停滯判定(對應 _consider 的 issue 分支)。
func considerIssue(src Source, org, repo string, issue Issue, comments []Comment, username string, threshold float64, now time.Time, myOrgs map[string]bool, orgRepos func(string) ([]string, error)) (Item, bool) { func considerIssue(src Source, org, repo string, issue Issue, comments []Comment, username string, threshold float64, now time.Time, myOrgs map[string]bool, orgRepos func(string) ([]string, error)) (Item, bool) {
childMoments, children := childActivity(src, org, repo, issue, comments, myOrgs, orgRepos) childMoments, children := childActivity(src, org, repo, issue, comments, myOrgs, orgRepos)
assignees := usernames(issue.Assignees) assignees := AssigneeNames(&issue)
moments := []time.Time{issue.UpdatedAt, issue.CreatedAt} var moments []time.Time
if m, ok := parseMoment(issue.UpdatedAt); ok {
moments = append(moments, m)
}
if m, ok := parseMoment(issue.CreatedAt); ok {
moments = append(moments, m)
}
for _, c := range comments { for _, c := range comments {
if !c.CreatedAt.IsZero() { if m, ok := parseMoment(c.CreatedAt); ok {
moments = append(moments, c.CreatedAt) moments = append(moments, m)
} }
} }
moments = append(moments, childMoments...) moments = append(moments, childMoments...)
moments = nonZero(moments)
if len(moments) == 0 { if len(moments) == 0 {
return Item{}, false return Item{}, false
} }
@@ -500,16 +419,21 @@ func considerIssue(src Source, org, repo string, issue Issue, comments []Comment
if stalled < threshold { if stalled < threshold {
return Item{}, false return Item{}, false
} }
lastCommentAt, lastCommentBy := lastComment(comments) last := LastComment(comments)
if lastCommentBy == username && !lastCommentAt.IsZero() && lastCommentBy := ""
now.Sub(lastCommentAt).Hours() < NudgeCooldownHours { if last != nil {
return Item{}, false lastCommentBy = last.Author()
}
if lastCommentBy == username {
if m, ok := parseMoment(last.CreatedAt); ok && now.Sub(m).Hours() < NudgeCooldownHours {
return Item{}, false
}
} }
reason := "waiting-outside" reason := "waiting-outside"
switch { switch {
case len(assignees) == 0: case len(assignees) == 0:
reason = "no-assignee" reason = "no-assignee"
case lastCommentBy != "" && containsStr(assignees, lastCommentBy): case lastCommentBy != "" && containsString(assignees, lastCommentBy):
reason = "assignee-idle" reason = "assignee-idle"
case lastCommentBy == "": case lastCommentBy == "":
reason = "no-commenter" reason = "no-commenter"
@@ -518,8 +442,8 @@ func considerIssue(src Source, org, repo string, issue Issue, comments []Comment
reason = "parent-tracking" reason = "parent-tracking"
} }
item := Item{ item := Item{
Type: "issue", Repo: issue.Repository.FullName, Number: issue.Number, Type: "issue", Repo: issue.FullName(), Number: issue.issueNumber(),
Title: issue.Title, URL: issue.URL, Title: issue.Title, URL: issue.WebURL(),
Assignees: assignees, Assignees: assignees,
LastCommentBy: lastCommentBy, LastActivityAt: lastActivity, LastCommentBy: lastCommentBy, LastActivityAt: lastActivity,
StalledHours: round1(stalled), Reason: reason, StalledHours: round1(stalled), Reason: reason,
@@ -532,15 +456,20 @@ func considerIssue(src Source, org, repo string, issue Issue, comments []Comment
// considerPull 對單一 PR 套用停滯判定(對應 _consider 的 pull 分支)。 // considerPull 對單一 PR 套用停滯判定(對應 _consider 的 pull 分支)。
func considerPull(pr PullRequest, comments []Comment, username string, threshold float64, now time.Time) (Item, bool) { func considerPull(pr PullRequest, comments []Comment, username string, threshold float64, now time.Time) (Item, bool) {
reviewers := usernames(pr.RequestedReviewers) reviewers := ReviewerNames(&pr)
author := pr.Author.Username author := pr.Author()
moments := []time.Time{pr.UpdatedAt, pr.CreatedAt} var moments []time.Time
if m, ok := parseMoment(pr.UpdatedAt); ok {
moments = append(moments, m)
}
if m, ok := parseMoment(pr.CreatedAt); ok {
moments = append(moments, m)
}
for _, c := range comments { for _, c := range comments {
if !c.CreatedAt.IsZero() { if m, ok := parseMoment(c.CreatedAt); ok {
moments = append(moments, c.CreatedAt) moments = append(moments, m)
} }
} }
moments = nonZero(moments)
if len(moments) == 0 { if len(moments) == 0 {
return Item{}, false return Item{}, false
} }
@@ -549,10 +478,15 @@ func considerPull(pr PullRequest, comments []Comment, username string, threshold
if stalled < threshold { if stalled < threshold {
return Item{}, false return Item{}, false
} }
lastCommentAt, lastCommentBy := lastComment(comments) last := LastComment(comments)
if lastCommentBy == username && !lastCommentAt.IsZero() && lastCommentBy := ""
now.Sub(lastCommentAt).Hours() < NudgeCooldownHours { if last != nil {
return Item{}, false lastCommentBy = last.Author()
}
if lastCommentBy == username {
if m, ok := parseMoment(last.CreatedAt); ok && now.Sub(m).Hours() < NudgeCooldownHours {
return Item{}, false
}
} }
reason := "no-commenter" reason := "no-commenter"
switch { switch {
@@ -560,12 +494,12 @@ func considerPull(pr PullRequest, comments []Comment, username string, threshold
reason = "no-reviewer" reason = "no-reviewer"
case lastCommentBy == author: case lastCommentBy == author:
reason = "author-idle" reason = "author-idle"
case lastCommentBy != "" && containsStr(reviewers, lastCommentBy): case lastCommentBy != "" && containsString(reviewers, lastCommentBy):
reason = "reviewer-idle" reason = "reviewer-idle"
} }
item := Item{ item := Item{
Type: "pull", Repo: pr.FullName(), Number: pr.Number, Type: "pull", Repo: pr.FullName(), Number: pr.Number,
Title: pr.Title, URL: pr.URL, Title: pr.Title, URL: pr.WebURL(),
Author: author, Reviewers: reviewers, Author: author, Reviewers: reviewers,
LastCommentBy: lastCommentBy, LastActivityAt: lastActivity, LastCommentBy: lastCommentBy, LastActivityAt: lastActivity,
StalledHours: round1(stalled), Reason: reason, StalledHours: round1(stalled), Reason: reason,
@@ -573,19 +507,6 @@ func considerPull(pr PullRequest, comments []Comment, username string, threshold
return item, true return item, true
} }
// lastComment 回傳最後一則留言(created_at 最新者)的時間與作者。
func lastComment(comments []Comment) (time.Time, string) {
var best time.Time
by := ""
for _, c := range comments {
if c.CreatedAt.After(best) {
best = c.CreatedAt
by = c.Author()
}
}
return best, by
}
func anyOpen(children []Child) bool { func anyOpen(children []Child) bool {
for _, c := range children { for _, c := range children {
if c.State == "open" { if c.State == "open" {
@@ -595,25 +516,6 @@ func anyOpen(children []Child) bool {
return false return false
} }
func containsStr(list []string, s string) bool {
for _, x := range list {
if x == s {
return true
}
}
return false
}
func nonZero(ts []time.Time) []time.Time {
out := make([]time.Time, 0, len(ts))
for _, t := range ts {
if !t.IsZero() {
out = append(out, t)
}
}
return out
}
// round1 舍入到小數一位(對應 Python round(x, 1))。 // round1 舍入到小數一位(對應 Python round(x, 1))。
// 經 strconv 的十進位正確舍入(半偶數),與 Python 的浮點 round 行為一致, // 經 strconv 的十進位正確舍入(半偶數),與 Python 的浮點 round 行為一致,
// 避免 (x*10+0.5) 截斷在 .x5 邊界產生偏差。 // 避免 (x*10+0.5) 截斷在 .x5 邊界產生偏差。
@@ -624,3 +526,111 @@ func round1(v float64) float64 {
} }
return r return r
} }
// ── CLI 接線用的高階入口(#7:teai stalled/teai xrefs)─────────────────
// StalledSource 是 stalled/xrefs 命令需要的完整資料源:
// Source(掃描用讀取)加上目前帳號與單一 issue 查詢。
// APIClient(giteaapi.go)實作此介面;測試以假資料源注入。
type StalledSource interface {
Source
// CurrentUser 回傳目前帳號名(催促冷卻判定用)。
CurrentUser() (string, error)
// GetIssue 嚴格版單一 issue/PR 查詢;失敗回錯誤(xrefs 命令用,
// 404 應回 ErrAPI 由 CLI 映射結束碼 3)。
GetIssue(owner, repo string, number int64) (Issue, error)
}
// RunStalled 是 teai stalled 的核心:解析目前帳號後跑 ScanStalled。
// hours <= 0 時採 StalledDefaultHours(對應 gitea.py stalled [--hours N]
// 的預設 4 小時);旗標層已先攔下非正數,這裡是防禦。
func RunStalled(src StalledSource, hours float64, now time.Time) ([]Item, error) {
if hours <= 0 {
hours = StalledDefaultHours
}
username, err := src.CurrentUser()
if err != nil {
return nil, err
}
return ScanStalled(src, username, hours, now)
}
// XrefHit 是 teai xrefs 的單筆輸出:解析後的目標加上出處
// (README 規格:"body"=內文、"comment"=留言)。
type XrefHit struct {
Owner string `json:"owner"`
Repo string `json:"repo"`
Number int64 `json:"number"`
Source string `json:"source"`
}
// ResolveIssueXrefs 是 teai xrefs 的核心:取回單一 issue/PR 的內文與
// 全部留言,解析其中的 #N、repo#N、owner/repo#N 引用(規則同
// ResolveXrefTargets:單段 repo 僅在父項所屬組織有該倉庫時解析、
// owner/repo#N 僅在 owner 為所屬組織時解析),去重並保留出現順序,
// 每筆附首次出現的出處(內文先於留言)。stalled 的父追蹤項判定
// 內部用同一套解析,不重複實作。
func ResolveIssueXrefs(src StalledSource, owner, repo string, number int64) ([]XrefHit, error) {
issue, err := src.GetIssue(owner, repo, number)
if err != nil {
return nil, err
}
comments, err := src.IssueComments(owner, repo, number)
if err != nil {
return nil, err
}
orgs, err := src.MyOrganizations()
if err != nil {
return nil, err
}
myOrgs := make(map[string]bool, len(orgs))
for _, o := range orgs {
myOrgs[o] = true
}
// 組織倉庫清單跨呼叫快取,避免逐則留言重打 API。
orgRepoCache := map[string][]string{}
orgRepos := func(org string) ([]string, error) {
if names, ok := orgRepoCache[org]; ok {
return names, nil
}
repos, err := src.OrganizationRepositories(org)
if err != nil {
return nil, err
}
names := make([]string, 0, len(repos))
for _, r := range repos {
if r.Name != "" {
names = append(names, r.Name)
}
}
orgRepoCache[org] = names
return names, nil
}
type sourceText struct {
text string
source string
}
texts := []sourceText{{issue.Body, "body"}}
for _, c := range comments {
texts = append(texts, sourceText{c.Body, "comment"})
}
var hits []XrefHit
seen := map[XrefTarget]bool{}
for _, t := range texts {
targets, err := ResolveXrefTargets(owner, repo, []string{t.text}, myOrgs, orgRepos)
if err != nil {
return nil, err
}
for _, target := range targets {
if seen[target] {
continue
}
seen[target] = true
hits = append(hits, XrefHit{
Owner: target.Owner, Repo: target.Repo,
Number: target.Number, Source: t.source,
})
}
}
return hits, nil
}
+58 -55
View File
@@ -21,9 +21,9 @@ func at(minutes int) time.Time {
// fakeSource 是注入假資料的 Source。 // fakeSource 是注入假資料的 Source。
type fakeSource struct { type fakeSource struct {
orgs []string orgs []string
repos map[string][]Repository repos map[string][]Repo
// issues[owner/repo][number] // issues[owner/repo][number]
issues map[string]map[int]Issue issues map[string]map[int64]Issue
// pulls[owner/repo] // pulls[owner/repo]
pulls map[string][]PullRequest pulls map[string][]PullRequest
// comments[owner/repo/number] // comments[owner/repo/number]
@@ -32,7 +32,7 @@ type fakeSource struct {
func (f *fakeSource) MyOrganizations() ([]string, error) { return f.orgs, nil } func (f *fakeSource) MyOrganizations() ([]string, error) { return f.orgs, nil }
func (f *fakeSource) OrganizationRepositories(org string) ([]Repository, error) { func (f *fakeSource) OrganizationRepositories(org string) ([]Repo, error) {
return f.repos[org], nil return f.repos[org], nil
} }
@@ -48,11 +48,11 @@ func (f *fakeSource) OpenPulls(owner, repo string) ([]PullRequest, error) {
return f.pulls[owner+"/"+repo], nil return f.pulls[owner+"/"+repo], nil
} }
func (f *fakeSource) IssueComments(owner, repo string, number int) ([]Comment, error) { func (f *fakeSource) IssueComments(owner, repo string, number int64) ([]Comment, error) {
return f.comments[fmt.Sprintf("%s/%s/%d", owner, repo, number)], nil return f.comments[fmt.Sprintf("%s/%s/%d", owner, repo, number)], nil
} }
func (f *fakeSource) TryGetIssue(owner, repo string, number int) (Issue, bool, error) { func (f *fakeSource) TryGetIssue(owner, repo string, number int64) (Issue, bool, error) {
i, ok := f.issues[owner+"/"+repo][number] i, ok := f.issues[owner+"/"+repo][number]
if !ok { if !ok {
return Issue{}, false, nil return Issue{}, false, nil
@@ -60,11 +60,14 @@ func (f *fakeSource) TryGetIssue(owner, repo string, number int) (Issue, bool, e
return i, true, nil return i, true, nil
} }
func repoWith(name string, hasPR bool) []Repository { func repoWith(name string, hasPR bool) []Repo {
h := hasPR h := hasPR
return []Repository{{Name: name, HasPullRequests: &h}} return []Repo{{Name: name, HasPullRequests: &h}}
} }
// iso 把相對分鐘轉成 parseMoment 可剖析的 ISO8601 字串(假資料用)。
func iso(minutes int) string { return FormatMoment(at(minutes)) }
func mustResolve(t *testing.T, org, repo string, texts []string, myOrgs map[string]bool, orgRepos func(string) ([]string, error)) []XrefTarget { func mustResolve(t *testing.T, org, repo string, texts []string, myOrgs map[string]bool, orgRepos func(string) ([]string, error)) []XrefTarget {
t.Helper() t.Helper()
targets, err := ResolveXrefTargets(org, repo, texts, myOrgs, orgRepos) targets, err := ResolveXrefTargets(org, repo, texts, myOrgs, orgRepos)
@@ -157,21 +160,21 @@ func TestScanStalledIssueReasons(t *testing.T) {
now := at(0) now := at(0)
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{ repos: map[string][]Repo{
"alterminal": repoWith("agents", true), "alterminal": repoWith("agents", true),
}, },
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/agents": { "alterminal/agents": {
1: {Number: 1, Title: "無分派者", State: "open", CreatedAt: at(-600), UpdatedAt: at(-600), Repository: Reference{"alterminal/agents"}, URL: "u1"}, 1: {Number: 1, Title: "無分派者", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/agents"}, URL: "u1"},
2: {Number: 2, Title: "分派者自己最後留言", State: "open", Author: User{"ceo"}, CreatedAt: at(-600), UpdatedAt: at(-300), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/agents"}, URL: "u2"}, 2: {Number: 2, Title: "分派者自己最後留言", State: "open", User: &User{UserName: "ceo"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u2"},
3: {Number: 3, Title: "無留言", State: "open", CreatedAt: at(-600), UpdatedAt: at(-300), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/agents"}, URL: "u3"}, 3: {Number: 3, Title: "無留言", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u3"},
4: {Number: 4, Title: "等外部回應", State: "open", CreatedAt: at(-600), UpdatedAt: at(-300), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/agents"}, URL: "u4"}, 4: {Number: 4, Title: "等外部回應", State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u4"},
5: {Number: 5, Title: "太新不在門檻內", State: "open", CreatedAt: at(-30), UpdatedAt: at(-30), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/agents"}, URL: "u5"}, 5: {Number: 5, Title: "太新不在門檻內", State: "open", CreatedAt: iso(-30), UpdatedAt: iso(-30), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/agents"}, URL: "u5"},
}, },
}, },
comments: map[string][]Comment{ comments: map[string][]Comment{
"alterminal/agents/2": {{User: User{"ceo"}, CreatedAt: at(-300)}}, "alterminal/agents/2": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}},
"alterminal/agents/4": {{User: User{"dan"}, CreatedAt: at(-300)}}, "alterminal/agents/4": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300)}},
}, },
} }
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
@@ -182,11 +185,11 @@ func TestScanStalledIssueReasons(t *testing.T) {
if len(got) != 4 { if len(got) != 4 {
t.Fatalf("應 4 筆,got %d:%v", len(got), got) t.Fatalf("應 4 筆,got %d:%v", len(got), got)
} }
byNumber := map[int]Item{} byNumber := map[int64]Item{}
for _, it := range got { for _, it := range got {
byNumber[it.Number] = it byNumber[it.Number] = it
} }
for n, wantReason := range map[int]string{1: "no-assignee", 2: "assignee-idle", 3: "no-commenter", 4: "waiting-outside"} { for n, wantReason := range map[int64]string{1: "no-assignee", 2: "assignee-idle", 3: "no-commenter", 4: "waiting-outside"} {
if byNumber[n].Reason != wantReason { if byNumber[n].Reason != wantReason {
t.Errorf("issue %d reason = %q, want %q", n, byNumber[n].Reason, wantReason) t.Errorf("issue %d reason = %q, want %q", n, byNumber[n].Reason, wantReason)
} }
@@ -204,15 +207,15 @@ func TestScanStalledNudgeCooldown(t *testing.T) {
now := at(0) now := at(0)
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": repoWith("agents", true)}, repos: map[string][]Repo{"alterminal": repoWith("agents", true)},
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/agents": { "alterminal/agents": {
1: {Number: 1, State: "open", CreatedAt: at(-600), UpdatedAt: at(-600), Assignees: []User{{"max"}}, Repository: Reference{"alterminal/agents"}}, 1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Assignees: []User{{UserName: "max"}}, Repository: &Repository{FullName: "alterminal/agents"}},
}, },
}, },
comments: map[string][]Comment{ comments: map[string][]Comment{
// admin(掃描者)10 小時前催促過 → 冷卻中,不列入。 // admin(掃描者)10 小時前催促過 → 冷卻中,不列入。
"alterminal/agents/1": {{User: User{"admin"}, CreatedAt: at(-600)}}, "alterminal/agents/1": {{User: &User{UserName: "admin"}, CreatedAt: iso(-600)}},
}, },
} }
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
@@ -223,7 +226,7 @@ func TestScanStalledNudgeCooldown(t *testing.T) {
t.Fatalf("催促冷卻中的項目不應列入,got %v", got) t.Fatalf("催促冷卻中的項目不應列入,got %v", got)
} }
// 冷卻過了(25 小時前催促)→ 重新列入。 // 冷卻過了(25 小時前催促)→ 重新列入。
src.comments["alterminal/agents/1"] = []Comment{{User: User{"admin"}, CreatedAt: at(-1500)}} src.comments["alterminal/agents/1"] = []Comment{{User: &User{UserName: "admin"}, CreatedAt: iso(-1500)}}
got, err = ScanStalled(src, "admin", 4.0, now) got, err = ScanStalled(src, "admin", 4.0, now)
if err != nil { if err != nil {
t.Fatalf("ScanStalled: %v", err) t.Fatalf("ScanStalled: %v", err)
@@ -240,15 +243,15 @@ func TestScanStalledParentTracking(t *testing.T) {
// 應以 parent-tracking 列入並附子項摘要;子項本身則是 assignee-idle。 // 應以 parent-tracking 列入並附子項摘要;子項本身則是 assignee-idle。
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": repoWith("teai", true)}, repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/teai": { "alterminal/teai": {
3: {Number: 3, Title: "父", State: "open", Body: "子項:#7", CreatedAt: at(-700), UpdatedAt: at(-300), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/teai"}}, 3: {Number: 3, Title: "父", State: "open", Body: "子項:#7", CreatedAt: iso(-700), UpdatedAt: iso(-300), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/teai"}},
7: {Number: 7, Title: "子", State: "open", CreatedAt: at(-650), UpdatedAt: at(-300), Assignees: []User{{"max"}}, Repository: Reference{"alterminal/teai"}}, 7: {Number: 7, Title: "子", State: "open", CreatedAt: iso(-650), UpdatedAt: iso(-300), Assignees: []User{{UserName: "max"}}, Repository: &Repository{FullName: "alterminal/teai"}},
}, },
}, },
comments: map[string][]Comment{ comments: map[string][]Comment{
"alterminal/teai/7": {{User: User{"max"}, CreatedAt: at(-300)}}, "alterminal/teai/7": {{User: &User{UserName: "max"}, CreatedAt: iso(-300)}},
}, },
} }
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
@@ -286,9 +289,9 @@ func TestScanStalledParentTracking(t *testing.T) {
// 子項 1 小時前恢復活動 → 父項 last_activity 跟著更新,未達門檻不列入; // 子項 1 小時前恢復活動 → 父項 last_activity 跟著更新,未達門檻不列入;
// 子項本身也不停滯。整份輸出應為空。 // 子項本身也不停滯。整份輸出應為空。
child := src.issues["alterminal/teai"][7] child := src.issues["alterminal/teai"][7]
child.UpdatedAt = at(-60) child.UpdatedAt = iso(-60)
src.issues["alterminal/teai"][7] = child src.issues["alterminal/teai"][7] = child
src.comments["alterminal/teai/7"] = []Comment{{User: User{"max"}, CreatedAt: at(-60)}} src.comments["alterminal/teai/7"] = []Comment{{User: &User{UserName: "max"}, CreatedAt: iso(-60)}}
got, err = ScanStalled(src, "admin", 4.0, now) got, err = ScanStalled(src, "admin", 4.0, now)
if err != nil { if err != nil {
t.Fatalf("ScanStalled: %v", err) t.Fatalf("ScanStalled: %v", err)
@@ -303,11 +306,11 @@ func TestScanStalledParentTrackingNotChild(t *testing.T) {
now := at(0) now := at(0)
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": repoWith("teai", true)}, repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/teai": { "alterminal/teai": {
47: {Number: 47, State: "open", Body: "規劃見 #39(更早)", CreatedAt: at(-700), UpdatedAt: at(-600), Assignees: []User{{"ceo"}}, Repository: Reference{"alterminal/teai"}}, 47: {Number: 47, State: "open", Body: "規劃見 #39(更早)", CreatedAt: iso(-700), UpdatedAt: iso(-600), Assignees: []User{{UserName: "ceo"}}, Repository: &Repository{FullName: "alterminal/teai"}},
39: {Number: 39, State: "open", CreatedAt: at(-2000), UpdatedAt: at(-60), Repository: Reference{"alterminal/teai"}}, 39: {Number: 39, State: "open", CreatedAt: iso(-2000), UpdatedAt: iso(-60), Repository: &Repository{FullName: "alterminal/teai"}},
}, },
}, },
} }
@@ -345,30 +348,30 @@ func TestScanStalledPullReasons(t *testing.T) {
h := true h := true
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": {{Name: "teai", HasPullRequests: &h}}}, repos: map[string][]Repo{"alterminal": {{Name: "teai", HasPullRequests: &h}}},
pulls: map[string][]PullRequest{ pulls: map[string][]PullRequest{
"alterminal/teai": { "alterminal/teai": {
{Number: 10, State: "open", Author: User{"max"}, CreatedAt: at(-600), UpdatedAt: at(-600)}, {Number: 10, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-600)},
{Number: 11, State: "open", Author: User{"max"}, CreatedAt: at(-600), UpdatedAt: at(-300), RequestedReviewers: []User{{"ceo"}}}, {Number: 11, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
{Number: 12, State: "open", Author: User{"max"}, CreatedAt: at(-600), UpdatedAt: at(-300), RequestedReviewers: []User{{"ceo"}}}, {Number: 12, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
{Number: 13, State: "open", Author: User{"max"}, CreatedAt: at(-600), UpdatedAt: at(-300), RequestedReviewers: []User{{"ceo"}}}, {Number: 13, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
}, },
}, },
comments: map[string][]Comment{ comments: map[string][]Comment{
"alterminal/teai/11": {{User: User{"max"}, CreatedAt: at(-300)}}, // author-idle "alterminal/teai/11": {{User: &User{UserName: "max"}, CreatedAt: iso(-300)}}, // author-idle
"alterminal/teai/12": {{User: User{"ceo"}, CreatedAt: at(-300)}}, // reviewer-idle "alterminal/teai/12": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}}, // reviewer-idle
"alterminal/teai/13": {{User: User{"dan"}, CreatedAt: at(-300)}}, // no-commenter(外部留言) "alterminal/teai/13": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300)}}, // no-commenter(外部留言)
}, },
} }
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
if err != nil { if err != nil {
t.Fatalf("ScanStalled: %v", err) t.Fatalf("ScanStalled: %v", err)
} }
byNumber := map[int]Item{} byNumber := map[int64]Item{}
for _, it := range got { for _, it := range got {
byNumber[it.Number] = it byNumber[it.Number] = it
} }
for n, wantReason := range map[int]string{10: "no-reviewer", 11: "author-idle", 12: "reviewer-idle", 13: "no-commenter"} { for n, wantReason := range map[int64]string{10: "no-reviewer", 11: "author-idle", 12: "reviewer-idle", 13: "no-commenter"} {
item, ok := byNumber[n] item, ok := byNumber[n]
if !ok { if !ok {
t.Fatalf("PR %d 應列入,got %v", n, got) t.Fatalf("PR %d 應列入,got %v", n, got)
@@ -391,15 +394,15 @@ func TestScanStalledNoPullsFlag(t *testing.T) {
h := false h := false
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": {{Name: "docs", HasPullRequests: &h}}}, repos: map[string][]Repo{"alterminal": {{Name: "docs", HasPullRequests: &h}}},
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/docs": { "alterminal/docs": {
1: {Number: 1, State: "open", CreatedAt: at(-600), UpdatedAt: at(-600), Repository: Reference{"alterminal/docs"}}, 1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/docs"}},
}, },
}, },
pulls: map[string][]PullRequest{ pulls: map[string][]PullRequest{
// 即使假資料有 PR,flag 關閉也不應掃。 // 即使假資料有 PR,flag 關閉也不應掃。
"alterminal/docs": {{Number: 2, State: "open", Author: User{"max"}, CreatedAt: at(-600), UpdatedAt: at(-600)}}, "alterminal/docs": {{Number: 2, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-600)}},
}, },
} }
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
@@ -416,10 +419,10 @@ func TestScanStalledSkipsPRsInIssues(t *testing.T) {
now := at(0) now := at(0)
src := &fakeSource{ src := &fakeSource{
orgs: []string{"alterminal"}, orgs: []string{"alterminal"},
repos: map[string][]Repository{"alterminal": repoWith("teai", true)}, repos: map[string][]Repo{"alterminal": repoWith("teai", true)},
issues: map[string]map[int]Issue{ issues: map[string]map[int64]Issue{
"alterminal/teai": { "alterminal/teai": {
1: {Number: 1, State: "open", CreatedAt: at(-600), UpdatedAt: at(-600), Repository: Reference{"alterminal/teai"}, PullRequest: struct{}{}}, 1: {Number: 1, State: "open", CreatedAt: iso(-600), UpdatedAt: iso(-600), Repository: &Repository{FullName: "alterminal/teai"}, PullRequest: &pullMarker{}},
}, },
}, },
} }
@@ -480,7 +483,7 @@ func TestPullJSON(t *testing.T) {
// TestScanStalledEmpty 無停滯項目 → 空輸出(CLI 層輸出 [])。 // TestScanStalledEmpty 無停滯項目 → 空輸出(CLI 層輸出 [])。
func TestScanStalledEmpty(t *testing.T) { func TestScanStalledEmpty(t *testing.T) {
now := at(0) now := at(0)
src := &fakeSource{orgs: []string{"alterminal"}, repos: map[string][]Repository{"alterminal": repoWith("teai", true)}} src := &fakeSource{orgs: []string{"alterminal"}, repos: map[string][]Repo{"alterminal": repoWith("teai", true)}}
got, err := ScanStalled(src, "admin", 4.0, now) got, err := ScanStalled(src, "admin", 4.0, now)
if err != nil { if err != nil {
t.Fatalf("ScanStalled: %v", err) t.Fatalf("ScanStalled: %v", err)
@@ -501,15 +504,15 @@ func TestScanStalledOrgError(t *testing.T) {
type errSource struct{} type errSource struct{}
func (errSource) MyOrganizations() ([]string, error) { return nil, errors.New("boom") } func (errSource) MyOrganizations() ([]string, error) { return nil, errors.New("boom") }
func (e errSource) OrganizationRepositories(string) ([]Repository, error) { func (e errSource) OrganizationRepositories(string) ([]Repo, error) {
return nil, errors.New("boom") return nil, errors.New("boom")
} }
func (e errSource) OpenIssues(string, string) ([]Issue, error) { return nil, errors.New("boom") } func (e errSource) OpenIssues(string, string) ([]Issue, error) { return nil, errors.New("boom") }
func (e errSource) OpenPulls(string, string) ([]PullRequest, error) { return nil, errors.New("boom") } func (e errSource) OpenPulls(string, string) ([]PullRequest, error) { return nil, errors.New("boom") }
func (e errSource) IssueComments(string, string, int) ([]Comment, error) { func (e errSource) IssueComments(string, string, int64) ([]Comment, error) {
return nil, errors.New("boom") return nil, errors.New("boom")
} }
func (e errSource) TryGetIssue(string, string, int) (Issue, bool, error) { func (e errSource) TryGetIssue(string, string, int64) (Issue, bool, error) {
return Issue{}, false, errors.New("boom") return Issue{}, false, errors.New("boom")
} }