internal/cli：stalled 與 xrefs 命令接線，完成 #7 CLI 層（堆疊於 #23）
- workflow 新增 StalledSource 介面（Source＋CurrentUser＋GetIssue）與 高階入口 RunStalled／ResolveIssueXrefs（xrefs 輸出附 source 出處） - APIClient 補上 StalledSource 面向（GetIssue／TryGetIssue 等） - CLI 新增 teai stalled [--hours N]（JSON 與 gitea.py 位元組相容： 停用 HTML 轉義、縮排 2）與 teai xrefs <owner>/<repo> <number> （404 → exit 3）；table 模式 stalled_hours 定點一位小數 - 接線層與 workflow 層單元測試（注入假資料源、固定時刻） - README 狀態行更新 驗證：go build／vet／test 全綠；對真實 API 並行掃描，stalled 輸出 與 gitea.py 位元組一致（2169 bytes）；xrefs 邊界案例（PR#50／ issue#49 略過、CJK 緊鄰、跨倉庫 owner/repo#N）與 Python 版一致。
This commit is contained in:
@@ -0,0 +1,231 @@
|
||||
// stalled_entry_test.go — RunStalled／ResolveIssueXrefs 高階入口的單元測試
|
||||
//（#7 CLI 接線；資料源注入假實作，離線可測）。
|
||||
package workflow
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// fakeStalledSource 包 fakeSource 補上 StalledSource 面向。
|
||||
type fakeStalledSource struct {
|
||||
*fakeSource
|
||||
username string
|
||||
// getIssueErr 模擬 GetIssue 失敗（xrefs 的 404 路徑）。
|
||||
getIssueErr error
|
||||
}
|
||||
|
||||
func (f *fakeStalledSource) CurrentUser() (string, error) { return f.username, nil }
|
||||
|
||||
func (f *fakeStalledSource) GetIssue(owner, repo string, number int64) (Issue, error) {
|
||||
if f.getIssueErr != nil {
|
||||
return Issue{}, f.getIssueErr
|
||||
}
|
||||
i, ok := f.issues[owner+"/"+repo][number]
|
||||
if !ok {
|
||||
return Issue{}, ¬FoundError{}
|
||||
}
|
||||
return i, nil
|
||||
}
|
||||
|
||||
type notFoundError struct{}
|
||||
|
||||
func (e *notFoundError) Error() string { return "404" }
|
||||
|
||||
// newStalledFixture 建構掃描情境：alterminal 組織兩個倉庫，
|
||||
// agents#1 是父追蹤項（引用 teai#2），teai#2 有較新留言。
|
||||
func newStalledFixture() *fakeStalledSource {
|
||||
return &fakeStalledSource{
|
||||
fakeSource: &fakeSource{
|
||||
orgs: []string{"alterminal"},
|
||||
repos: map[string][]Repo{"alterminal": {
|
||||
{Name: "agents", HasPullRequests: boolPtr(true)},
|
||||
{Name: "teai", HasPullRequests: boolPtr(true)},
|
||||
}},
|
||||
issues: map[string]map[int64]Issue{
|
||||
"alterminal/agents": {
|
||||
1: {Number: 1, Title: "父追蹤項", State: "open",
|
||||
Body: "子項：teai#2", CreatedAt: iso(-600), UpdatedAt: iso(-600),
|
||||
Repository: &Repository{FullName: "alterminal/agents"}},
|
||||
},
|
||||
"alterminal/teai": {
|
||||
2: {Number: 2, Title: "子項", State: "open",
|
||||
CreatedAt: iso(-500), UpdatedAt: iso(-90),
|
||||
Repository: &Repository{FullName: "alterminal/teai"}},
|
||||
},
|
||||
},
|
||||
pulls: map[string][]PullRequest{},
|
||||
comments: map[string][]Comment{
|
||||
"alterminal/teai/2": {
|
||||
{CreatedAt: iso(-90), User: &User{UserName: "alex"}, Body: "推進中"},
|
||||
},
|
||||
},
|
||||
},
|
||||
username: "ceo",
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunStalledParentTracking 驗證 RunStalled：父追蹤項把子項活動
|
||||
// 計入 last_activity（reason=parent-tracking），且門檻預設與覆寫皆可。
|
||||
func TestRunStalledParentTracking(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
// 預設 4 小時門檻：子項 90 分鐘前有活動 → 父項 last_activity 同步，
|
||||
// 未過門檻，清單為空。
|
||||
items, err := RunStalled(src, 0, at(0))
|
||||
if err != nil {
|
||||
t.Fatalf("RunStalled: %v", err)
|
||||
}
|
||||
if len(items) != 0 {
|
||||
t.Fatalf("預設門檻下不應有停滯項，得到 %d 筆", len(items))
|
||||
}
|
||||
// 門檻降到 1 小時：父追蹤項 last_activity 取子項活動（-90m）→
|
||||
// 停滯 1.5h 列入（reason=parent-tracking、附 child_activity）；
|
||||
// 子項 teai#2 本身也停滯 1.5h（no-assignee）。
|
||||
items, err = RunStalled(src, 1, at(0))
|
||||
if err != nil {
|
||||
t.Fatalf("RunStalled: %v", err)
|
||||
}
|
||||
if len(items) != 2 {
|
||||
t.Fatalf("應有兩筆（父追蹤項＋子項），得到 %d：%+v", len(items), items)
|
||||
}
|
||||
var parent *Item
|
||||
for i := range items {
|
||||
if items[i].Number == 1 {
|
||||
parent = &items[i]
|
||||
}
|
||||
}
|
||||
if parent == nil {
|
||||
t.Fatalf("找不到 agents#1：%+v", items)
|
||||
}
|
||||
if parent.Reason != "parent-tracking" || parent.Repo != "alterminal/agents" {
|
||||
t.Fatalf("agents#1 應為 parent-tracking，得到 %s（%s）", parent.Reason, parent.Repo)
|
||||
}
|
||||
if len(parent.ChildActivity) == 0 {
|
||||
t.Fatalf("parent-tracking 應附 child_activity")
|
||||
}
|
||||
if parent.StalledHours != 1.5 {
|
||||
t.Fatalf("last_activity 應取子項活動（-90m → 1.5h），得到 %.1f", parent.StalledHours)
|
||||
}
|
||||
}
|
||||
|
||||
// TestRunStalledNudgeCooldown 驗證催促冷卻：最後留言出自目前帳號
|
||||
// 且在 24 小時內 → 不列入；冷卻過後再出現。
|
||||
func TestRunStalledNudgeCooldown(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
setIssueBody(src, "alterminal", "agents", 1, "") // 移除子項引用
|
||||
src.comments["alterminal/agents/1"] = []Comment{
|
||||
{CreatedAt: iso(-2), User: &User{UserName: "ceo"}},
|
||||
}
|
||||
findOne := func(items []Item) bool {
|
||||
for _, it := range items {
|
||||
if it.Repo == "alterminal/agents" && it.Number == 1 {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
items, err := RunStalled(src, 1, at(0))
|
||||
if err != nil {
|
||||
t.Fatalf("RunStalled: %v", err)
|
||||
}
|
||||
if findOne(items) {
|
||||
t.Fatalf("催促冷卻期內（2 小時前留言）agents#1 不應列入，得到 %+v", items)
|
||||
}
|
||||
src.comments["alterminal/agents/1"] = []Comment{
|
||||
{CreatedAt: iso(-30 * 60), User: &User{UserName: "ceo"}},
|
||||
}
|
||||
items, err = RunStalled(src, 1, at(0))
|
||||
if err != nil {
|
||||
t.Fatalf("RunStalled: %v", err)
|
||||
}
|
||||
if !findOne(items) {
|
||||
t.Fatalf("冷卻（24h）過後 agents#1 應再出現，得到 %+v", items)
|
||||
}
|
||||
}
|
||||
|
||||
// TestResolveIssueXrefs 驗證 xrefs 入口：內文與留言的引用解析、
|
||||
// 去重、出處標記與單段 repo 的存在性邊界。
|
||||
func TestResolveIssueXrefs(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
setIssueBody(src, "alterminal", "agents", 1, "看 teai#2 與 #7，另見 alterminal/teai#2")
|
||||
src.comments["alterminal/agents/1"] = []Comment{
|
||||
{Body: "teai#2 已處理", User: &User{UserName: "alex"}, CreatedAt: iso(-10)},
|
||||
{Body: "nope#9 不存在", User: &User{UserName: "max"}, CreatedAt: iso(-5)},
|
||||
}
|
||||
// fixture 的組織倉庫只有 agents → teai#2 單段不解析（repo 不在
|
||||
// alterminal 組織清單）；補上 teai 倉庫讓單段解析成立。
|
||||
src.repos["alterminal"] = []Repo{
|
||||
{Name: "agents", HasPullRequests: boolPtr(true)},
|
||||
{Name: "teai", HasPullRequests: boolPtr(true)},
|
||||
}
|
||||
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveIssueXrefs: %v", err)
|
||||
}
|
||||
want := []XrefHit{
|
||||
{Owner: "alterminal", Repo: "teai", Number: 2, Source: "body"},
|
||||
{Owner: "alterminal", Repo: "agents", Number: 7, Source: "body"},
|
||||
}
|
||||
if len(hits) != len(want) {
|
||||
t.Fatalf("應解析出 %d 筆（留言重複的 teai#2 去重、nope#9 略過），得到 %d：%+v",
|
||||
len(want), len(hits), hits)
|
||||
}
|
||||
for i := range want {
|
||||
if hits[i] != want[i] {
|
||||
t.Fatalf("hits[%d] = %+v, want %+v", i, hits[i], want[i])
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TestResolveIssueXrefsCommentSource 驗證出處：僅出現在留言的引用
|
||||
// 標記為 comment。
|
||||
func TestResolveIssueXrefsCommentSource(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
setIssueBody(src, "alterminal", "agents", 1, "內文無引用")
|
||||
src.comments["alterminal/agents/1"] = []Comment{
|
||||
{Body: "追蹤 #9", User: &User{UserName: "alex"}, CreatedAt: iso(-10)},
|
||||
}
|
||||
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveIssueXrefs: %v", err)
|
||||
}
|
||||
if len(hits) != 1 || hits[0].Source != "comment" || hits[0].Number != 9 {
|
||||
t.Fatalf("應輸出一筆 source=comment 的 #9，得到 %+v", hits)
|
||||
}
|
||||
}
|
||||
|
||||
// TestResolveIssueXrefsGetError 驗證 GetIssue 失敗（如 404）層層回傳，
|
||||
// 由 CLI 映射結束碼。
|
||||
func TestResolveIssueXrefsGetError(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
src.getIssueErr = ¬FoundError{}
|
||||
if _, err := ResolveIssueXrefs(src, "alterminal", "agents", 1); err == nil {
|
||||
t.Fatalf("GetIssue 失敗應回傳錯誤")
|
||||
}
|
||||
}
|
||||
|
||||
func boolPtr(b bool) *bool { return &b }
|
||||
|
||||
// setIssueBody 修改 map 內 issue 的內文（map 元素不可定址，需整體重塞）。
|
||||
func setIssueBody(src *fakeStalledSource, owner, repo string, number int64, body string) {
|
||||
key := owner + "/" + repo
|
||||
issue := src.issues[key][number]
|
||||
issue.Body = body
|
||||
src.issues[key][number] = issue
|
||||
}
|
||||
|
||||
// TestResolveIssueXrefsEmptyBody 驗證無引用時輸出空（CLI 印 []）。
|
||||
func TestResolveIssueXrefsEmptyBody(t *testing.T) {
|
||||
src := newStalledFixture()
|
||||
setIssueBody(src, "alterminal", "agents", 1, strings.Repeat("無引用內文", 3))
|
||||
delete(src.comments, "alterminal/agents/1")
|
||||
hits, err := ResolveIssueXrefs(src, "alterminal", "agents", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveIssueXrefs: %v", err)
|
||||
}
|
||||
if len(hits) != 0 {
|
||||
t.Fatalf("無引用應輸出空清單，得到 %+v", hits)
|
||||
}
|
||||
_ = time.Now // time 僅供 iso/at 使用；保留 import。
|
||||
}
|
||||
Reference in New Issue
Block a user