milestones：新增跨倉庫里程碑總覽命令（#31）
- teai milestones（不帶 --repo）輸出跨所屬組織各倉庫 open 里程碑概況， 對應 gitea.py milestones（管理者巡邏，agents AGENTS.md 10.1）： 欄位 repo/id/title/url/open_issues/closed_issues/due_on/due_hours/ overdue/unassigned/updated_at，排序期限近者在前、無期限最後。 - internal/workflow.MilestoneOverview：判定核心（Source 注入、離線可測）； MilestoneEntry 自訂 MarshalJSON，鍵集鍵序與 gitea.py 全等 （null 表示、due_hours 定點一位、unassigned PR 條目帶 author）。 - internal/workflow.APIClient 增 OpenMilestones／MilestoneOpenIssues （issues 端點刻意不帶 type=issues，PR 條目保留供覆蓋檢查，同 gitea.py）。 - milestones --repo a/b 維持現行單倉庫 list 語義不變。 - 空清單輸出 []（gitea.py 無輸出；#26 慣例差異，README 已文件化）。 - 交叉驗證：同帳號同時跑 gitea.py milestones 與 teai milestones， 含逾期／未到期／無期限里程碑與未分派 issue／PR 條目，輸出位元組全等。
This commit is contained in:
@@ -173,5 +173,39 @@ func (a *APIClient) IssueComments(owner, repo string, number int64) ([]Comment,
|
||||
return a.ListComments(owner, repo, number)
|
||||
}
|
||||
|
||||
// 編譯期確認 APIClient 同時實作 Client 與 StalledSource。
|
||||
// ── MilestoneSource 面向（#31 跨倉庫里程碑總覽）────────────────────────
|
||||
// APIClient 在 StalledSource 之外另實作 MilestoneSource，讓 milestones
|
||||
// 總覽命令與既有命令共用同一個 HTTP 用戶端；查詢參數對照 gitea.py 的
|
||||
// list_open_milestones_for_repository／_milestone_open_issues。
|
||||
|
||||
// OpenMilestones 回傳倉庫的 open 里程碑（GET /repos/{o}/{r}/milestones?state=open）。
|
||||
func (a *APIClient) OpenMilestones(owner, repo string) ([]Milestone, error) {
|
||||
var ms []Milestone
|
||||
path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/milestones"
|
||||
opts := gitea.ListOptions{Extra: url.Values{"state": {"open"}}}
|
||||
if err := a.Client.ListAll(context.Background(), path, opts, &ms); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return ms, nil
|
||||
}
|
||||
|
||||
// MilestoneOpenIssues 回傳掛在指定里程碑（依名稱過濾，Gitea 以
|
||||
// milestones=<title> 查詢）的 open 條目。刻意**不**帶 type=issues——
|
||||
// PR 亦屬里程碑條目，保留兩者供覆蓋檢查（同 gitea.py
|
||||
// _milestone_open_issues；PR 帶 pull_request 標記由 workflow 判別）。
|
||||
func (a *APIClient) MilestoneOpenIssues(owner, repo, milestoneTitle string) ([]Issue, error) {
|
||||
var issues []Issue
|
||||
path := "/repos/" + url.PathEscape(owner) + "/" + url.PathEscape(repo) + "/issues"
|
||||
opts := gitea.ListOptions{Extra: url.Values{
|
||||
"state": {"open"},
|
||||
"milestones": {milestoneTitle},
|
||||
}}
|
||||
if err := a.Client.ListAll(context.Background(), path, opts, &issues); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return issues, nil
|
||||
}
|
||||
|
||||
// 編譯期確認 APIClient 同時實作 Client、StalledSource 與 MilestoneSource。
|
||||
var _ StalledSource = (*APIClient)(nil)
|
||||
var _ MilestoneSource = (*APIClient)(nil)
|
||||
|
||||
@@ -0,0 +1,256 @@
|
||||
// milestones.go — 跨倉庫里程碑總覽（teai #31；gitea.py milestones 的對應實作）。
|
||||
//
|
||||
// 各倉庫 open milestone 概況（管理者巡邏用，agents AGENTS.md 10.1）：期限近者
|
||||
// 在前的排序、逾期判定、未分派條目摘要與活躍度（updated_at 取里程碑本身與
|
||||
// 其 open 條位的最大值）。判定與輸出規則以 AGENTS.md 為單一來源，行為基準是
|
||||
// gitea.py 的 list_milestone_overview，本檔只實作、不改義。
|
||||
package workflow
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"sort"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
// Milestone 是里程碑物件（僅取總覽會用到的欄位）。
|
||||
// ID 與 DueOn 用指標：Gitea 回 null／缺漏時輸出 null
|
||||
// （對應 gitea.py milestone.get("id")／get("due_on") 的 None 語義）。
|
||||
type Milestone struct {
|
||||
ID *int64 `json:"id"`
|
||||
Title string `json:"title"`
|
||||
State string `json:"state"`
|
||||
DueOn *string `json:"due_on"`
|
||||
UpdatedAt string `json:"updated_at"`
|
||||
OpenIssues int64 `json:"open_issues"`
|
||||
ClosedIssues int64 `json:"closed_issues"`
|
||||
}
|
||||
|
||||
// MilestoneSource 是跨倉庫里程碑總覽需要的資料源（CLI 層以 API 實作；
|
||||
// 測試注入假資料，與 Source／StalledSource 同模式）。
|
||||
type MilestoneSource interface {
|
||||
// MyOrganizations 回傳目前帳號所屬組織清單。
|
||||
MyOrganizations() ([]string, error)
|
||||
// OrganizationRepositories 回傳組織的倉庫清單。
|
||||
OrganizationRepositories(org string) ([]Repo, error)
|
||||
// OpenMilestones 回傳倉庫的 open 里程碑。
|
||||
OpenMilestones(owner, repo string) ([]Milestone, error)
|
||||
// MilestoneOpenIssues 回傳掛在指定里程碑（依名稱過濾）的 open
|
||||
// issue 與 PR。刻意不設 type 過濾——兩者都保留供覆蓋檢查
|
||||
//（同 gitea.py _milestone_open_issues 的查詢參數；PR 帶
|
||||
// pull_request 標記，由本套件判別）。
|
||||
MilestoneOpenIssues(owner, repo, milestoneTitle string) ([]Issue, error)
|
||||
}
|
||||
|
||||
// UnassignedEntry 是里程碑 open 條目中未分派者的摘要。
|
||||
type UnassignedEntry struct {
|
||||
Type string
|
||||
Number int64
|
||||
Title string
|
||||
URL string
|
||||
// Author 僅 pull 條目輸出（且作者已知時；對應 gitea.py 只在
|
||||
// _pr_author_username 非空時放 author 鍵）。
|
||||
Author string
|
||||
}
|
||||
|
||||
// MarshalJSON 輸出鍵集與鍵序與 gitea.py 一致的物件。
|
||||
func (u UnassignedEntry) MarshalJSON() ([]byte, error) {
|
||||
var b strings.Builder
|
||||
b.WriteString(`{"type":`)
|
||||
writeJSON(&b, u.Type)
|
||||
b.WriteString(`,"number":`)
|
||||
fmt.Fprintf(&b, "%d", u.Number)
|
||||
b.WriteString(`,"title":`)
|
||||
writeJSON(&b, u.Title)
|
||||
b.WriteString(`,"url":`)
|
||||
writeJSON(&b, u.URL)
|
||||
if u.Author != "" {
|
||||
b.WriteString(`,"author":`)
|
||||
writeJSON(&b, u.Author)
|
||||
}
|
||||
b.WriteString(`}`)
|
||||
return []byte(b.String()), nil
|
||||
}
|
||||
|
||||
// MilestoneEntry 是總覽的單筆輸出（欄位對應 gitea.py list_milestone_overview
|
||||
// 的 dict 鍵序：repo、id、title、url、open_issues、closed_issues、due_on、
|
||||
// due_hours、overdue、unassigned、updated_at）。
|
||||
type MilestoneEntry struct {
|
||||
Repo string
|
||||
ID *int64
|
||||
Title string
|
||||
URL string
|
||||
OpenIssues int64
|
||||
ClosedIssues int64
|
||||
DueOn *string
|
||||
DueHours *float64
|
||||
Overdue bool
|
||||
Unassigned []UnassignedEntry
|
||||
UpdatedAt *string
|
||||
}
|
||||
|
||||
// MarshalJSON 輸出鍵集與鍵序與 gitea.py 完全一致的物件
|
||||
// （與 Item／stalled 的做法相同：手寫鍵序，null／浮點格式對齊 Python）。
|
||||
func (e MilestoneEntry) MarshalJSON() ([]byte, error) {
|
||||
var b strings.Builder
|
||||
b.WriteString(`{"repo":`)
|
||||
writeJSON(&b, e.Repo)
|
||||
b.WriteString(`,"id":`)
|
||||
if e.ID != nil {
|
||||
fmt.Fprintf(&b, "%d", *e.ID)
|
||||
} else {
|
||||
b.WriteString("null")
|
||||
}
|
||||
b.WriteString(`,"title":`)
|
||||
writeJSON(&b, e.Title)
|
||||
b.WriteString(`,"url":`)
|
||||
writeJSON(&b, e.URL)
|
||||
b.WriteString(`,"open_issues":`)
|
||||
fmt.Fprintf(&b, "%d", e.OpenIssues)
|
||||
b.WriteString(`,"closed_issues":`)
|
||||
fmt.Fprintf(&b, "%d", e.ClosedIssues)
|
||||
b.WriteString(`,"due_on":`)
|
||||
writeJSON(&b, e.DueOn)
|
||||
b.WriteString(`,"due_hours":`)
|
||||
if e.DueHours != nil {
|
||||
// Python round(x, 1) 的 json 輸出是 48.0／10.4（定點一位小數）。
|
||||
b.WriteString(strconv.FormatFloat(round1(*e.DueHours), 'f', 1, 64))
|
||||
} else {
|
||||
b.WriteString("null")
|
||||
}
|
||||
b.WriteString(`,"overdue":`)
|
||||
b.WriteString(strconv.FormatBool(e.Overdue))
|
||||
b.WriteString(`,"unassigned":`)
|
||||
writeJSON(&b, e.Unassigned)
|
||||
b.WriteString(`,"updated_at":`)
|
||||
writeJSON(&b, e.UpdatedAt)
|
||||
b.WriteString(`}`)
|
||||
return []byte(b.String()), nil
|
||||
}
|
||||
|
||||
// MilestoneOverview 收集跨組織各倉庫的 open 里程碑概況，依（due_on，
|
||||
// 無則視為最遠）由近到遠排序（穩定排序：同 due_on 者保持掃描順序，
|
||||
// 對應 Python list.sort 的穩定性）。webBase 是站點網址前綴
|
||||
// （scheme://host），空字串時 url 欄位輸出 ""（同 gitea.py 在
|
||||
// GITEA_WEB_DOMAIN 缺漏時的行為）。
|
||||
func MilestoneOverview(src MilestoneSource, webBase string, now time.Time) ([]MilestoneEntry, error) {
|
||||
orgs, err := src.MyOrganizations()
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out := []MilestoneEntry{}
|
||||
for _, org := range orgs {
|
||||
repos, err := src.OrganizationRepositories(org)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for _, repo := range repos {
|
||||
if repo.Name == "" || repo.Empty {
|
||||
continue
|
||||
}
|
||||
ms, err := src.OpenMilestones(org, repo.Name)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for i := range ms {
|
||||
entry, err := milestoneEntry(src, org, repo.Name, &ms[i], webBase, now)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out = append(out, entry)
|
||||
}
|
||||
}
|
||||
}
|
||||
// gitea.py 的排序鍵：(due_on is None, due_on or "")——有期限者在前、
|
||||
// 期限近者在前；無期限者在後。
|
||||
sort.SliceStable(out, func(a, bb int) bool {
|
||||
x, y := out[a].DueOn, out[bb].DueOn
|
||||
if (x == nil) != (y == nil) {
|
||||
return y == nil
|
||||
}
|
||||
if x != nil {
|
||||
return *x < *y
|
||||
}
|
||||
return false
|
||||
})
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// milestoneEntry 計算單一里程碑的總覽欄位（對應 gitea.py 迴圈體）。
|
||||
func milestoneEntry(src MilestoneSource, org, repo string, m *Milestone, webBase string, now time.Time) (MilestoneEntry, error) {
|
||||
// due_hours／overdue：due_on 缺漏或無法解析 → null／false。
|
||||
// Python 以未捨入值判定 overdue（round 只作用於輸出），
|
||||
// 邊界（如 0.04 小時 → overdue=true、due_hours=0.0）保持一致。
|
||||
var dueHours *float64
|
||||
overdue := false
|
||||
if m.DueOn != nil {
|
||||
if due, ok := parseMoment(*m.DueOn); ok {
|
||||
raw := now.Sub(due).Hours()
|
||||
dueHours = &raw
|
||||
overdue = raw > 0
|
||||
}
|
||||
}
|
||||
openEntries, err := src.MilestoneOpenIssues(org, repo, m.Title)
|
||||
if err != nil {
|
||||
return MilestoneEntry{}, err
|
||||
}
|
||||
// 未分派條目摘要（assignees 為空者）；updated_at 取里程碑本身與
|
||||
// 各 open 條目 updated_at 的最大值（供巡邏判斷活躍度）。
|
||||
unassigned := []UnassignedEntry{}
|
||||
moments := []time.Time{}
|
||||
if updated, ok := parseMoment(m.UpdatedAt); ok {
|
||||
moments = append(moments, updated)
|
||||
}
|
||||
for i := range openEntries {
|
||||
entry := &openEntries[i]
|
||||
if updated, ok := parseMoment(entry.UpdatedAt); ok {
|
||||
moments = append(moments, updated)
|
||||
}
|
||||
if len(AssigneeNames(entry)) > 0 {
|
||||
continue
|
||||
}
|
||||
summary := UnassignedEntry{
|
||||
Type: "issue",
|
||||
Number: entry.issueNumber(),
|
||||
Title: entry.Title,
|
||||
URL: entry.WebURL(),
|
||||
}
|
||||
if entry.PullRequest != nil {
|
||||
summary.Type = "pull"
|
||||
if author := entry.User.Name(); author != "" {
|
||||
summary.Author = author
|
||||
}
|
||||
}
|
||||
unassigned = append(unassigned, summary)
|
||||
}
|
||||
var updatedAt *string
|
||||
if len(moments) > 0 {
|
||||
s := FormatMoment(maxTime(moments))
|
||||
updatedAt = &s
|
||||
}
|
||||
return MilestoneEntry{
|
||||
Repo: org + "/" + repo,
|
||||
ID: m.ID,
|
||||
Title: m.Title,
|
||||
URL: milestoneURL(webBase, org, repo, m.ID),
|
||||
OpenIssues: m.OpenIssues,
|
||||
ClosedIssues: m.ClosedIssues,
|
||||
DueOn: m.DueOn,
|
||||
DueHours: dueHours,
|
||||
Overdue: overdue,
|
||||
Unassigned: unassigned,
|
||||
UpdatedAt: updatedAt,
|
||||
}, nil
|
||||
}
|
||||
|
||||
// milestoneURL 組里程碑網頁網址；webBase 空或 id 缺漏回 ""
|
||||
// （對應 gitea.py _milestone_url 的兩個空值條件。Python 原版不做
|
||||
// URL 跳脫——一般組織／倉庫名皆為安全字元，這裡保持一致以求位元組相容）。
|
||||
func milestoneURL(webBase, org, repo string, id *int64) string {
|
||||
if webBase == "" || id == nil {
|
||||
return ""
|
||||
}
|
||||
return strings.TrimRight(webBase, "/") + "/" + org + "/" + repo +
|
||||
"/milestone/" + strconv.FormatInt(*id, 10)
|
||||
}
|
||||
@@ -0,0 +1,262 @@
|
||||
// milestones_test.go — MilestoneOverview 的單元測試（#31）。
|
||||
//
|
||||
// 資料源注入假實作（離線可測）；鍵序、null 表示、排序與 overdue
|
||||
// 判定對照 gitea.py list_milestone_overview 的 Python 語義。
|
||||
package workflow
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// fakeMilestoneSource 以記憶體資料實作 MilestoneSource。
|
||||
type fakeMilestoneSource struct {
|
||||
orgs []string
|
||||
repos map[string][]Repo
|
||||
milestones map[string][]Milestone
|
||||
openIssues map[string][]Issue // key: owner/repo?milestone=<title>
|
||||
}
|
||||
|
||||
func (f *fakeMilestoneSource) MyOrganizations() ([]string, error) { return f.orgs, nil }
|
||||
func (f *fakeMilestoneSource) OrganizationRepositories(org string) ([]Repo, error) {
|
||||
return f.repos[org], nil
|
||||
}
|
||||
func (f *fakeMilestoneSource) OpenMilestones(owner, repo string) ([]Milestone, error) {
|
||||
return f.milestones[owner+"/"+repo], nil
|
||||
}
|
||||
func (f *fakeMilestoneSource) MilestoneOpenIssues(owner, repo, title string) ([]Issue, error) {
|
||||
return f.openIssues[owner+"/"+repo+"?milestone="+title], nil
|
||||
}
|
||||
|
||||
func msPtr(s string) *string { return &s }
|
||||
func idPtr(i int64) *int64 { return &i }
|
||||
|
||||
// newMilestoneFixture 建構情境：alterminal 兩倉庫、三里程碑
|
||||
// （teai 有期限將至、agents 有逾期與無期限）。
|
||||
func newMilestoneFixture() *fakeMilestoneSource {
|
||||
return &fakeMilestoneSource{
|
||||
orgs: []string{"alterminal"},
|
||||
repos: map[string][]Repo{"alterminal": {
|
||||
{Name: "agents", HasPullRequests: boolPtr(true)},
|
||||
{Name: "teai", HasPullRequests: boolPtr(true)},
|
||||
{Name: "empty-repo", Empty: true}, // 空倉庫應跳過
|
||||
}},
|
||||
milestones: map[string][]Milestone{
|
||||
"alterminal/agents": {
|
||||
{ID: idPtr(7), Title: "MVP", State: "open",
|
||||
DueOn: msPtr("2026-09-09T00:00:00Z"), UpdatedAt: "2026-09-01T00:00:00Z",
|
||||
OpenIssues: 3, ClosedIssues: 1},
|
||||
{ID: idPtr(8), Title: "v1", State: "open",
|
||||
DueOn: nil, UpdatedAt: "2026-09-02T00:00:00Z",
|
||||
OpenIssues: 1, ClosedIssues: 0},
|
||||
},
|
||||
"alterminal/teai": {
|
||||
{ID: idPtr(3), Title: "CLI", State: "open",
|
||||
DueOn: msPtr("2026-09-12T00:00:00Z"), UpdatedAt: "2026-09-05T00:00:00Z",
|
||||
OpenIssues: 2, ClosedIssues: 5},
|
||||
},
|
||||
},
|
||||
openIssues: map[string][]Issue{
|
||||
// agents MVP：一個未分派 issue、一個未分派 PR、一個已分派 issue。
|
||||
"alterminal/agents?milestone=MVP": {
|
||||
{Number: 31, Title: "總覽命令", State: "open",
|
||||
UpdatedAt: "2026-09-10T01:00:00Z",
|
||||
Repository: &Repository{FullName: "alterminal/agents"},
|
||||
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/31"},
|
||||
{Number: 32, Title: "文件", State: "open",
|
||||
UpdatedAt: "2026-09-08T00:00:00Z",
|
||||
Repository: &Repository{FullName: "alterminal/agents"},
|
||||
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/pulls/32",
|
||||
PullRequest: &pullMarker{}, User: &User{UserName: "alex"}},
|
||||
{Number: 33, Title: "已分派", State: "open",
|
||||
UpdatedAt: "2026-09-07T00:00:00Z",
|
||||
Repository: &Repository{FullName: "alterminal/agents"},
|
||||
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/33",
|
||||
Assignee: &User{UserName: "queena"}},
|
||||
},
|
||||
// agents v1（無期限）：條目比里程碑本身新 → updated_at 取條目。
|
||||
"alterminal/agents?milestone=v1": {
|
||||
{Number: 40, Title: "無人理", State: "open",
|
||||
UpdatedAt: "2026-09-09T23:30:00Z",
|
||||
Repository: &Repository{FullName: "alterminal/agents"},
|
||||
HTMLURL: "https://gitea.alterminal.com/alterminal/agents/issues/40"},
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
// TestMilestoneOverviewSortAndOverdue 驗證排序（期限近者在前、無期限在後）
|
||||
// 與 overdue／due_hours 計算。
|
||||
func TestMilestoneOverviewSortAndOverdue(t *testing.T) {
|
||||
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
|
||||
entries, err := MilestoneOverview(newMilestoneFixture(), "https://gitea.alterminal.com", now)
|
||||
if err != nil {
|
||||
t.Fatalf("MilestoneOverview: %v", err)
|
||||
}
|
||||
if len(entries) != 3 {
|
||||
t.Fatalf("應有 3 筆（空倉庫跳過），得到 %d", len(entries))
|
||||
}
|
||||
// 排序：MVP（2026-09-09，已過期）→ CLI（2026-09-12）→ v1（無期限）。
|
||||
wantOrder := []string{"alterminal/agents#MVP", "alterminal/teai#CLI", "alterminal/agents#v1"}
|
||||
for i, want := range wantOrder {
|
||||
got := entries[i].Repo + "#" + entries[i].Title
|
||||
if got != want {
|
||||
t.Errorf("第 %d 筆應為 %s，得到 %s", i, want, got)
|
||||
}
|
||||
}
|
||||
// MVP：due 2026-09-09T00:00Z、now 09-10T08:00Z → 32 小時、逾期。
|
||||
if !entries[0].Overdue {
|
||||
t.Errorf("MVP 應逾期")
|
||||
}
|
||||
if entries[0].DueHours == nil || *entries[0].DueHours != 32.0 {
|
||||
t.Errorf("MVP due_hours 應 32.0，得到 %v", entries[0].DueHours)
|
||||
}
|
||||
// CLI：未到期。
|
||||
if entries[1].Overdue {
|
||||
t.Errorf("CLI 不應逾期")
|
||||
}
|
||||
// v1：無期限 → null。
|
||||
if entries[2].DueOn != nil || entries[2].DueHours != nil || entries[2].Overdue {
|
||||
t.Errorf("v1 無期限應為 null/false，得到 %+v", entries[2])
|
||||
}
|
||||
}
|
||||
|
||||
// TestMilestoneOverviewUnassigned 驗證未分派條目摘要（issue 無 author、
|
||||
// pull 帶 author）與 updated_at 取最大值。
|
||||
func TestMilestoneOverviewUnassigned(t *testing.T) {
|
||||
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
|
||||
entries, err := MilestoneOverview(newMilestoneFixture(), "https://gitea.alterminal.com", now)
|
||||
if err != nil {
|
||||
t.Fatalf("MilestoneOverview: %v", err)
|
||||
}
|
||||
var mvp *MilestoneEntry
|
||||
for i := range entries {
|
||||
if entries[i].Title == "MVP" {
|
||||
mvp = &entries[i]
|
||||
}
|
||||
}
|
||||
if mvp == nil {
|
||||
t.Fatalf("找不到 MVP")
|
||||
}
|
||||
// 未分派：#31（issue）、#32（PR, author=alex）；#33 已分派不列。
|
||||
if len(mvp.Unassigned) != 2 {
|
||||
t.Fatalf("MVP 應有 2 筆未分派，得到 %d：%+v", len(mvp.Unassigned), mvp.Unassigned)
|
||||
}
|
||||
if mvp.Unassigned[0].Type != "issue" || mvp.Unassigned[0].Number != 31 {
|
||||
t.Errorf("第一筆未分派應為 issue #31，得到 %+v", mvp.Unassigned[0])
|
||||
}
|
||||
if mvp.Unassigned[1].Type != "pull" || mvp.Unassigned[1].Number != 32 || mvp.Unassigned[1].Author != "alex" {
|
||||
t.Errorf("第二筆未分派應為 pull #32（author=alex），得到 %+v", mvp.Unassigned[1])
|
||||
}
|
||||
// updated_at：max(里程碑 09-01, #31 09-10T01:00Z) → 後者。
|
||||
if mvp.UpdatedAt == nil || *mvp.UpdatedAt != "2026-09-10T01:00:00+00:00" {
|
||||
t.Errorf("MVP updated_at 應取條目最大值 2026-09-10T01:00:00+00:00，得到 %v", mvp.UpdatedAt)
|
||||
}
|
||||
// url 組法。
|
||||
if mvp.URL != "https://gitea.alterminal.com/alterminal/agents/milestone/7" {
|
||||
t.Errorf("MVP url 應為 milestone/7，得到 %s", mvp.URL)
|
||||
}
|
||||
}
|
||||
|
||||
// TestMilestoneOverviewJSONKeys 驗證 JSON 鍵集與鍵序與 gitea.py 一致，
|
||||
// 以及 null／陣列空表示（unassigned 空 → []）。
|
||||
func TestMilestoneOverviewJSONKeys(t *testing.T) {
|
||||
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
|
||||
entries, err := MilestoneOverview(newMilestoneFixture(), "", now)
|
||||
if err != nil {
|
||||
t.Fatalf("MilestoneOverview: %v", err)
|
||||
}
|
||||
// v1：無期限、無未分派條目 → due_on/due_hours/updated_at 的 null 表示、
|
||||
// unassigned=[]、webBase 空 → url=""。
|
||||
var v1 *MilestoneEntry
|
||||
for i := range entries {
|
||||
if entries[i].Title == "v1" {
|
||||
v1 = &entries[i]
|
||||
}
|
||||
}
|
||||
if v1 == nil {
|
||||
t.Fatalf("找不到 v1")
|
||||
}
|
||||
// 手寫期望 JSON（縮排 2、鍵序照 gitea.py dict 實字序）。
|
||||
b, err := json.Marshal(v1)
|
||||
if err != nil {
|
||||
t.Fatalf("Marshal: %v", err)
|
||||
}
|
||||
// 以逐鍵比對為準（MarshalIndent 因自訂 MarshalJSON 不縮排內層）。
|
||||
var obj map[string]json.RawMessage
|
||||
if err := json.Unmarshal(b, &obj); err != nil {
|
||||
t.Fatalf("Unmarshal: %v", err)
|
||||
}
|
||||
wantKeys := []string{"repo", "id", "title", "url", "open_issues", "closed_issues",
|
||||
"due_on", "due_hours", "overdue", "unassigned", "updated_at"}
|
||||
// 鍵序：json.Unmarshal 到 map 會失序；改檢查原始字串的鍵出現順序。
|
||||
pos := -1
|
||||
for _, k := range wantKeys {
|
||||
i := strings.Index(string(b), `"`+k+`":`)
|
||||
if i < 0 {
|
||||
t.Fatalf("輸出缺少鍵 %q：%s", k, b)
|
||||
}
|
||||
if i < pos {
|
||||
t.Fatalf("鍵 %q 順序錯誤：%s", k, b)
|
||||
}
|
||||
pos = i
|
||||
}
|
||||
for _, kv := range []struct {
|
||||
key string
|
||||
want string
|
||||
}{
|
||||
{"repo", `"alterminal/agents"`},
|
||||
{"due_on", `null`},
|
||||
{"due_hours", `null`},
|
||||
{"overdue", `false`},
|
||||
{"url", `""`},
|
||||
} {
|
||||
if got := string(obj[kv.key]); got != kv.want {
|
||||
t.Errorf("%s 應為 %s，得到 %s", kv.key, kv.want, got)
|
||||
}
|
||||
}
|
||||
if !strings.Contains(string(b), `"number":40`) {
|
||||
t.Errorf("未分派條目應含 number 40：%s", b)
|
||||
}
|
||||
// pull 條目的 author 鍵：有作者才輸出（無則不該出現 "author"）。
|
||||
if strings.Contains(string(obj["unassigned"]), `"author"`) {
|
||||
t.Errorf("issue 條目不應有 author 鍵：%s", obj["unassigned"])
|
||||
}
|
||||
}
|
||||
|
||||
// TestMilestoneOverviewDueHoursRounding 驗證 due_hours 捨入到一位小數，
|
||||
// 且 overdue 以未捨入值判定（0.04h → 0.0 但 overdue=true）。
|
||||
func TestMilestoneOverviewDueHoursRounding(t *testing.T) {
|
||||
src := &fakeMilestoneSource{
|
||||
orgs: []string{"alterminal"},
|
||||
repos: map[string][]Repo{"alterminal": {{Name: "r"}}},
|
||||
milestones: map[string][]Milestone{
|
||||
"alterminal/r": {
|
||||
{ID: idPtr(1), Title: "edge", State: "open",
|
||||
DueOn: msPtr("2026-09-10T07:57:36Z"), UpdatedAt: "2026-09-10T07:00:00Z"},
|
||||
},
|
||||
},
|
||||
openIssues: map[string][]Issue{},
|
||||
}
|
||||
now := time.Date(2026, 9, 10, 8, 0, 0, 0, time.UTC)
|
||||
entries, err := MilestoneOverview(src, "", now)
|
||||
if err != nil {
|
||||
t.Fatalf("MilestoneOverview: %v", err)
|
||||
}
|
||||
if len(entries) != 1 {
|
||||
t.Fatalf("應有 1 筆，得到 %d", len(entries))
|
||||
}
|
||||
// 144 秒 = 0.04 小時 → round1 → 0.0；未捨入 > 0 → overdue=true。
|
||||
b, err := json.Marshal(entries[0])
|
||||
if err != nil {
|
||||
t.Fatalf("Marshal: %v", err)
|
||||
}
|
||||
if !strings.Contains(string(b), `"due_hours":0.0`) {
|
||||
t.Errorf("due_hours 應捨入為 0.0：%s", b)
|
||||
}
|
||||
if !strings.Contains(string(b), `"overdue":true`) {
|
||||
t.Errorf("overdue 應以未捨入值判定為 true：%s", b)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user