alterminal/teai
7
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: stalled PR 作者已交棒審核改判 reviewer-idle（agents #51）

Browse Source 
considerPull 的 author-idle 分支缺少 #47 的交棒檢查，且既有
IsDeliveryReport 訊號為 issue 交付報告設計，PR 端「已就緒，可審閱＋
@審核者」形態無對應訊號——fox#60 作者留言交棒後仍被誤判 author-idle。

新增 IsReviewHandoff（@目前審核者帳號 ∧ 就緒語，mention 邊界感知
避免 @chenyunda218 誤命中 chenyunda），considerPull 在判 author-idle
前檢查，命中改判 reviewer-idle，讓既有 48 小時改派規則自然適用。
gitea.py 側 _consider pull 分支以 _is_review_handoff 同步（另 PR）。
This commit is contained in:
chenyunda218
2026-09-16 13:17:55 +08:00
parent a9abf96a42
commit 4a5d02fd70
5 changed files with 130 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/workflow/workflow_test.go
+10 -3
View File
@@ -414,12 +414,16 @@ func TestScanStalledPullReasons(t *testing.T) {
{Number: 11, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
{Number: 12, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
{Number: 13, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "ceo"}}},
// agents #51：作者最後留言含審核交棒（@審核者＋就緒語）→ reviewer-idle。
{Number: 14, User: &User{UserName: "max"}, CreatedAt: iso(-600), UpdatedAt: iso(-300), RequestedReviewers: []User{{UserName: "chenyunda218"}}},
},
},
comments: map[string][]Comment{
"alterminal/teai/11": {{User: &User{UserName: "max"}, CreatedAt: iso(-300)}}, // author-idle
"alterminal/teai/12": {{User: &User{UserName: "ceo"}, CreatedAt: iso(-300)}}, // reviewer-idle
"alterminal/teai/13": {{User: &User{UserName: "dan"}, CreatedAt: iso(-300)}}, // no-commenter（外部留言）
// fox#60 形態（agents #51）：作者留言 @chenyunda218＋「已就緒，可審閱」→ 審核交棒。
"alterminal/teai/14": {{User: &User{UserName: "max"}, CreatedAt: iso(-300), Body: "狀態回報：分支無需再變更，CI 已通過。@chenyunda218 PR 已就緒，可審閱。"}},
},
}
got, err := ScanStalled(src, "admin", 4.0, now)
@@ -430,7 +434,7 @@ func TestScanStalledPullReasons(t *testing.T) {
for _, it := range got {
byNumber[it.Number] = it
}
for n, wantReason := range map[int64]string{10: "no-reviewer", 11: "author-idle", 12: "reviewer-idle", 13: "no-commenter"} {
for n, wantReason := range map[int64]string{10: "no-reviewer", 11: "author-idle", 12: "reviewer-idle", 13: "no-commenter", 14: "reviewer-idle"} {
item, ok := byNumber[n]
if !ok {
t.Fatalf("PR %d 應列入，got %v", n, got)
@@ -439,12 +443,15 @@ func TestScanStalledPullReasons(t *testing.T) {
t.Errorf("PR %d reason = %q, want %q", n, item.Reason, wantReason)
}
}
if len(got) != 4 {
t.Fatalf("應 4 筆，got %d", len(got))
if len(got) != 5 {
t.Fatalf("應 5 筆，got %d", len(got))
}
if byNumber[10].Author != "max" {
t.Errorf("PR 10 author 應為 max，got %q", byNumber[10].Author)
}
if byNumber[14].LastCommentBy != "max" {
t.Errorf("PR 14 last_comment_by 應為 max（作者留言後交棒），got %q", byNumber[14].LastCommentBy)
}
}
// TestScanStalledNoPullsFlag 停用 PR 的倉庫仍掃 issues，只跳過 PR。