dailyops:list 命令 --state all 明確帶 state=all(#33)
issues/milestones 端點省略 state 時 API 預設 open,closed 項目漏列; pulls 端點省略時雖回全部,仍明確帶上避免依賴端點預設。三處同修並補 回歸測試(TestStateAllSendsExplicitParam)。
This commit is contained in:
@@ -170,10 +170,10 @@ func (o *Ops) ListIssues(ctx context.Context, owner, repo, state string) ([]Issu
|
||||
if state == "" {
|
||||
state = "open"
|
||||
}
|
||||
// state 一律明確傳給 API:issues/milestones 端點省略 state 時預設
|
||||
// open(#33),closed 項目會漏列;all 也不能省略。
|
||||
extra := url.Values{}
|
||||
if state != "all" {
|
||||
extra.Set("state", state)
|
||||
}
|
||||
extra.Set("state", state)
|
||||
// type=issues:排除 PR(PR 在此端點帶 pull_request 欄位)。
|
||||
extra.Set("type", "issues")
|
||||
var issues []Issue
|
||||
@@ -246,10 +246,10 @@ func (o *Ops) ListPulls(ctx context.Context, owner, repo, state string) ([]Pull,
|
||||
if state == "" {
|
||||
state = "open"
|
||||
}
|
||||
// state 一律明確傳給 API:pulls 端點省略 state 時雖回全部,仍明確
|
||||
// 帶上,避免依賴端點預設值(#33)。
|
||||
extra := url.Values{}
|
||||
if state != "all" {
|
||||
extra.Set("state", state)
|
||||
}
|
||||
extra.Set("state", state)
|
||||
var pulls []Pull
|
||||
if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/pulls", gitea.ListOptions{Extra: extra}, &pulls); err != nil {
|
||||
return nil, err
|
||||
@@ -320,10 +320,10 @@ func (o *Ops) ListMilestones(ctx context.Context, owner, repo, state string) ([]
|
||||
if state == "" {
|
||||
state = "open"
|
||||
}
|
||||
// state 一律明確傳給 API:milestones 端點省略 state 時預設 open
|
||||
// (#33),closed 項目會漏列。
|
||||
extra := url.Values{}
|
||||
if state != "all" {
|
||||
extra.Set("state", state)
|
||||
}
|
||||
extra.Set("state", state)
|
||||
var ms []Milestone
|
||||
if err := o.Client.ListAll(ctx, repoPath(owner, repo)+"/milestones", gitea.ListOptions{Extra: extra}, &ms); err != nil {
|
||||
return nil, err
|
||||
|
||||
Reference in New Issue
Block a user